[media] saa7146: Use current logging styles

Standardize the mechanisms to emit logging messages.

A few other modules used an #include from saa7146,
convert those at the same time.

Add pr_fmt.
Convert printks to pr_<level>
Convert printks without KERN_<level> to appropriate pr_<level>.
Convert logging macros requiring multiple parentheses to normal style.
Removed embedded prefixes when pr_fmt was added.
Whitespace cleanups when around other conversions.
Use printf extension %pM to print mac address.
Coalesce format strings.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Michael Hunold <michael@mihu.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

2 files changed, 38 insertions, 36 deletions

diff --git a/drivers/media/dvb/ttpci/av7110_v4l.c b/drivers/media/dvb/ttpci/av7110_v4l.c
index cdd31cae46c..ee8ee1d481f 100644
--- a/drivers/media/dvb/ttpci/av7110_v4l.c
+++ b/drivers/media/dvb/ttpci/av7110_v4l.c
@@ -25,6 +25,8 @@
  * the project's page is at http://www.linuxtv.org/ 
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/delay.h>
@@ -253,7 +255,7 @@ static int av7110_dvb_c_switch(struct saa7146_fh *fh)
 
                 switch (av7110->current_input) {
                 case 1:
-                        dprintk(1, "switching SAA7113 to Analog Tuner Input.\n");
+                        dprintk(1, "switching SAA7113 to Analog Tuner Input\n");
                         msp_writereg(av7110, MSP_WR_DSP, 0x0008, 0x0000); // loudspeaker source
                         msp_writereg(av7110, MSP_WR_DSP, 0x0009, 0x0000); // headphone source
                         msp_writereg(av7110, MSP_WR_DSP, 0x000a, 0x0000); // SCART 1 source
@@ -263,7 +265,7 @@ static int av7110_dvb_c_switch(struct saa7146_fh *fh)
 
                         if (av7110->analog_tuner_flags & ANALOG_TUNER_VES1820) {
                                 if (ves1820_writereg(dev, 0x09, 0x0f, 0x60))
-                                        dprintk(1, "setting band in demodulator failed.\n");
+                                        dprintk(1, "setting band in demodulator failed\n");
                         } else if (av7110->analog_tuner_flags & ANALOG_TUNER_STV0297) {
                                 saa7146_setgpio(dev, 1, SAA7146_GPIO_OUTHI); // TDA9819 pin9(STD)
                                 saa7146_setgpio(dev, 3, SAA7146_GPIO_OUTHI); // TDA9819 pin30(VIF)
@@ -272,17 +274,17 @@ static int av7110_dvb_c_switch(struct saa7146_fh *fh)
                                 dprintk(1, "saa7113 write failed @ card %d", av7110->dvb_adapter.num);
                         break;
                 case 2:
-                        dprintk(1, "switching SAA7113 to Video AV CVBS Input.\n");
+                        dprintk(1, "switching SAA7113 to Video AV CVBS Input\n");
                         if (i2c_writereg(av7110, 0x48, 0x02, 0xd2) != 1)
                                 dprintk(1, "saa7113 write failed @ card %d", av7110->dvb_adapter.num);
                         break;
                 case 3:
-                        dprintk(1, "switching SAA7113 to Video AV Y/C Input.\n");
+                        dprintk(1, "switching SAA7113 to Video AV Y/C Input\n");
                         if (i2c_writereg(av7110, 0x48, 0x02, 0xd9) != 1)
                                 dprintk(1, "saa7113 write failed @ card %d", av7110->dvb_adapter.num);
                         break;
                 default:
-                        dprintk(1, "switching SAA7113 to Input: AV7110: SAA7113: invalid input.\n");
+                        dprintk(1, "switching SAA7113 to Input: AV7110: SAA7113: invalid input\n");
                 }
         } else {
                 adswitch = 0;
@@ -299,7 +301,7 @@ static int av7110_dvb_c_switch(struct saa7146_fh *fh)
 
                 if (av7110->analog_tuner_flags & ANALOG_TUNER_VES1820) {
                         if (ves1820_writereg(dev, 0x09, 0x0f, 0x20))
-                                dprintk(1, "setting band in demodulator failed.\n");
+                                dprintk(1, "setting band in demodulator failed\n");
                 } else if (av7110->analog_tuner_flags & ANALOG_TUNER_STV0297) {
                         saa7146_setgpio(dev, 1, SAA7146_GPIO_OUTLO); // TDA9819 pin9(STD)
                         saa7146_setgpio(dev, 3, SAA7146_GPIO_OUTLO); // TDA9819 pin30(VIF)
@@ -413,7 +415,7 @@ static int vidioc_g_frequency(struct file *file, void *fh, struct v4l2_frequency
         struct saa7146_dev *dev = ((struct saa7146_fh *)fh)->dev;
         struct av7110 *av7110 = (struct av7110 *)dev->ext_priv;
 
-        dprintk(2, "VIDIOC_G_FREQ: freq:0x%08x.\n", f->frequency);
+        dprintk(2, "VIDIOC_G_FREQ: freq:0x%08x\n", f->frequency);
 
         if (!av7110->analog_tuner_flags || av7110->current_input != 1)
                 return -EINVAL;
@@ -429,7 +431,7 @@ static int vidioc_s_frequency(struct file *file, void *fh, struct v4l2_frequency
         struct saa7146_dev *dev = ((struct saa7146_fh *)fh)->dev;
         struct av7110 *av7110 = (struct av7110 *)dev->ext_priv;
 
-        dprintk(2, "VIDIOC_S_FREQUENCY: freq:0x%08x.\n", f->frequency);
+        dprintk(2, "VIDIOC_S_FREQUENCY: freq:0x%08x\n", f->frequency);
 
         if (!av7110->analog_tuner_flags || av7110->current_input != 1)
                 return -EINVAL;
@@ -689,12 +691,12 @@ int av7110_init_analog_module(struct av7110 *av7110)
 
         if (i2c_writereg(av7110, 0x80, 0x0, 0x80) == 1 &&
             i2c_writereg(av7110, 0x80, 0x0, 0) == 1) {
-                printk("dvb-ttpci: DVB-C analog module @ card %d detected, initializing MSP3400\n",
+                pr_info("DVB-C analog module @ card %d detected, initializing MSP3400\n",
                         av7110->dvb_adapter.num);
                 av7110->adac_type = DVB_ADAC_MSP34x0;
         } else if (i2c_writereg(av7110, 0x84, 0x0, 0x80) == 1 &&
                    i2c_writereg(av7110, 0x84, 0x0, 0) == 1) {
-                printk("dvb-ttpci: DVB-C analog module @ card %d detected, initializing MSP3415\n",
+                pr_info("DVB-C analog module @ card %d detected, initializing MSP3415\n",
                         av7110->dvb_adapter.num);
                 av7110->adac_type = DVB_ADAC_MSP34x5;
         } else
@@ -715,7 +717,7 @@ int av7110_init_analog_module(struct av7110 *av7110)
         msp_writereg(av7110, MSP_WR_DSP, 0x000d, 0x1900); // prescale SCART
 
         if (i2c_writereg(av7110, 0x48, 0x01, 0x00)!=1) {
-                INFO(("saa7113 not accessible.\n"));
+                pr_info("saa7113 not accessible\n");
         } else {
                 u8 *i = saa7113_init_regs;
 
@@ -733,7 +735,7 @@ int av7110_init_analog_module(struct av7110 *av7110)
                 /* setup for DVB by default */
                 if (av7110->analog_tuner_flags & ANALOG_TUNER_VES1820) {
                         if (ves1820_writereg(av7110->dev, 0x09, 0x0f, 0x20))
-                                dprintk(1, "setting band in demodulator failed.\n");
+                                dprintk(1, "setting band in demodulator failed\n");
                 } else if (av7110->analog_tuner_flags & ANALOG_TUNER_STV0297) {
                         saa7146_setgpio(av7110->dev, 1, SAA7146_GPIO_OUTLO); // TDA9819 pin9(STD)
                         saa7146_setgpio(av7110->dev, 3, SAA7146_GPIO_OUTLO); // TDA9819 pin30(VIF)
@@ -797,7 +799,7 @@ int av7110_init_v4l(struct av7110 *av7110)
         ret = saa7146_vv_init(dev, vv_data);
 
         if (ret) {
-                ERR(("cannot init capture device. skipping.\n"));
+                ERR("cannot init capture device. skipping\n");
                 return -ENODEV;
         }
         vv_data->ops.vidioc_enum_input = vidioc_enum_input;
@@ -814,12 +816,12 @@ int av7110_init_v4l(struct av7110 *av7110)
         vv_data->ops.vidioc_s_fmt_sliced_vbi_out = vidioc_s_fmt_sliced_vbi_out;
 
         if (saa7146_register_device(&av7110->v4l_dev, dev, "av7110", VFL_TYPE_GRABBER)) {
-                ERR(("cannot register capture device. skipping.\n"));
+                ERR("cannot register capture device. skipping\n");
                 saa7146_vv_release(dev);
                 return -ENODEV;
         }
         if (saa7146_register_device(&av7110->vbi_dev, dev, "av7110", VFL_TYPE_VBI))
-                ERR(("cannot register vbi v4l2 device. skipping.\n"));
+                ERR("cannot register vbi v4l2 device. skipping\n");
         return 0;
 }
 
diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c
index 5b28bc6fbeb..91b7d53d7b0 100644
--- a/drivers/media/dvb/ttpci/budget-av.c
+++ b/drivers/media/dvb/ttpci/budget-av.c
@@ -33,6 +33,8 @@
  * the project's page is at http://www.linuxtv.org/ 
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include "budget.h"
 #include "stv0299.h"
 #include "stb0899_drv.h"
@@ -149,7 +151,7 @@ static int ciintf_read_attribute_mem(struct dvb_ca_en50221 *ca, int slot, int ad
         result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 0xfff, 1, 0, 1);
         if (result == -ETIMEDOUT) {
                 ciintf_slot_shutdown(ca, slot);
-                printk(KERN_INFO "budget-av: cam ejected 1\n");
+                pr_info("cam ejected 1\n");
         }
         return result;
 }
@@ -168,7 +170,7 @@ static int ciintf_write_attribute_mem(struct dvb_ca_en50221 *ca, int slot, int a
         result = ttpci_budget_debiwrite(&budget_av->budget, DEBICICAM, address & 0xfff, 1, value, 0, 1);
         if (result == -ETIMEDOUT) {
                 ciintf_slot_shutdown(ca, slot);
-                printk(KERN_INFO "budget-av: cam ejected 2\n");
+                pr_info("cam ejected 2\n");
         }
         return result;
 }
@@ -187,7 +189,7 @@ static int ciintf_read_cam_control(struct dvb_ca_en50221 *ca, int slot, u8 addre
         result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 3, 1, 0, 0);
         if (result == -ETIMEDOUT) {
                 ciintf_slot_shutdown(ca, slot);
-                printk(KERN_INFO "budget-av: cam ejected 3\n");
+                pr_info("cam ejected 3\n");
                 return -ETIMEDOUT;
         }
         return result;
@@ -207,7 +209,7 @@ static int ciintf_write_cam_control(struct dvb_ca_en50221 *ca, int slot, u8 addr
         result = ttpci_budget_debiwrite(&budget_av->budget, DEBICICAM, address & 3, 1, value, 0, 0);
         if (result == -ETIMEDOUT) {
                 ciintf_slot_shutdown(ca, slot);
-                printk(KERN_INFO "budget-av: cam ejected 5\n");
+                pr_info("cam ejected 5\n");
         }
         return result;
 }
@@ -289,7 +291,7 @@ static int ciintf_poll_slot_status(struct dvb_ca_en50221 *ca, int slot, int open
                 if (saa7146_read(saa, PSR) & MASK_06) {
                         if (budget_av->slot_status == SLOTSTATUS_NONE) {
                                 budget_av->slot_status = SLOTSTATUS_PRESENT;
-                                printk(KERN_INFO "budget-av: cam inserted A\n");
+                                pr_info("cam inserted A\n");
                         }
                 }
                 saa7146_setgpio(saa, 3, SAA7146_GPIO_OUTLO);
@@ -306,11 +308,11 @@ static int ciintf_poll_slot_status(struct dvb_ca_en50221 *ca, int slot, int open
                 result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, 0, 1, 0, 1);
                 if ((result >= 0) && (budget_av->slot_status == SLOTSTATUS_NONE)) {
                         budget_av->slot_status = SLOTSTATUS_PRESENT;
-                        printk(KERN_INFO "budget-av: cam inserted B\n");
+                        pr_info("cam inserted B\n");
                 } else if (result < 0) {
                         if (budget_av->slot_status != SLOTSTATUS_NONE) {
                                 ciintf_slot_shutdown(ca, slot);
-                                printk(KERN_INFO "budget-av: cam ejected 5\n");
+                                pr_info("cam ejected 5\n");
                                 return 0;
                         }
                 }
@@ -365,11 +367,11 @@ static int ciintf_init(struct budget_av *budget_av)
 
         if ((result = dvb_ca_en50221_init(&budget_av->budget.dvb_adapter,
                                           &budget_av->ca, 0, 1)) != 0) {
-                printk(KERN_ERR "budget-av: ci initialisation failed.\n");
+                pr_err("ci initialisation failed\n");
                 goto error;
         }
 
-        printk(KERN_INFO "budget-av: ci interface initialised.\n");
+        pr_info("ci interface initialised\n");
         return 0;
 
 error:
@@ -1345,8 +1347,7 @@ static void frontend_init(struct budget_av *budget_av)
         }
 
         if (fe == NULL) {
-                printk(KERN_ERR "budget-av: A frontend driver was not found "
-                                "for device [%04x:%04x] subsystem [%04x:%04x]\n",
+                pr_err("A frontend driver was not found for device [%04x:%04x] subsystem [%04x:%04x]\n",
                        saa->pci->vendor,
                        saa->pci->device,
                        saa->pci->subsystem_vendor,
@@ -1358,7 +1359,7 @@ static void frontend_init(struct budget_av *budget_av)
 
         if (dvb_register_frontend(&budget_av->budget.dvb_adapter,
                                   budget_av->budget.dvb_frontend)) {
-                printk(KERN_ERR "budget-av: Frontend registration failed!\n");
+                pr_err("Frontend registration failed!\n");
                 dvb_frontend_detach(budget_av->budget.dvb_frontend);
                 budget_av->budget.dvb_frontend = NULL;
         }
@@ -1416,7 +1417,7 @@ static struct v4l2_input knc1_inputs[KNC1_INPUTS] = {
 
 static int vidioc_enum_input(struct file *file, void *fh, struct v4l2_input *i)
 {
-        dprintk(1, "VIDIOC_ENUMINPUT %d.\n", i->index);
+        dprintk(1, "VIDIOC_ENUMINPUT %d\n", i->index);
         if (i->index >= KNC1_INPUTS)
                 return -EINVAL;
         memcpy(i, &knc1_inputs[i->index], sizeof(struct v4l2_input));
@@ -1430,7 +1431,7 @@ static int vidioc_g_input(struct file *file, void *fh, unsigned int *i)
 
         *i = budget_av->cur_input;
 
-        dprintk(1, "VIDIOC_G_INPUT %d.\n", *i);
+        dprintk(1, "VIDIOC_G_INPUT %d\n", *i);
         return 0;
 }
 
@@ -1439,7 +1440,7 @@ static int vidioc_s_input(struct file *file, void *fh, unsigned int input)
         struct saa7146_dev *dev = ((struct saa7146_fh *)fh)->dev;
         struct budget_av *budget_av = (struct budget_av *)dev->ext_priv;
 
-        dprintk(1, "VIDIOC_S_INPUT %d.\n", input);
+        dprintk(1, "VIDIOC_S_INPUT %d\n", input);
         return saa7113_setinput(budget_av, input);
 }
 
@@ -1478,7 +1479,7 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio
 
                 if (0 != saa7146_vv_init(dev, &vv_data)) {
                         /* fixme: proper cleanup here */
-                        ERR(("cannot init vv subsystem.\n"));
+                        ERR("cannot init vv subsystem\n");
                         return err;
                 }
                 vv_data.ops.vidioc_enum_input = vidioc_enum_input;
@@ -1487,7 +1488,7 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio
 
                 if ((err = saa7146_register_device(&budget_av->vd, dev, "knc1", VFL_TYPE_GRABBER))) {
                         /* fixme: proper cleanup here */
-                        ERR(("cannot register capture v4l2 device.\n"));
+                        ERR("cannot register capture v4l2 device\n");
                         saa7146_vv_release(dev);
                         return err;
                 }
@@ -1504,13 +1505,12 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio
 
         mac = budget_av->budget.dvb_adapter.proposed_mac;
         if (i2c_readregs(&budget_av->budget.i2c_adap, 0xa0, 0x30, mac, 6)) {
-                printk(KERN_ERR "KNC1-%d: Could not read MAC from KNC1 card\n",
+                pr_err("KNC1-%d: Could not read MAC from KNC1 card\n",
                        budget_av->budget.dvb_adapter.num);
                 memset(mac, 0, 6);
         } else {
-                printk(KERN_INFO "KNC1-%d: MAC addr = %.2x:%.2x:%.2x:%.2x:%.2x:%.2x\n",
-                       budget_av->budget.dvb_adapter.num,
-                       mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]);
+                pr_info("KNC1-%d: MAC addr = %pM\n",
+                        budget_av->budget.dvb_adapter.num, mac);
         }
 
         budget_av->budget.dvb_adapter.priv = budget_av;