Merge branch 'next' into for-linus

6 files changed, 36 insertions, 22 deletions

diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index e4728a28f49..ecaeb7e8e75 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -736,8 +736,8 @@ static int __devinit ad7877_probe(struct spi_device *spi)
 
         /* Request AD7877 /DAV GPIO interrupt */
 
-        err = request_irq(spi->irq, ad7877_irq, IRQF_TRIGGER_FALLING |
-                        IRQF_SAMPLE_RANDOM, spi->dev.driver->name, ts);
+        err = request_irq(spi->irq, ad7877_irq, IRQF_TRIGGER_FALLING,
+                        spi->dev.driver->name, ts);
         if (err) {
                 dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
                 goto err_free_mem;
diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
index ea4c61d6868..5d8a7039880 100644
--- a/drivers/input/touchscreen/ad7879.c
+++ b/drivers/input/touchscreen/ad7879.c
@@ -448,8 +448,7 @@ static int __devinit ad7879_construct(bus_device *bus, struct ad7879 *ts)
         ad7879_setup(ts);
 
         err = request_irq(bus->irq, ad7879_irq,
-                          IRQF_TRIGGER_FALLING | IRQF_SAMPLE_RANDOM,
-                          bus->dev.driver->name, ts);
+                          IRQF_TRIGGER_FALLING, bus->dev.driver->name, ts);
 
         if (err) {
                 dev_err(&bus->dev, "irq %d busy?\n", bus->irq);
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 056ac77e2cf..2b01e56568f 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -127,6 +127,8 @@ struct ads7846 {
         void                    (*filter_cleanup)(void *data);
         int                     (*get_pendown_state)(void);
         int                     gpio_pendown;
+
+        void                    (*wait_for_sync)(void);
 };
 
 /* leave chip selected when we're done, for quicker re-select? */
@@ -511,6 +513,10 @@ static int get_pendown_state(struct ads7846 *ts)
         return !gpio_get_value(ts->gpio_pendown);
 }
 
+static void null_wait_for_sync(void)
+{
+}
+
 /*
  * PENIRQ only kicks the timer.  The timer only reissues the SPI transfer,
  * to retrieve touchscreen status.
@@ -686,6 +692,7 @@ static void ads7846_rx_val(void *ads)
         default:
                 BUG();
         }
+        ts->wait_for_sync();
         status = spi_async(ts->spi, m);
         if (status)
                 dev_err(&ts->spi->dev, "spi_async --> %d\n",
@@ -723,6 +730,7 @@ static enum hrtimer_restart ads7846_timer(struct hrtimer *handle)
         } else {
                 /* pen is still down, continue with the measurement */
                 ts->msg_idx = 0;
+                ts->wait_for_sync();
                 status = spi_async(ts->spi, &ts->msg[0]);
                 if (status)
                         dev_err(&ts->spi->dev, "spi_async --> %d\n", status);
@@ -746,7 +754,7 @@ static irqreturn_t ads7846_irq(int irq, void *handle)
                          * that here.  (The "generic irq" framework may help...)
                          */
                         ts->irq_disabled = 1;
-                        disable_irq(ts->spi->irq);
+                        disable_irq_nosync(ts->spi->irq);
                         ts->pending = 1;
                         hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_DELAY),
                                         HRTIMER_MODE_REL);
@@ -947,6 +955,8 @@ static int __devinit ads7846_probe(struct spi_device *spi)
                 ts->penirq_recheck_delay_usecs =
                                 pdata->penirq_recheck_delay_usecs;
 
+        ts->wait_for_sync = pdata->wait_for_sync ? : null_wait_for_sync;
+
         snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&spi->dev));
 
         input_dev->name = "ADS784x Touchscreen";
diff --git a/drivers/input/touchscreen/da9034-ts.c b/drivers/input/touchscreen/da9034-ts.c
index fa67d782c3c..3ffd4c4b170 100644
--- a/drivers/input/touchscreen/da9034-ts.c
+++ b/drivers/input/touchscreen/da9034-ts.c
@@ -3,6 +3,7 @@
  *
  * Copyright (C) 2006-2008 Marvell International Ltd.
  *      Fengwei Yin <fengwei.yin@marvell.com>
+ *      Bin Yang  <bin.yang@marvell.com>
  *      Eric Miao <eric.miao@marvell.com>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -175,6 +176,16 @@ static void da9034_event_handler(struct da9034_touch *touch, int event)
                         goto err_reset;
 
                 touch->state = STATE_STOP;
+
+                /* FIXME: PEN_{UP/DOWN} events are expected to be
+                 * available by stopping TSI, but this is found not
+                 * always true, delay and simulate such an event
+                 * here is more reliable
+                 */
+                mdelay(1);
+                da9034_event_handler(touch,
+                                     is_pen_down(touch) ? EVENT_PEN_DOWN :
+                                                          EVENT_PEN_UP);
                 break;
 
         case STATE_STOP:
@@ -189,8 +200,6 @@ static void da9034_event_handler(struct da9034_touch *touch, int event)
                         report_pen_up(touch);
                         touch->state = STATE_IDLE;
                 }
-
-                input_sync(touch->input_dev);
                 break;
 
         case STATE_WAIT:
@@ -200,8 +209,10 @@ static void da9034_event_handler(struct da9034_touch *touch, int event)
                 if (is_pen_down(touch)) {
                         start_tsi(touch);
                         touch->state = STATE_BUSY;
-                } else
+                } else {
+                        report_pen_up(touch);
                         touch->state = STATE_IDLE;
+                }
                 break;
         }
         return;
@@ -226,16 +237,12 @@ static int da9034_touch_notifier(struct notifier_block *nb,
         struct da9034_touch *touch =
                 container_of(nb, struct da9034_touch, notifier);
 
-        if (event & DA9034_EVENT_PEN_DOWN) {
-                if (is_pen_down(touch))
-                        da9034_event_handler(touch, EVENT_PEN_DOWN);
-                else
-                        da9034_event_handler(touch, EVENT_PEN_UP);
-        }
-
         if (event & DA9034_EVENT_TSI_READY)
                 da9034_event_handler(touch, EVENT_TSI_READY);
 
+        if ((event & DA9034_EVENT_PEN_DOWN) && touch->state == STATE_IDLE)
+                da9034_event_handler(touch, EVENT_PEN_DOWN);
+
         return 0;
 }
 
@@ -385,6 +392,6 @@ static void __exit da9034_touch_exit(void)
 module_exit(da9034_touch_exit);
 
 MODULE_DESCRIPTION("Touchscreen driver for Dialog Semiconductor DA9034");
-MODULE_AUTHOR("Eric Miao <eric.miao@marvell.com>");
+MODULE_AUTHOR("Eric Miao <eric.miao@marvell.com>, Bin Yang <bin.yang@marvell.com>");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:da9034-touch");
diff --git a/drivers/input/touchscreen/mainstone-wm97xx.c b/drivers/input/touchscreen/mainstone-wm97xx.c
index dfa6a84ab50..4cc047a5116 100644
--- a/drivers/input/touchscreen/mainstone-wm97xx.c
+++ b/drivers/input/touchscreen/mainstone-wm97xx.c
@@ -111,13 +111,12 @@ static void wm97xx_acc_pen_up(struct wm97xx *wm)
 #else
 static void wm97xx_acc_pen_up(struct wm97xx *wm)
 {
-        int count = 16;
+        unsigned int count;
+
         schedule_timeout_uninterruptible(1);
 
-        while (count < 16) {
+        for (count = 0; count < 16; count++)
                 MODR;
-                count--;
-        }
 }
 #endif
 
diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
index cec480bffe3..69af8385ab1 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -370,8 +370,7 @@ static int wm97xx_init_pen_irq(struct wm97xx *wm)
          * provided. */
         BUG_ON(!wm->mach_ops->irq_enable);
 
-        if (request_irq(wm->pen_irq, wm97xx_pen_interrupt,
-                        IRQF_SHARED | IRQF_SAMPLE_RANDOM,
+        if (request_irq(wm->pen_irq, wm97xx_pen_interrupt, IRQF_SHARED,
                         "wm97xx-pen", wm)) {
                 dev_err(wm->dev,
                         "Failed to register pen down interrupt, polling");