diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:31 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:31 -0400 |
commit | 9c113dc67ab712e1bb82e974e51c49a678562713 (patch) | |
tree | 6293070103e59252d0d677b770dd72c768d99ab0 /drivers/input/mouse | |
parent | 08813d35d2ac6f304a53eb3a9ee59283fa7cc67f (diff) |
USB: appletouch.c: remove err() usage
err() was a very old USB-specific macro that I thought had
gone away. This patch removes it from being used in the
driver and uses dev_err() instead.
CC: Alessandro Rubini <rubini@ipvvis.unipv.it>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/input/mouse')
-rw-r--r-- | drivers/input/mouse/appletouch.c | 25 |
1 files changed, 14 insertions, 11 deletions
diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c index 0acbc7d50d0..90db679b44a 100644 --- a/drivers/input/mouse/appletouch.c +++ b/drivers/input/mouse/appletouch.c | |||
@@ -262,7 +262,7 @@ static int atp_geyser_init(struct usb_device *udev) | |||
262 | 262 | ||
263 | data = kmalloc(8, GFP_KERNEL); | 263 | data = kmalloc(8, GFP_KERNEL); |
264 | if (!data) { | 264 | if (!data) { |
265 | err("Out of memory"); | 265 | dev_err(&udev->dev, "Out of memory\n"); |
266 | return -ENOMEM; | 266 | return -ENOMEM; |
267 | } | 267 | } |
268 | 268 | ||
@@ -277,7 +277,7 @@ static int atp_geyser_init(struct usb_device *udev) | |||
277 | for (i = 0; i < 8; i++) | 277 | for (i = 0; i < 8; i++) |
278 | dprintk("appletouch[%d]: %d\n", i, data[i]); | 278 | dprintk("appletouch[%d]: %d\n", i, data[i]); |
279 | 279 | ||
280 | err("Failed to read mode from device."); | 280 | dev_err(&udev->dev, "Failed to read mode from device.\n"); |
281 | ret = -EIO; | 281 | ret = -EIO; |
282 | goto out_free; | 282 | goto out_free; |
283 | } | 283 | } |
@@ -296,7 +296,7 @@ static int atp_geyser_init(struct usb_device *udev) | |||
296 | for (i = 0; i < 8; i++) | 296 | for (i = 0; i < 8; i++) |
297 | dprintk("appletouch[%d]: %d\n", i, data[i]); | 297 | dprintk("appletouch[%d]: %d\n", i, data[i]); |
298 | 298 | ||
299 | err("Failed to request geyser raw mode"); | 299 | dev_err(&udev->dev, "Failed to request geyser raw mode\n"); |
300 | ret = -EIO; | 300 | ret = -EIO; |
301 | goto out_free; | 301 | goto out_free; |
302 | } | 302 | } |
@@ -321,8 +321,9 @@ static void atp_reinit(struct work_struct *work) | |||
321 | 321 | ||
322 | retval = usb_submit_urb(dev->urb, GFP_ATOMIC); | 322 | retval = usb_submit_urb(dev->urb, GFP_ATOMIC); |
323 | if (retval) | 323 | if (retval) |
324 | err("atp_reinit: usb_submit_urb failed with error %d", | 324 | dev_err(&udev->dev, |
325 | retval); | 325 | "atp_reinit: usb_submit_urb failed with error %d\n", |
326 | retval); | ||
326 | } | 327 | } |
327 | 328 | ||
328 | static int atp_calculate_abs(int *xy_sensors, int nb_sensors, int fact, | 329 | static int atp_calculate_abs(int *xy_sensors, int nb_sensors, int fact, |
@@ -588,8 +589,9 @@ static void atp_complete_geyser_1_2(struct urb *urb) | |||
588 | exit: | 589 | exit: |
589 | retval = usb_submit_urb(dev->urb, GFP_ATOMIC); | 590 | retval = usb_submit_urb(dev->urb, GFP_ATOMIC); |
590 | if (retval) | 591 | if (retval) |
591 | err("atp_complete: usb_submit_urb failed with result %d", | 592 | dev_err(&dev->udev->dev, |
592 | retval); | 593 | "atp_complete: usb_submit_urb failed with result %d\n", |
594 | retval); | ||
593 | } | 595 | } |
594 | 596 | ||
595 | /* Interrupt function for older touchpads: GEYSER3/GEYSER4 */ | 597 | /* Interrupt function for older touchpads: GEYSER3/GEYSER4 */ |
@@ -722,8 +724,9 @@ static void atp_complete_geyser_3_4(struct urb *urb) | |||
722 | exit: | 724 | exit: |
723 | retval = usb_submit_urb(dev->urb, GFP_ATOMIC); | 725 | retval = usb_submit_urb(dev->urb, GFP_ATOMIC); |
724 | if (retval) | 726 | if (retval) |
725 | err("atp_complete: usb_submit_urb failed with result %d", | 727 | dev_err(&dev->udev->dev, |
726 | retval); | 728 | "atp_complete: usb_submit_urb failed with result %d\n", |
729 | retval); | ||
727 | } | 730 | } |
728 | 731 | ||
729 | static int atp_open(struct input_dev *input) | 732 | static int atp_open(struct input_dev *input) |
@@ -785,7 +788,7 @@ static int atp_probe(struct usb_interface *iface, | |||
785 | } | 788 | } |
786 | } | 789 | } |
787 | if (!int_in_endpointAddr) { | 790 | if (!int_in_endpointAddr) { |
788 | err("Could not find int-in endpoint"); | 791 | dev_err(&iface->dev, "Could not find int-in endpoint\n"); |
789 | return -EIO; | 792 | return -EIO; |
790 | } | 793 | } |
791 | 794 | ||
@@ -793,7 +796,7 @@ static int atp_probe(struct usb_interface *iface, | |||
793 | dev = kzalloc(sizeof(struct atp), GFP_KERNEL); | 796 | dev = kzalloc(sizeof(struct atp), GFP_KERNEL); |
794 | input_dev = input_allocate_device(); | 797 | input_dev = input_allocate_device(); |
795 | if (!dev || !input_dev) { | 798 | if (!dev || !input_dev) { |
796 | err("Out of memory"); | 799 | dev_err(&iface->dev, "Out of memory\n"); |
797 | goto err_free_devs; | 800 | goto err_free_devs; |
798 | } | 801 | } |
799 | 802 | ||