diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-22 18:50:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-22 18:50:46 -0400 |
commit | a481991467d38afb43c3921d5b5b59ccb61b04ba (patch) | |
tree | a4b0b9a14da6fd5ef7b9b512bb32dbfcfcf2cd71 /drivers/input/misc | |
parent | f6a26ae7699416d86bea8cb68ce413571e9cab3c (diff) | |
parent | cda4db53e9c28061c100400e1a4d273ea61dfba9 (diff) |
Merge tag 'usb-3.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
Pull USB 3.5-rc1 changes from Greg Kroah-Hartman:
"Here is the big USB 3.5-rc1 pull request for the 3.5-rc1 merge window.
It's touches a lot of different parts of the kernel, all USB drivers,
due to some API cleanups (getting rid of the ancient err() macro) and
some changes that are needed for USB 3.0 power management updates.
There are also lots of new drivers, pimarily gadget, but others as
well. We deleted a staging driver, which was nice, and finally
dropped the obsolete usbfs code, which will make Al happy to never
have to touch that again.
There were some build errors in the tree that linux-next found a few
days ago, but those were fixed by the most recent changes (all were
due to us not building with CONFIG_PM disabled.)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>"
* tag 'usb-3.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (477 commits)
xhci: Fix DIV_ROUND_UP compile error.
xhci: Fix compile with CONFIG_USB_SUSPEND=n
USB: Fix core compile with CONFIG_USB_SUSPEND=n
brcm80211: Fix compile error for .disable_hub_initiated_lpm.
Revert "USB: EHCI: work around bug in the Philips ISP1562 controller"
MAINTAINERS: Add myself as maintainer to the USB PHY Layer
USB: EHCI: fix command register configuration lost problem
USB: Remove races in devio.c
USB: ehci-platform: remove update_device
USB: Disable hub-initiated LPM for comms devices.
xhci: Add Intel U1/U2 timeout policy.
xhci: Add infrastructure for host-specific LPM policies.
USB: Add macros for interrupt endpoint types.
xhci: Reserve one command for USB3 LPM disable.
xhci: Some Evaluate Context commands must succeed.
USB: Disable USB 3.0 LPM in critical sections.
USB: Add support to enable/disable USB3 link states.
USB: Allow drivers to disable hub-initiated LPM.
USB: Calculate USB 3.0 exit latencies for LPM.
USB: Refactor code to set LPM support flag.
...
Conflicts:
arch/arm/mach-exynos/mach-nuri.c
arch/arm/mach-exynos/mach-universal_c210.c
drivers/net/wireless/ath/ath6kl/usb.c
Diffstat (limited to 'drivers/input/misc')
-rw-r--r-- | drivers/input/misc/cm109.c | 33 | ||||
-rw-r--r-- | drivers/input/misc/keyspan_remote.c | 23 | ||||
-rw-r--r-- | drivers/input/misc/powermate.c | 13 | ||||
-rw-r--r-- | drivers/input/misc/yealink.c | 31 |
4 files changed, 66 insertions, 34 deletions
diff --git a/drivers/input/misc/cm109.c b/drivers/input/misc/cm109.c index ab860511f01..082684e7f39 100644 --- a/drivers/input/misc/cm109.c +++ b/drivers/input/misc/cm109.c | |||
@@ -327,7 +327,9 @@ static void cm109_submit_buzz_toggle(struct cm109_dev *dev) | |||
327 | 327 | ||
328 | error = usb_submit_urb(dev->urb_ctl, GFP_ATOMIC); | 328 | error = usb_submit_urb(dev->urb_ctl, GFP_ATOMIC); |
329 | if (error) | 329 | if (error) |
330 | err("%s: usb_submit_urb (urb_ctl) failed %d", __func__, error); | 330 | dev_err(&dev->intf->dev, |
331 | "%s: usb_submit_urb (urb_ctl) failed %d\n", | ||
332 | __func__, error); | ||
331 | } | 333 | } |
332 | 334 | ||
333 | /* | 335 | /* |
@@ -339,7 +341,7 @@ static void cm109_urb_irq_callback(struct urb *urb) | |||
339 | const int status = urb->status; | 341 | const int status = urb->status; |
340 | int error; | 342 | int error; |
341 | 343 | ||
342 | dev_dbg(&urb->dev->dev, "### URB IRQ: [0x%02x 0x%02x 0x%02x 0x%02x] keybit=0x%02x\n", | 344 | dev_dbg(&dev->intf->dev, "### URB IRQ: [0x%02x 0x%02x 0x%02x 0x%02x] keybit=0x%02x\n", |
343 | dev->irq_data->byte[0], | 345 | dev->irq_data->byte[0], |
344 | dev->irq_data->byte[1], | 346 | dev->irq_data->byte[1], |
345 | dev->irq_data->byte[2], | 347 | dev->irq_data->byte[2], |
@@ -349,7 +351,7 @@ static void cm109_urb_irq_callback(struct urb *urb) | |||
349 | if (status) { | 351 | if (status) { |
350 | if (status == -ESHUTDOWN) | 352 | if (status == -ESHUTDOWN) |
351 | return; | 353 | return; |
352 | err("%s: urb status %d", __func__, status); | 354 | dev_err(&dev->intf->dev, "%s: urb status %d\n", __func__, status); |
353 | } | 355 | } |
354 | 356 | ||
355 | /* Special keys */ | 357 | /* Special keys */ |
@@ -396,7 +398,8 @@ static void cm109_urb_irq_callback(struct urb *urb) | |||
396 | 398 | ||
397 | error = usb_submit_urb(dev->urb_ctl, GFP_ATOMIC); | 399 | error = usb_submit_urb(dev->urb_ctl, GFP_ATOMIC); |
398 | if (error) | 400 | if (error) |
399 | err("%s: usb_submit_urb (urb_ctl) failed %d", | 401 | dev_err(&dev->intf->dev, |
402 | "%s: usb_submit_urb (urb_ctl) failed %d\n", | ||
400 | __func__, error); | 403 | __func__, error); |
401 | } | 404 | } |
402 | 405 | ||
@@ -409,14 +412,14 @@ static void cm109_urb_ctl_callback(struct urb *urb) | |||
409 | const int status = urb->status; | 412 | const int status = urb->status; |
410 | int error; | 413 | int error; |
411 | 414 | ||
412 | dev_dbg(&urb->dev->dev, "### URB CTL: [0x%02x 0x%02x 0x%02x 0x%02x]\n", | 415 | dev_dbg(&dev->intf->dev, "### URB CTL: [0x%02x 0x%02x 0x%02x 0x%02x]\n", |
413 | dev->ctl_data->byte[0], | 416 | dev->ctl_data->byte[0], |
414 | dev->ctl_data->byte[1], | 417 | dev->ctl_data->byte[1], |
415 | dev->ctl_data->byte[2], | 418 | dev->ctl_data->byte[2], |
416 | dev->ctl_data->byte[3]); | 419 | dev->ctl_data->byte[3]); |
417 | 420 | ||
418 | if (status) | 421 | if (status) |
419 | err("%s: urb status %d", __func__, status); | 422 | dev_err(&dev->intf->dev, "%s: urb status %d\n", __func__, status); |
420 | 423 | ||
421 | spin_lock(&dev->ctl_submit_lock); | 424 | spin_lock(&dev->ctl_submit_lock); |
422 | 425 | ||
@@ -433,7 +436,8 @@ static void cm109_urb_ctl_callback(struct urb *urb) | |||
433 | dev->irq_urb_pending = 1; | 436 | dev->irq_urb_pending = 1; |
434 | error = usb_submit_urb(dev->urb_irq, GFP_ATOMIC); | 437 | error = usb_submit_urb(dev->urb_irq, GFP_ATOMIC); |
435 | if (error) | 438 | if (error) |
436 | err("%s: usb_submit_urb (urb_irq) failed %d", | 439 | dev_err(&dev->intf->dev, |
440 | "%s: usb_submit_urb (urb_irq) failed %d\n", | ||
437 | __func__, error); | 441 | __func__, error); |
438 | } | 442 | } |
439 | } | 443 | } |
@@ -476,7 +480,8 @@ static void cm109_toggle_buzzer_sync(struct cm109_dev *dev, int on) | |||
476 | dev->ctl_data, | 480 | dev->ctl_data, |
477 | USB_PKT_LEN, USB_CTRL_SET_TIMEOUT); | 481 | USB_PKT_LEN, USB_CTRL_SET_TIMEOUT); |
478 | if (error < 0 && error != -EINTR) | 482 | if (error < 0 && error != -EINTR) |
479 | err("%s: usb_control_msg() failed %d", __func__, error); | 483 | dev_err(&dev->intf->dev, "%s: usb_control_msg() failed %d\n", |
484 | __func__, error); | ||
480 | } | 485 | } |
481 | 486 | ||
482 | static void cm109_stop_traffic(struct cm109_dev *dev) | 487 | static void cm109_stop_traffic(struct cm109_dev *dev) |
@@ -518,8 +523,8 @@ static int cm109_input_open(struct input_dev *idev) | |||
518 | 523 | ||
519 | error = usb_autopm_get_interface(dev->intf); | 524 | error = usb_autopm_get_interface(dev->intf); |
520 | if (error < 0) { | 525 | if (error < 0) { |
521 | err("%s - cannot autoresume, result %d", | 526 | dev_err(&idev->dev, "%s - cannot autoresume, result %d\n", |
522 | __func__, error); | 527 | __func__, error); |
523 | return error; | 528 | return error; |
524 | } | 529 | } |
525 | 530 | ||
@@ -537,7 +542,8 @@ static int cm109_input_open(struct input_dev *idev) | |||
537 | 542 | ||
538 | error = usb_submit_urb(dev->urb_ctl, GFP_KERNEL); | 543 | error = usb_submit_urb(dev->urb_ctl, GFP_KERNEL); |
539 | if (error) | 544 | if (error) |
540 | err("%s: usb_submit_urb (urb_ctl) failed %d", __func__, error); | 545 | dev_err(&dev->intf->dev, "%s: usb_submit_urb (urb_ctl) failed %d\n", |
546 | __func__, error); | ||
541 | else | 547 | else |
542 | dev->open = 1; | 548 | dev->open = 1; |
543 | 549 | ||
@@ -573,7 +579,7 @@ static int cm109_input_ev(struct input_dev *idev, unsigned int type, | |||
573 | { | 579 | { |
574 | struct cm109_dev *dev = input_get_drvdata(idev); | 580 | struct cm109_dev *dev = input_get_drvdata(idev); |
575 | 581 | ||
576 | dev_dbg(&dev->udev->dev, | 582 | dev_dbg(&dev->intf->dev, |
577 | "input_ev: type=%u code=%u value=%d\n", type, code, value); | 583 | "input_ev: type=%u code=%u value=%d\n", type, code, value); |
578 | 584 | ||
579 | if (type != EV_SND) | 585 | if (type != EV_SND) |
@@ -710,7 +716,8 @@ static int cm109_usb_probe(struct usb_interface *intf, | |||
710 | pipe = usb_rcvintpipe(udev, endpoint->bEndpointAddress); | 716 | pipe = usb_rcvintpipe(udev, endpoint->bEndpointAddress); |
711 | ret = usb_maxpacket(udev, pipe, usb_pipeout(pipe)); | 717 | ret = usb_maxpacket(udev, pipe, usb_pipeout(pipe)); |
712 | if (ret != USB_PKT_LEN) | 718 | if (ret != USB_PKT_LEN) |
713 | err("invalid payload size %d, expected %d", ret, USB_PKT_LEN); | 719 | dev_err(&intf->dev, "invalid payload size %d, expected %d\n", |
720 | ret, USB_PKT_LEN); | ||
714 | 721 | ||
715 | /* initialise irq urb */ | 722 | /* initialise irq urb */ |
716 | usb_fill_int_urb(dev->urb_irq, udev, pipe, dev->irq_data, | 723 | usb_fill_int_urb(dev->urb_irq, udev, pipe, dev->irq_data, |
diff --git a/drivers/input/misc/keyspan_remote.c b/drivers/input/misc/keyspan_remote.c index d99151a8bf1..290fa5f97de 100644 --- a/drivers/input/misc/keyspan_remote.c +++ b/drivers/input/misc/keyspan_remote.c | |||
@@ -157,7 +157,7 @@ static int keyspan_load_tester(struct usb_keyspan* dev, int bits_needed) | |||
157 | * though so it's not too big a deal | 157 | * though so it's not too big a deal |
158 | */ | 158 | */ |
159 | if (dev->data.pos >= dev->data.len) { | 159 | if (dev->data.pos >= dev->data.len) { |
160 | dev_dbg(&dev->udev->dev, | 160 | dev_dbg(&dev->interface->dev, |
161 | "%s - Error ran out of data. pos: %d, len: %d\n", | 161 | "%s - Error ran out of data. pos: %d, len: %d\n", |
162 | __func__, dev->data.pos, dev->data.len); | 162 | __func__, dev->data.pos, dev->data.len); |
163 | return -1; | 163 | return -1; |
@@ -267,7 +267,9 @@ static void keyspan_check_data(struct usb_keyspan *remote) | |||
267 | remote->data.tester = remote->data.tester >> 6; | 267 | remote->data.tester = remote->data.tester >> 6; |
268 | remote->data.bits_left -= 6; | 268 | remote->data.bits_left -= 6; |
269 | } else { | 269 | } else { |
270 | err("%s - Unknown sequence found in system data.\n", __func__); | 270 | dev_err(&remote->interface->dev, |
271 | "%s - Unknown sequence found in system data.\n", | ||
272 | __func__); | ||
271 | remote->stage = 0; | 273 | remote->stage = 0; |
272 | return; | 274 | return; |
273 | } | 275 | } |
@@ -286,7 +288,9 @@ static void keyspan_check_data(struct usb_keyspan *remote) | |||
286 | remote->data.tester = remote->data.tester >> 6; | 288 | remote->data.tester = remote->data.tester >> 6; |
287 | remote->data.bits_left -= 6; | 289 | remote->data.bits_left -= 6; |
288 | } else { | 290 | } else { |
289 | err("%s - Unknown sequence found in button data.\n", __func__); | 291 | dev_err(&remote->interface->dev, |
292 | "%s - Unknown sequence found in button data.\n", | ||
293 | __func__); | ||
290 | remote->stage = 0; | 294 | remote->stage = 0; |
291 | return; | 295 | return; |
292 | } | 296 | } |
@@ -302,7 +306,9 @@ static void keyspan_check_data(struct usb_keyspan *remote) | |||
302 | remote->data.tester = remote->data.tester >> 6; | 306 | remote->data.tester = remote->data.tester >> 6; |
303 | remote->data.bits_left -= 6; | 307 | remote->data.bits_left -= 6; |
304 | } else { | 308 | } else { |
305 | err("%s - Error in message, invalid toggle.\n", __func__); | 309 | dev_err(&remote->interface->dev, |
310 | "%s - Error in message, invalid toggle.\n", | ||
311 | __func__); | ||
306 | remote->stage = 0; | 312 | remote->stage = 0; |
307 | return; | 313 | return; |
308 | } | 314 | } |
@@ -312,10 +318,11 @@ static void keyspan_check_data(struct usb_keyspan *remote) | |||
312 | remote->data.tester = remote->data.tester >> 5; | 318 | remote->data.tester = remote->data.tester >> 5; |
313 | remote->data.bits_left -= 5; | 319 | remote->data.bits_left -= 5; |
314 | } else { | 320 | } else { |
315 | err("Bad message received, no stop bit found.\n"); | 321 | dev_err(&remote->interface->dev, |
322 | "Bad message received, no stop bit found.\n"); | ||
316 | } | 323 | } |
317 | 324 | ||
318 | dev_dbg(&remote->udev->dev, | 325 | dev_dbg(&remote->interface->dev, |
319 | "%s found valid message: system: %d, button: %d, toggle: %d\n", | 326 | "%s found valid message: system: %d, button: %d, toggle: %d\n", |
320 | __func__, message.system, message.button, message.toggle); | 327 | __func__, message.system, message.button, message.toggle); |
321 | 328 | ||
@@ -397,7 +404,9 @@ static void keyspan_irq_recv(struct urb *urb) | |||
397 | resubmit: | 404 | resubmit: |
398 | retval = usb_submit_urb(urb, GFP_ATOMIC); | 405 | retval = usb_submit_urb(urb, GFP_ATOMIC); |
399 | if (retval) | 406 | if (retval) |
400 | err ("%s - usb_submit_urb failed with result: %d", __func__, retval); | 407 | dev_err(&dev->interface->dev, |
408 | "%s - usb_submit_urb failed with result: %d\n", | ||
409 | __func__, retval); | ||
401 | } | 410 | } |
402 | 411 | ||
403 | static int keyspan_open(struct input_dev *dev) | 412 | static int keyspan_open(struct input_dev *dev) |
diff --git a/drivers/input/misc/powermate.c b/drivers/input/misc/powermate.c index 538f7049ec6..49c0c3ebd32 100644 --- a/drivers/input/misc/powermate.c +++ b/drivers/input/misc/powermate.c | |||
@@ -65,6 +65,7 @@ struct powermate_device { | |||
65 | struct urb *irq, *config; | 65 | struct urb *irq, *config; |
66 | struct usb_ctrlrequest *configcr; | 66 | struct usb_ctrlrequest *configcr; |
67 | struct usb_device *udev; | 67 | struct usb_device *udev; |
68 | struct usb_interface *intf; | ||
68 | struct input_dev *input; | 69 | struct input_dev *input; |
69 | spinlock_t lock; | 70 | spinlock_t lock; |
70 | int static_brightness; | 71 | int static_brightness; |
@@ -85,6 +86,7 @@ static void powermate_config_complete(struct urb *urb); | |||
85 | static void powermate_irq(struct urb *urb) | 86 | static void powermate_irq(struct urb *urb) |
86 | { | 87 | { |
87 | struct powermate_device *pm = urb->context; | 88 | struct powermate_device *pm = urb->context; |
89 | struct device *dev = &pm->intf->dev; | ||
88 | int retval; | 90 | int retval; |
89 | 91 | ||
90 | switch (urb->status) { | 92 | switch (urb->status) { |
@@ -95,10 +97,12 @@ static void powermate_irq(struct urb *urb) | |||
95 | case -ENOENT: | 97 | case -ENOENT: |
96 | case -ESHUTDOWN: | 98 | case -ESHUTDOWN: |
97 | /* this urb is terminated, clean up */ | 99 | /* this urb is terminated, clean up */ |
98 | dbg("%s - urb shutting down with status: %d", __func__, urb->status); | 100 | dev_dbg(dev, "%s - urb shutting down with status: %d\n", |
101 | __func__, urb->status); | ||
99 | return; | 102 | return; |
100 | default: | 103 | default: |
101 | dbg("%s - nonzero urb status received: %d", __func__, urb->status); | 104 | dev_dbg(dev, "%s - nonzero urb status received: %d\n", |
105 | __func__, urb->status); | ||
102 | goto exit; | 106 | goto exit; |
103 | } | 107 | } |
104 | 108 | ||
@@ -110,8 +114,8 @@ static void powermate_irq(struct urb *urb) | |||
110 | exit: | 114 | exit: |
111 | retval = usb_submit_urb (urb, GFP_ATOMIC); | 115 | retval = usb_submit_urb (urb, GFP_ATOMIC); |
112 | if (retval) | 116 | if (retval) |
113 | err ("%s - usb_submit_urb failed with result %d", | 117 | dev_err(dev, "%s - usb_submit_urb failed with result: %d\n", |
114 | __func__, retval); | 118 | __func__, retval); |
115 | } | 119 | } |
116 | 120 | ||
117 | /* Decide if we need to issue a control message and do so. Must be called with pm->lock taken */ | 121 | /* Decide if we need to issue a control message and do so. Must be called with pm->lock taken */ |
@@ -330,6 +334,7 @@ static int powermate_probe(struct usb_interface *intf, const struct usb_device_i | |||
330 | goto fail3; | 334 | goto fail3; |
331 | 335 | ||
332 | pm->udev = udev; | 336 | pm->udev = udev; |
337 | pm->intf = intf; | ||
333 | pm->input = input_dev; | 338 | pm->input = input_dev; |
334 | 339 | ||
335 | usb_make_path(udev, pm->phys, sizeof(pm->phys)); | 340 | usb_make_path(udev, pm->phys, sizeof(pm->phys)); |
diff --git a/drivers/input/misc/yealink.c b/drivers/input/misc/yealink.c index f4776e7f8c1..285a5bd6cbc 100644 --- a/drivers/input/misc/yealink.c +++ b/drivers/input/misc/yealink.c | |||
@@ -101,6 +101,7 @@ static const struct lcd_segment_map { | |||
101 | struct yealink_dev { | 101 | struct yealink_dev { |
102 | struct input_dev *idev; /* input device */ | 102 | struct input_dev *idev; /* input device */ |
103 | struct usb_device *udev; /* usb device */ | 103 | struct usb_device *udev; /* usb device */ |
104 | struct usb_interface *intf; /* usb interface */ | ||
104 | 105 | ||
105 | /* irq input channel */ | 106 | /* irq input channel */ |
106 | struct yld_ctl_packet *irq_data; | 107 | struct yld_ctl_packet *irq_data; |
@@ -428,7 +429,8 @@ static void urb_irq_callback(struct urb *urb) | |||
428 | int ret, status = urb->status; | 429 | int ret, status = urb->status; |
429 | 430 | ||
430 | if (status) | 431 | if (status) |
431 | err("%s - urb status %d", __func__, status); | 432 | dev_err(&yld->intf->dev, "%s - urb status %d\n", |
433 | __func__, status); | ||
432 | 434 | ||
433 | switch (yld->irq_data->cmd) { | 435 | switch (yld->irq_data->cmd) { |
434 | case CMD_KEYPRESS: | 436 | case CMD_KEYPRESS: |
@@ -437,13 +439,15 @@ static void urb_irq_callback(struct urb *urb) | |||
437 | break; | 439 | break; |
438 | 440 | ||
439 | case CMD_SCANCODE: | 441 | case CMD_SCANCODE: |
440 | dbg("get scancode %x", yld->irq_data->data[0]); | 442 | dev_dbg(&yld->intf->dev, "get scancode %x\n", |
443 | yld->irq_data->data[0]); | ||
441 | 444 | ||
442 | report_key(yld, map_p1k_to_key(yld->irq_data->data[0])); | 445 | report_key(yld, map_p1k_to_key(yld->irq_data->data[0])); |
443 | break; | 446 | break; |
444 | 447 | ||
445 | default: | 448 | default: |
446 | err("unexpected response %x", yld->irq_data->cmd); | 449 | dev_err(&yld->intf->dev, "unexpected response %x\n", |
450 | yld->irq_data->cmd); | ||
447 | } | 451 | } |
448 | 452 | ||
449 | yealink_do_idle_tasks(yld); | 453 | yealink_do_idle_tasks(yld); |
@@ -451,7 +455,9 @@ static void urb_irq_callback(struct urb *urb) | |||
451 | if (!yld->shutdown) { | 455 | if (!yld->shutdown) { |
452 | ret = usb_submit_urb(yld->urb_ctl, GFP_ATOMIC); | 456 | ret = usb_submit_urb(yld->urb_ctl, GFP_ATOMIC); |
453 | if (ret && ret != -EPERM) | 457 | if (ret && ret != -EPERM) |
454 | err("%s - usb_submit_urb failed %d", __func__, ret); | 458 | dev_err(&yld->intf->dev, |
459 | "%s - usb_submit_urb failed %d\n", | ||
460 | __func__, ret); | ||
455 | } | 461 | } |
456 | } | 462 | } |
457 | 463 | ||
@@ -461,7 +467,8 @@ static void urb_ctl_callback(struct urb *urb) | |||
461 | int ret = 0, status = urb->status; | 467 | int ret = 0, status = urb->status; |
462 | 468 | ||
463 | if (status) | 469 | if (status) |
464 | err("%s - urb status %d", __func__, status); | 470 | dev_err(&yld->intf->dev, "%s - urb status %d\n", |
471 | __func__, status); | ||
465 | 472 | ||
466 | switch (yld->ctl_data->cmd) { | 473 | switch (yld->ctl_data->cmd) { |
467 | case CMD_KEYPRESS: | 474 | case CMD_KEYPRESS: |
@@ -479,7 +486,8 @@ static void urb_ctl_callback(struct urb *urb) | |||
479 | } | 486 | } |
480 | 487 | ||
481 | if (ret && ret != -EPERM) | 488 | if (ret && ret != -EPERM) |
482 | err("%s - usb_submit_urb failed %d", __func__, ret); | 489 | dev_err(&yld->intf->dev, "%s - usb_submit_urb failed %d\n", |
490 | __func__, ret); | ||
483 | } | 491 | } |
484 | 492 | ||
485 | /******************************************************************************* | 493 | /******************************************************************************* |
@@ -511,7 +519,7 @@ static int input_open(struct input_dev *dev) | |||
511 | struct yealink_dev *yld = input_get_drvdata(dev); | 519 | struct yealink_dev *yld = input_get_drvdata(dev); |
512 | int i, ret; | 520 | int i, ret; |
513 | 521 | ||
514 | dbg("%s", __func__); | 522 | dev_dbg(&yld->intf->dev, "%s\n", __func__); |
515 | 523 | ||
516 | /* force updates to device */ | 524 | /* force updates to device */ |
517 | for (i = 0; i<sizeof(yld->master); i++) | 525 | for (i = 0; i<sizeof(yld->master); i++) |
@@ -526,8 +534,9 @@ static int input_open(struct input_dev *dev) | |||
526 | yld->ctl_data->size = 10; | 534 | yld->ctl_data->size = 10; |
527 | yld->ctl_data->sum = 0x100-CMD_INIT-10; | 535 | yld->ctl_data->sum = 0x100-CMD_INIT-10; |
528 | if ((ret = usb_submit_urb(yld->urb_ctl, GFP_KERNEL)) != 0) { | 536 | if ((ret = usb_submit_urb(yld->urb_ctl, GFP_KERNEL)) != 0) { |
529 | dbg("%s - usb_submit_urb failed with result %d", | 537 | dev_dbg(&yld->intf->dev, |
530 | __func__, ret); | 538 | "%s - usb_submit_urb failed with result %d\n", |
539 | __func__, ret); | ||
531 | return ret; | 540 | return ret; |
532 | } | 541 | } |
533 | return 0; | 542 | return 0; |
@@ -876,6 +885,7 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id) | |||
876 | return -ENOMEM; | 885 | return -ENOMEM; |
877 | 886 | ||
878 | yld->udev = udev; | 887 | yld->udev = udev; |
888 | yld->intf = intf; | ||
879 | 889 | ||
880 | yld->idev = input_dev = input_allocate_device(); | 890 | yld->idev = input_dev = input_allocate_device(); |
881 | if (!input_dev) | 891 | if (!input_dev) |
@@ -909,7 +919,8 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id) | |||
909 | pipe = usb_rcvintpipe(udev, endpoint->bEndpointAddress); | 919 | pipe = usb_rcvintpipe(udev, endpoint->bEndpointAddress); |
910 | ret = usb_maxpacket(udev, pipe, usb_pipeout(pipe)); | 920 | ret = usb_maxpacket(udev, pipe, usb_pipeout(pipe)); |
911 | if (ret != USB_PKT_LEN) | 921 | if (ret != USB_PKT_LEN) |
912 | err("invalid payload size %d, expected %zd", ret, USB_PKT_LEN); | 922 | dev_err(&intf->dev, "invalid payload size %d, expected %zd\n", |
923 | ret, USB_PKT_LEN); | ||
913 | 924 | ||
914 | /* initialise irq urb */ | 925 | /* initialise irq urb */ |
915 | usb_fill_int_urb(yld->urb_irq, udev, pipe, yld->irq_data, | 926 | usb_fill_int_urb(yld->urb_irq, udev, pipe, yld->irq_data, |