diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:34:49 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:34:49 -0400 |
| commit | 7b22a8855a727c5d8265508cbba05437a68f7043 (patch) | |
| tree | 752493e7055d4152c3abe485c2e9ddb478594180 /drivers/input/joystick | |
| parent | 9451df0ee893dbdfca626f2888654f321d241460 (diff) | |
USB: iforce: remove err() usage
err() was a very old USB-specific macro that I thought had gone away.
This patch removes it from being used in the driver and uses dev_err()
instead.
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/input/joystick')
| -rw-r--r-- | drivers/input/joystick/iforce/iforce-main.c | 3 | ||||
| -rw-r--r-- | drivers/input/joystick/iforce/iforce-packets.c | 10 | ||||
| -rw-r--r-- | drivers/input/joystick/iforce/iforce-usb.c | 5 |
3 files changed, 12 insertions, 6 deletions
diff --git a/drivers/input/joystick/iforce/iforce-main.c b/drivers/input/joystick/iforce/iforce-main.c index 405febd94f2..daeeb4c7e3b 100644 --- a/drivers/input/joystick/iforce/iforce-main.c +++ b/drivers/input/joystick/iforce/iforce-main.c | |||
| @@ -317,7 +317,8 @@ int iforce_init_device(struct iforce *iforce) | |||
| 317 | break; | 317 | break; |
| 318 | 318 | ||
| 319 | if (i == 20) { /* 5 seconds */ | 319 | if (i == 20) { /* 5 seconds */ |
| 320 | err("Timeout waiting for response from device."); | 320 | dev_err(&input_dev->dev, |
| 321 | "Timeout waiting for response from device.\n"); | ||
| 321 | error = -ENODEV; | 322 | error = -ENODEV; |
| 322 | goto fail; | 323 | goto fail; |
| 323 | } | 324 | } |
diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c index a17b5001600..137326a5c2a 100644 --- a/drivers/input/joystick/iforce/iforce-packets.c +++ b/drivers/input/joystick/iforce/iforce-packets.c | |||
| @@ -257,7 +257,8 @@ int iforce_get_id_packet(struct iforce *iforce, char *packet) | |||
| 257 | 257 | ||
| 258 | status = usb_submit_urb(iforce->ctrl, GFP_ATOMIC); | 258 | status = usb_submit_urb(iforce->ctrl, GFP_ATOMIC); |
| 259 | if (status) { | 259 | if (status) { |
| 260 | err("usb_submit_urb failed %d", status); | 260 | dev_err(&iforce->usbdev->dev, |
| 261 | "usb_submit_urb failed %d\n", status); | ||
| 261 | return -1; | 262 | return -1; |
| 262 | } | 263 | } |
| 263 | 264 | ||
| @@ -289,12 +290,15 @@ int iforce_get_id_packet(struct iforce *iforce, char *packet) | |||
| 289 | return -1; | 290 | return -1; |
| 290 | } | 291 | } |
| 291 | #else | 292 | #else |
| 292 | err("iforce_get_id_packet: iforce->bus = SERIO!"); | 293 | dev_err(&iforce->dev->dev, |
| 294 | "iforce_get_id_packet: iforce->bus = SERIO!\n"); | ||
| 293 | #endif | 295 | #endif |
| 294 | break; | 296 | break; |
| 295 | 297 | ||
| 296 | default: | 298 | default: |
| 297 | err("iforce_get_id_packet: iforce->bus = %d", iforce->bus); | 299 | dev_err(&iforce->dev->dev, |
| 300 | "iforce_get_id_packet: iforce->bus = %d\n", | ||
| 301 | iforce->bus); | ||
| 298 | break; | 302 | break; |
| 299 | } | 303 | } |
| 300 | 304 | ||
diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c index 6c96631ae5d..ecbfae7d753 100644 --- a/drivers/input/joystick/iforce/iforce-usb.c +++ b/drivers/input/joystick/iforce/iforce-usb.c | |||
| @@ -100,8 +100,9 @@ static void iforce_usb_irq(struct urb *urb) | |||
| 100 | exit: | 100 | exit: |
| 101 | status = usb_submit_urb (urb, GFP_ATOMIC); | 101 | status = usb_submit_urb (urb, GFP_ATOMIC); |
| 102 | if (status) | 102 | if (status) |
| 103 | err ("%s - usb_submit_urb failed with result %d", | 103 | dev_err(&iforce->usbdev->dev, |
| 104 | __func__, status); | 104 | "%s - usb_submit_urb failed with result %d\n", |
| 105 | __func__, status); | ||
| 105 | } | 106 | } |
| 106 | 107 | ||
| 107 | static void iforce_usb_out(struct urb *urb) | 108 | static void iforce_usb_out(struct urb *urb) |
