diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:23 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:23 -0400 |
commit | 9cb757bfac332cb43122c494597dce80e5424820 (patch) | |
tree | 4cd90bee7a806de32009f665d34901b37b97cdae /drivers/input/joystick/xpad.c | |
parent | 185a85518a6f0649c1d9ca959fa51c6b4dac292a (diff) |
USB: xpad.c: remove err() usage
err() was a very old USB-specific macro that I thought had
gone away. This patch removes it from being used in the
driver and uses dev_err() instead.
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: "Magnus Hörlin" <magnus@alefors.se>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
CC: Chris Moeller <kode54@gmail.c>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/input/joystick/xpad.c')
-rw-r--r-- | drivers/input/joystick/xpad.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index fd7a0d5bc94..bee9c00032e 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c | |||
@@ -492,8 +492,9 @@ static void xpad_irq_in(struct urb *urb) | |||
492 | exit: | 492 | exit: |
493 | retval = usb_submit_urb(urb, GFP_ATOMIC); | 493 | retval = usb_submit_urb(urb, GFP_ATOMIC); |
494 | if (retval) | 494 | if (retval) |
495 | err ("%s - usb_submit_urb failed with result %d", | 495 | dev_err(&xpad->udev->dev, |
496 | __func__, retval); | 496 | "%s - usb_submit_urb failed with result %d\n", |
497 | __func__, retval); | ||
497 | } | 498 | } |
498 | 499 | ||
499 | static void xpad_bulk_out(struct urb *urb) | 500 | static void xpad_bulk_out(struct urb *urb) |
@@ -516,6 +517,7 @@ static void xpad_bulk_out(struct urb *urb) | |||
516 | #if defined(CONFIG_JOYSTICK_XPAD_FF) || defined(CONFIG_JOYSTICK_XPAD_LEDS) | 517 | #if defined(CONFIG_JOYSTICK_XPAD_FF) || defined(CONFIG_JOYSTICK_XPAD_LEDS) |
517 | static void xpad_irq_out(struct urb *urb) | 518 | static void xpad_irq_out(struct urb *urb) |
518 | { | 519 | { |
520 | struct usb_xpad *xpad = urb->context; | ||
519 | int retval, status; | 521 | int retval, status; |
520 | 522 | ||
521 | status = urb->status; | 523 | status = urb->status; |
@@ -540,8 +542,9 @@ static void xpad_irq_out(struct urb *urb) | |||
540 | exit: | 542 | exit: |
541 | retval = usb_submit_urb(urb, GFP_ATOMIC); | 543 | retval = usb_submit_urb(urb, GFP_ATOMIC); |
542 | if (retval) | 544 | if (retval) |
543 | err("%s - usb_submit_urb failed with result %d", | 545 | dev_err(&xpad->udev->dev, |
544 | __func__, retval); | 546 | "%s - usb_submit_urb failed with result %d\n", |
547 | __func__, retval); | ||
545 | } | 548 | } |
546 | 549 | ||
547 | static int xpad_init_output(struct usb_interface *intf, struct usb_xpad *xpad) | 550 | static int xpad_init_output(struct usb_interface *intf, struct usb_xpad *xpad) |