diff options
author | Roland Dreier <rolandd@cisco.com> | 2009-09-05 23:24:23 -0400 |
---|---|---|
committer | Roland Dreier <rolandd@cisco.com> | 2009-09-05 23:24:23 -0400 |
commit | 6276e08a9bdf645b71a092fb4530baf4f6c4c6eb (patch) | |
tree | d9132ced4e91d02230df2ee4d0cef5a89ec2c477 /drivers/infiniband/core/mad.c | |
parent | e07cccf4046978df10f2e13fe2b99b2f9b3a65db (diff) |
IB: Use DEFINE_SPINLOCK() for static spinlocks
Rather than just defining static spinlock_t variables and then
initializing them later in init functions, simply define them with
DEFINE_SPINLOCK() and remove the calls to spin_lock_init(). This cleans
up the source a tad and also shrinks the compiled code; eg on x86-64:
add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-40 (-40)
function old new delta
ib_uverbs_init 336 326 -10
ib_mad_init_module 147 137 -10
ib_sa_init 123 103 -20
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband/core/mad.c')
-rw-r--r-- | drivers/infiniband/core/mad.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index de922a04ca2..5cef8f87b96 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c | |||
@@ -51,8 +51,7 @@ static struct list_head ib_mad_port_list; | |||
51 | static u32 ib_mad_client_id = 0; | 51 | static u32 ib_mad_client_id = 0; |
52 | 52 | ||
53 | /* Port list lock */ | 53 | /* Port list lock */ |
54 | static spinlock_t ib_mad_port_list_lock; | 54 | static DEFINE_SPINLOCK(ib_mad_port_list_lock); |
55 | |||
56 | 55 | ||
57 | /* Forward declarations */ | 56 | /* Forward declarations */ |
58 | static int method_in_use(struct ib_mad_mgmt_method_table **method, | 57 | static int method_in_use(struct ib_mad_mgmt_method_table **method, |
@@ -2984,8 +2983,6 @@ static int __init ib_mad_init_module(void) | |||
2984 | { | 2983 | { |
2985 | int ret; | 2984 | int ret; |
2986 | 2985 | ||
2987 | spin_lock_init(&ib_mad_port_list_lock); | ||
2988 | |||
2989 | ib_mad_cache = kmem_cache_create("ib_mad", | 2986 | ib_mad_cache = kmem_cache_create("ib_mad", |
2990 | sizeof(struct ib_mad_private), | 2987 | sizeof(struct ib_mad_private), |
2991 | 0, | 2988 | 0, |
@@ -3021,4 +3018,3 @@ static void __exit ib_mad_cleanup_module(void) | |||
3021 | 3018 | ||
3022 | module_init(ib_mad_init_module); | 3019 | module_init(ib_mad_init_module); |
3023 | module_exit(ib_mad_cleanup_module); | 3020 | module_exit(ib_mad_cleanup_module); |
3024 | |||