aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/edac/i5400_edac.c
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@redhat.com>2012-04-29 10:59:14 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-06-11 12:23:47 -0400
commitdd23cd6eb1f59ba722a6e6aa228adff7c01404de (patch)
tree32c45fb296293af1309f926b8c109eef329f4f22 /drivers/edac/i5400_edac.c
parent2639c3ee298401881cc560c5e3987f8b222b9f7c (diff)
edac: Don't add __func__ or __FILE__ for debugf[0-9] msgs
The debug macro already adds that. Most of the work here was made by this small script: $f .=$_ while (<>); $f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*": /\1"/g; $f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*/\1/g; $f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*"MC: /\1"/g; $f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g; $f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g; $f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g; $f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g; $f =~ s/\"MC\: \\n\"/"MC:\\n"/g; print $f; After running the script, manual cleanups were done to fix it the remaining places. While here, removed the __LINE__ on most places, as it doesn't actually give useful info on most places. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/edac/i5400_edac.c')
-rw-r--r--drivers/edac/i5400_edac.c24
1 files changed, 11 insertions, 13 deletions
diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c
index 0570cf3d256..be1880de33a 100644
--- a/drivers/edac/i5400_edac.c
+++ b/drivers/edac/i5400_edac.c
@@ -700,7 +700,7 @@ static void i5400_clear_error(struct mem_ctl_info *mci)
700static void i5400_check_error(struct mem_ctl_info *mci) 700static void i5400_check_error(struct mem_ctl_info *mci)
701{ 701{
702 struct i5400_error_info info; 702 struct i5400_error_info info;
703 debugf4("MC%d: %s: %s()\n", mci->mc_idx, __FILE__, __func__); 703 debugf4("MC%d\n", mci->mc_idx);
704 i5400_get_error_info(mci, &info); 704 i5400_get_error_info(mci, &info);
705 i5400_process_error_info(mci, &info); 705 i5400_process_error_info(mci, &info);
706} 706}
@@ -1203,8 +1203,7 @@ static int i5400_init_dimms(struct mem_ctl_info *mci)
1203 1203
1204 size_mb = pvt->dimm_info[slot][channel].megabytes; 1204 size_mb = pvt->dimm_info[slot][channel].megabytes;
1205 1205
1206 debugf2("%s: dimm (branch %d channel %d slot %d): %d.%03d GB\n", 1206 debugf2("dimm (branch %d channel %d slot %d): %d.%03d GB\n",
1207 __func__,
1208 channel / 2, channel % 2, slot, 1207 channel / 2, channel % 2, slot,
1209 size_mb / 1000, size_mb % 1000); 1208 size_mb / 1000, size_mb % 1000);
1210 1209
@@ -1270,9 +1269,8 @@ static int i5400_probe1(struct pci_dev *pdev, int dev_idx)
1270 if (dev_idx >= ARRAY_SIZE(i5400_devs)) 1269 if (dev_idx >= ARRAY_SIZE(i5400_devs))
1271 return -EINVAL; 1270 return -EINVAL;
1272 1271
1273 debugf0("MC: %s: %s(), pdev bus %u dev=0x%x fn=0x%x\n", 1272 debugf0("MC: %s(), pdev bus %u dev=0x%x fn=0x%x\n",
1274 __FILE__, __func__, 1273 __FILE__, pdev->bus->number,
1275 pdev->bus->number,
1276 PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn)); 1274 PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
1277 1275
1278 /* We only are looking for func 0 of the set */ 1276 /* We only are looking for func 0 of the set */
@@ -1297,7 +1295,7 @@ static int i5400_probe1(struct pci_dev *pdev, int dev_idx)
1297 if (mci == NULL) 1295 if (mci == NULL)
1298 return -ENOMEM; 1296 return -ENOMEM;
1299 1297
1300 debugf0("MC: %s: %s(): mci = %p\n", __FILE__, __func__, mci); 1298 debugf0("MC: %s(): mci = %p\n", __FILE__, mci);
1301 1299
1302 mci->pdev = &pdev->dev; /* record ptr to the generic device */ 1300 mci->pdev = &pdev->dev; /* record ptr to the generic device */
1303 1301
@@ -1340,8 +1338,8 @@ static int i5400_probe1(struct pci_dev *pdev, int dev_idx)
1340 1338
1341 /* add this new MC control structure to EDAC's list of MCs */ 1339 /* add this new MC control structure to EDAC's list of MCs */
1342 if (edac_mc_add_mc(mci)) { 1340 if (edac_mc_add_mc(mci)) {
1343 debugf0("MC: %s: %s(): failed edac_mc_add_mc()\n", 1341 debugf0("MC: %s(): failed edac_mc_add_mc()\n",
1344 __FILE__, __func__); 1342 __FILE__);
1345 /* FIXME: perhaps some code should go here that disables error 1343 /* FIXME: perhaps some code should go here that disables error
1346 * reporting if we just enabled it 1344 * reporting if we just enabled it
1347 */ 1345 */
@@ -1385,7 +1383,7 @@ static int __devinit i5400_init_one(struct pci_dev *pdev,
1385{ 1383{
1386 int rc; 1384 int rc;
1387 1385
1388 debugf0("MC: %s: %s()\n", __FILE__, __func__); 1386 debugf0("MC: %s()\n", __FILE__);
1389 1387
1390 /* wake up device */ 1388 /* wake up device */
1391 rc = pci_enable_device(pdev); 1389 rc = pci_enable_device(pdev);
@@ -1404,7 +1402,7 @@ static void __devexit i5400_remove_one(struct pci_dev *pdev)
1404{ 1402{
1405 struct mem_ctl_info *mci; 1403 struct mem_ctl_info *mci;
1406 1404
1407 debugf0("%s: %s()\n", __FILE__, __func__); 1405 debugf0("%s()\n", __FILE__);
1408 1406
1409 if (i5400_pci) 1407 if (i5400_pci)
1410 edac_pci_release_generic_ctl(i5400_pci); 1408 edac_pci_release_generic_ctl(i5400_pci);
@@ -1450,7 +1448,7 @@ static int __init i5400_init(void)
1450{ 1448{
1451 int pci_rc; 1449 int pci_rc;
1452 1450
1453 debugf2("MC: %s: %s()\n", __FILE__, __func__); 1451 debugf2("MC: %s()\n", __FILE__);
1454 1452
1455 /* Ensure that the OPSTATE is set correctly for POLL or NMI */ 1453 /* Ensure that the OPSTATE is set correctly for POLL or NMI */
1456 opstate_init(); 1454 opstate_init();
@@ -1466,7 +1464,7 @@ static int __init i5400_init(void)
1466 */ 1464 */
1467static void __exit i5400_exit(void) 1465static void __exit i5400_exit(void)
1468{ 1466{
1469 debugf2("MC: %s: %s()\n", __FILE__, __func__); 1467 debugf2("MC: %s()\n", __FILE__);
1470 pci_unregister_driver(&i5400_driver); 1468 pci_unregister_driver(&i5400_driver);
1471} 1469}
1472 1470