diff options
author | Stephen Boyd <sboyd@codeaurora.org> | 2012-09-24 16:38:05 -0400 |
---|---|---|
committer | Mike Turquette <mturquette@linaro.org> | 2012-10-29 14:12:55 -0400 |
commit | 9be9d482bcf5a0a3e0ae131a98573b9e2d358915 (patch) | |
tree | 7bacf94da9d214eadd0b74d19c558428e2e4f8c6 /drivers/clk | |
parent | 46c8773a58010d31f228e148b8b774d94cc9810d (diff) |
clk: wm831x: Use devm_clk_register() to simplify code
Move this driver to use devm_clk_register() to simplify some
error paths and reduce lines of code.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
Diffstat (limited to 'drivers/clk')
-rw-r--r-- | drivers/clk/clk-wm831x.c | 30 |
1 files changed, 7 insertions, 23 deletions
diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c index eb1afafca03..db4fbf20ffd 100644 --- a/drivers/clk/clk-wm831x.c +++ b/drivers/clk/clk-wm831x.c | |||
@@ -370,43 +370,27 @@ static __devinit int wm831x_clk_probe(struct platform_device *pdev) | |||
370 | clkdata->xtal_ena = ret & WM831X_XTAL_ENA; | 370 | clkdata->xtal_ena = ret & WM831X_XTAL_ENA; |
371 | 371 | ||
372 | clkdata->xtal_hw.init = &wm831x_xtal_init; | 372 | clkdata->xtal_hw.init = &wm831x_xtal_init; |
373 | clkdata->xtal = clk_register(&pdev->dev, &clkdata->xtal_hw); | 373 | clkdata->xtal = devm_clk_register(&pdev->dev, &clkdata->xtal_hw); |
374 | if (IS_ERR(clkdata->xtal)) | 374 | if (IS_ERR(clkdata->xtal)) |
375 | return PTR_ERR(clkdata->xtal); | 375 | return PTR_ERR(clkdata->xtal); |
376 | 376 | ||
377 | clkdata->fll_hw.init = &wm831x_fll_init; | 377 | clkdata->fll_hw.init = &wm831x_fll_init; |
378 | clkdata->fll = clk_register(&pdev->dev, &clkdata->fll_hw); | 378 | clkdata->fll = devm_clk_register(&pdev->dev, &clkdata->fll_hw); |
379 | if (IS_ERR(clkdata->fll)) { | 379 | if (IS_ERR(clkdata->fll)) |
380 | ret = PTR_ERR(clkdata->fll); | 380 | return PTR_ERR(clkdata->fll); |
381 | goto err_xtal; | ||
382 | } | ||
383 | 381 | ||
384 | clkdata->clkout_hw.init = &wm831x_clkout_init; | 382 | clkdata->clkout_hw.init = &wm831x_clkout_init; |
385 | clkdata->clkout = clk_register(&pdev->dev, &clkdata->clkout_hw); | 383 | clkdata->clkout = devm_clk_register(&pdev->dev, &clkdata->clkout_hw); |
386 | if (IS_ERR(clkdata->clkout)) { | 384 | if (IS_ERR(clkdata->clkout)) |
387 | ret = PTR_ERR(clkdata->clkout); | 385 | return PTR_ERR(clkdata->clkout); |
388 | goto err_fll; | ||
389 | } | ||
390 | 386 | ||
391 | dev_set_drvdata(&pdev->dev, clkdata); | 387 | dev_set_drvdata(&pdev->dev, clkdata); |
392 | 388 | ||
393 | return 0; | 389 | return 0; |
394 | |||
395 | err_fll: | ||
396 | clk_unregister(clkdata->fll); | ||
397 | err_xtal: | ||
398 | clk_unregister(clkdata->xtal); | ||
399 | return ret; | ||
400 | } | 390 | } |
401 | 391 | ||
402 | static int __devexit wm831x_clk_remove(struct platform_device *pdev) | 392 | static int __devexit wm831x_clk_remove(struct platform_device *pdev) |
403 | { | 393 | { |
404 | struct wm831x_clk *clkdata = dev_get_drvdata(&pdev->dev); | ||
405 | |||
406 | clk_unregister(clkdata->clkout); | ||
407 | clk_unregister(clkdata->fll); | ||
408 | clk_unregister(clkdata->xtal); | ||
409 | |||
410 | return 0; | 394 | return 0; |
411 | } | 395 | } |
412 | 396 | ||