aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/pcmcia
diff options
context:
space:
mode:
authorDominik Brodowski <linux@dominikbrodowski.net>2010-08-08 06:27:40 -0400
committerDominik Brodowski <linux@dominikbrodowski.net>2010-09-29 11:20:25 -0400
commit06b3a1d12f41b592972643f8b84015d6c03dc576 (patch)
tree9c2e9450a74f3cea78d8819bfcd305f3f6c40b0d /drivers/char/pcmcia
parent2e9b981a7c63ee8278df6823f8389d69dad1a499 (diff)
pcmcia: avoid messages on module (un)loading
printk() statements on module load or unload are frowned upon. Also, add a few __init or __exit declarations. Tested-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/char/pcmcia')
-rw-r--r--drivers/char/pcmcia/cm4000_cs.c5
-rw-r--r--drivers/char/pcmcia/cm4040_cs.c5
-rw-r--r--drivers/char/pcmcia/ipwireless/main.c6
-rw-r--r--drivers/char/pcmcia/synclink_cs.c4
4 files changed, 0 insertions, 20 deletions
diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c
index e932526d456..c7b482d15e2 100644
--- a/drivers/char/pcmcia/cm4000_cs.c
+++ b/drivers/char/pcmcia/cm4000_cs.c
@@ -54,8 +54,6 @@
54 __func__ , ## args); \ 54 __func__ , ## args); \
55 } while (0) 55 } while (0)
56 56
57static char *version = "cm4000_cs.c v2.4.0gm6 - All bugs added by Harald Welte";
58
59#define T_1SEC (HZ) 57#define T_1SEC (HZ)
60#define T_10MSEC msecs_to_jiffies(10) 58#define T_10MSEC msecs_to_jiffies(10)
61#define T_20MSEC msecs_to_jiffies(20) 59#define T_20MSEC msecs_to_jiffies(20)
@@ -1889,8 +1887,6 @@ static int __init cmm_init(void)
1889{ 1887{
1890 int rc; 1888 int rc;
1891 1889
1892 printk(KERN_INFO "%s\n", version);
1893
1894 cmm_class = class_create(THIS_MODULE, "cardman_4000"); 1890 cmm_class = class_create(THIS_MODULE, "cardman_4000");
1895 if (IS_ERR(cmm_class)) 1891 if (IS_ERR(cmm_class))
1896 return PTR_ERR(cmm_class); 1892 return PTR_ERR(cmm_class);
@@ -1915,7 +1911,6 @@ static int __init cmm_init(void)
1915 1911
1916static void __exit cmm_exit(void) 1912static void __exit cmm_exit(void)
1917{ 1913{
1918 printk(KERN_INFO MODULE_NAME ": unloading\n");
1919 pcmcia_unregister_driver(&cm4000_driver); 1914 pcmcia_unregister_driver(&cm4000_driver);
1920 unregister_chrdev(major, DEVICE_NAME); 1915 unregister_chrdev(major, DEVICE_NAME);
1921 class_destroy(cmm_class); 1916 class_destroy(cmm_class);
diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c
index d7e2bec0248..bf2f046fc2c 100644
--- a/drivers/char/pcmcia/cm4040_cs.c
+++ b/drivers/char/pcmcia/cm4040_cs.c
@@ -48,9 +48,6 @@
48 __func__ , ## args); \ 48 __func__ , ## args); \
49 } while (0) 49 } while (0)
50 50
51static char *version =
52"OMNIKEY CardMan 4040 v1.1.0gm5 - All bugs added by Harald Welte";
53
54#define CCID_DRIVER_BULK_DEFAULT_TIMEOUT (150*HZ) 51#define CCID_DRIVER_BULK_DEFAULT_TIMEOUT (150*HZ)
55#define CCID_DRIVER_ASYNC_POWERUP_TIMEOUT (35*HZ) 52#define CCID_DRIVER_ASYNC_POWERUP_TIMEOUT (35*HZ)
56#define CCID_DRIVER_MINIMUM_TIMEOUT (3*HZ) 53#define CCID_DRIVER_MINIMUM_TIMEOUT (3*HZ)
@@ -653,7 +650,6 @@ static int __init cm4040_init(void)
653{ 650{
654 int rc; 651 int rc;
655 652
656 printk(KERN_INFO "%s\n", version);
657 cmx_class = class_create(THIS_MODULE, "cardman_4040"); 653 cmx_class = class_create(THIS_MODULE, "cardman_4040");
658 if (IS_ERR(cmx_class)) 654 if (IS_ERR(cmx_class))
659 return PTR_ERR(cmx_class); 655 return PTR_ERR(cmx_class);
@@ -678,7 +674,6 @@ static int __init cm4040_init(void)
678 674
679static void __exit cm4040_exit(void) 675static void __exit cm4040_exit(void)
680{ 676{
681 printk(KERN_INFO MODULE_NAME ": unloading\n");
682 pcmcia_unregister_driver(&reader_driver); 677 pcmcia_unregister_driver(&reader_driver);
683 unregister_chrdev(major, DEVICE_NAME); 678 unregister_chrdev(major, DEVICE_NAME);
684 class_destroy(cmx_class); 679 class_destroy(cmx_class);
diff --git a/drivers/char/pcmcia/ipwireless/main.c b/drivers/char/pcmcia/ipwireless/main.c
index a1b80834669..94b8eb4d691 100644
--- a/drivers/char/pcmcia/ipwireless/main.c
+++ b/drivers/char/pcmcia/ipwireless/main.c
@@ -307,9 +307,6 @@ static int __init init_ipwireless(void)
307{ 307{
308 int ret; 308 int ret;
309 309
310 printk(KERN_INFO IPWIRELESS_PCCARD_NAME " "
311 IPWIRELESS_PCMCIA_VERSION " by " IPWIRELESS_PCMCIA_AUTHOR "\n");
312
313 ret = ipwireless_tty_init(); 310 ret = ipwireless_tty_init();
314 if (ret != 0) 311 if (ret != 0)
315 return ret; 312 return ret;
@@ -326,9 +323,6 @@ static int __init init_ipwireless(void)
326 */ 323 */
327static void __exit exit_ipwireless(void) 324static void __exit exit_ipwireless(void)
328{ 325{
329 printk(KERN_INFO IPWIRELESS_PCCARD_NAME " "
330 IPWIRELESS_PCMCIA_VERSION " removed\n");
331
332 pcmcia_unregister_driver(&me); 326 pcmcia_unregister_driver(&me);
333 ipwireless_tty_release(); 327 ipwireless_tty_release();
334} 328}
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
index 493dba51115..d97a53cccdc 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -2809,8 +2809,6 @@ static void synclink_cs_cleanup(void)
2809{ 2809{
2810 int rc; 2810 int rc;
2811 2811
2812 printk("Unloading %s: version %s\n", driver_name, driver_version);
2813
2814 while(mgslpc_device_list) 2812 while(mgslpc_device_list)
2815 mgslpc_remove_device(mgslpc_device_list); 2813 mgslpc_remove_device(mgslpc_device_list);
2816 2814
@@ -2833,8 +2831,6 @@ static int __init synclink_cs_init(void)
2833 BREAKPOINT(); 2831 BREAKPOINT();
2834 } 2832 }
2835 2833
2836 printk("%s %s\n", driver_name, driver_version);
2837
2838 if ((rc = pcmcia_register_driver(&mgslpc_driver)) < 0) 2834 if ((rc = pcmcia_register_driver(&mgslpc_driver)) < 0)
2839 return rc; 2835 return rc;
2840 2836