diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:51:59 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (patch) | |
tree | 620648585f89cdb589d1625431f8c21ef70a9258 /drivers/ata/pata_ali.c | |
parent | a44fec1fce5d5d14cc3ac4545b8da346394de666 (diff) |
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/pata_ali.c')
-rw-r--r-- | drivers/ata/pata_ali.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index 794ec6e3275..cadd67998ba 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c | |||
@@ -287,10 +287,10 @@ static void ali_warn_atapi_dma(struct ata_device *adev) | |||
287 | int print_info = ehc->i.flags & ATA_EHI_PRINTINFO; | 287 | int print_info = ehc->i.flags & ATA_EHI_PRINTINFO; |
288 | 288 | ||
289 | if (print_info && adev->class == ATA_DEV_ATAPI && !ali_atapi_dma) { | 289 | if (print_info && adev->class == ATA_DEV_ATAPI && !ali_atapi_dma) { |
290 | ata_dev_printk(adev, KERN_WARNING, | 290 | ata_dev_warn(adev, |
291 | "WARNING: ATAPI DMA disabled for reliability issues. It can be enabled\n"); | 291 | "WARNING: ATAPI DMA disabled for reliability issues. It can be enabled\n"); |
292 | ata_dev_printk(adev, KERN_WARNING, | 292 | ata_dev_warn(adev, |
293 | "WARNING: via pata_ali.atapi_dma modparam or corresponding sysfs node.\n"); | 293 | "WARNING: via pata_ali.atapi_dma modparam or corresponding sysfs node.\n"); |
294 | } | 294 | } |
295 | } | 295 | } |
296 | 296 | ||