diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2011-11-01 13:52:29 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-11-01 13:52:29 -0400 |
commit | 1c398651518c7e25a9fb3f08b456c73d5ca22469 (patch) | |
tree | 116ad4df5c8faa5f8e0d7982c479bf08ea01f2ec /drivers/acpi | |
parent | f470f8d4e702593ee1d0852871ad80373bce707b (diff) | |
parent | b238b8fa93353ab50c9a2b1e2fa47a0ab01c37cd (diff) |
Merge branch 'pstore' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux
* 'pstore' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux:
pstore: make pstore write function return normal success/fail value
pstore: change mutex locking to spin_locks
pstore: defer inserting OOPS entries into pstore
Diffstat (limited to 'drivers/acpi')
-rw-r--r-- | drivers/acpi/apei/erst.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c index 2ca59dc69f7..127408069ca 100644 --- a/drivers/acpi/apei/erst.c +++ b/drivers/acpi/apei/erst.c | |||
@@ -933,7 +933,7 @@ static int erst_open_pstore(struct pstore_info *psi); | |||
933 | static int erst_close_pstore(struct pstore_info *psi); | 933 | static int erst_close_pstore(struct pstore_info *psi); |
934 | static ssize_t erst_reader(u64 *id, enum pstore_type_id *type, | 934 | static ssize_t erst_reader(u64 *id, enum pstore_type_id *type, |
935 | struct timespec *time, struct pstore_info *psi); | 935 | struct timespec *time, struct pstore_info *psi); |
936 | static u64 erst_writer(enum pstore_type_id type, unsigned int part, | 936 | static int erst_writer(enum pstore_type_id type, u64 *id, unsigned int part, |
937 | size_t size, struct pstore_info *psi); | 937 | size_t size, struct pstore_info *psi); |
938 | static int erst_clearer(enum pstore_type_id type, u64 id, | 938 | static int erst_clearer(enum pstore_type_id type, u64 id, |
939 | struct pstore_info *psi); | 939 | struct pstore_info *psi); |
@@ -1040,11 +1040,12 @@ out: | |||
1040 | return (rc < 0) ? rc : (len - sizeof(*rcd)); | 1040 | return (rc < 0) ? rc : (len - sizeof(*rcd)); |
1041 | } | 1041 | } |
1042 | 1042 | ||
1043 | static u64 erst_writer(enum pstore_type_id type, unsigned int part, | 1043 | static int erst_writer(enum pstore_type_id type, u64 *id, unsigned int part, |
1044 | size_t size, struct pstore_info *psi) | 1044 | size_t size, struct pstore_info *psi) |
1045 | { | 1045 | { |
1046 | struct cper_pstore_record *rcd = (struct cper_pstore_record *) | 1046 | struct cper_pstore_record *rcd = (struct cper_pstore_record *) |
1047 | (erst_info.buf - sizeof(*rcd)); | 1047 | (erst_info.buf - sizeof(*rcd)); |
1048 | int ret; | ||
1048 | 1049 | ||
1049 | memset(rcd, 0, sizeof(*rcd)); | 1050 | memset(rcd, 0, sizeof(*rcd)); |
1050 | memcpy(rcd->hdr.signature, CPER_SIG_RECORD, CPER_SIG_SIZE); | 1051 | memcpy(rcd->hdr.signature, CPER_SIG_RECORD, CPER_SIG_SIZE); |
@@ -1079,9 +1080,10 @@ static u64 erst_writer(enum pstore_type_id type, unsigned int part, | |||
1079 | } | 1080 | } |
1080 | rcd->sec_hdr.section_severity = CPER_SEV_FATAL; | 1081 | rcd->sec_hdr.section_severity = CPER_SEV_FATAL; |
1081 | 1082 | ||
1082 | erst_write(&rcd->hdr); | 1083 | ret = erst_write(&rcd->hdr); |
1084 | *id = rcd->hdr.record_id; | ||
1083 | 1085 | ||
1084 | return rcd->hdr.record_id; | 1086 | return ret; |
1085 | } | 1087 | } |
1086 | 1088 | ||
1087 | static int erst_clearer(enum pstore_type_id type, u64 id, | 1089 | static int erst_clearer(enum pstore_type_id type, u64 id, |
@@ -1165,7 +1167,7 @@ static int __init erst_init(void) | |||
1165 | goto err_release_erange; | 1167 | goto err_release_erange; |
1166 | 1168 | ||
1167 | buf = kmalloc(erst_erange.size, GFP_KERNEL); | 1169 | buf = kmalloc(erst_erange.size, GFP_KERNEL); |
1168 | mutex_init(&erst_info.buf_mutex); | 1170 | spin_lock_init(&erst_info.buf_lock); |
1169 | if (buf) { | 1171 | if (buf) { |
1170 | erst_info.buf = buf + sizeof(struct cper_pstore_record); | 1172 | erst_info.buf = buf + sizeof(struct cper_pstore_record); |
1171 | erst_info.bufsize = erst_erange.size - | 1173 | erst_info.bufsize = erst_erange.size - |