aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/acpi/dispatcher/dsopcode.c
diff options
context:
space:
mode:
authorBob Moore <robert.moore@intel.com>2008-11-12 02:15:29 -0500
committerLen Brown <len.brown@intel.com>2008-12-29 22:38:36 -0500
commitfc37445733aeae4fd1a20385850620354263b1d5 (patch)
treea989d6bf8dcc2011f25e365532c3855a48f11c62 /drivers/acpi/dispatcher/dsopcode.c
parent96411a630412f057d365aa1e9de7d23c069d627a (diff)
ACPICA: Add a mechanism to escape infinite AML While() loops
Add a loop counter to force exit from AML While loops if the count becomes too large. This can occur in poorly written AML when the hardware does not respond within a while loop and the loop does not implement a timeout. The maximum loop count is configurable. A new exception code is returned when a loop is broken, AE_AML_INFINITE_LOOP. Bob Moore, Alexey Starikovskiy. Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Lin Ming <ming.m.lin@intel.com> Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/dispatcher/dsopcode.c')
-rw-r--r--drivers/acpi/dispatcher/dsopcode.c24
1 files changed, 21 insertions, 3 deletions
diff --git a/drivers/acpi/dispatcher/dsopcode.c b/drivers/acpi/dispatcher/dsopcode.c
index 5cd406676c2..50c892a49fa 100644
--- a/drivers/acpi/dispatcher/dsopcode.c
+++ b/drivers/acpi/dispatcher/dsopcode.c
@@ -1262,13 +1262,31 @@ acpi_ds_exec_end_control_op(struct acpi_walk_state * walk_state,
1262 1262
1263 ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "[WHILE_OP] Op=%p\n", op)); 1263 ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "[WHILE_OP] Op=%p\n", op));
1264 1264
1265 if (walk_state->control_state->common.value) { 1265 control_state = walk_state->control_state;
1266 if (control_state->common.value) {
1266 1267
1267 /* Predicate was true, go back and evaluate it again! */ 1268 /* Predicate was true, the body of the loop was just executed */
1268 1269
1270 /*
1271 * This loop counter mechanism allows the interpreter to escape
1272 * possibly infinite loops. This can occur in poorly written AML
1273 * when the hardware does not respond within a while loop and the
1274 * loop does not implement a timeout.
1275 */
1276 control_state->control.loop_count++;
1277 if (control_state->control.loop_count >
1278 ACPI_MAX_LOOP_ITERATIONS) {
1279 status = AE_AML_INFINITE_LOOP;
1280 break;
1281 }
1282
1283 /*
1284 * Go back and evaluate the predicate and maybe execute the loop
1285 * another time
1286 */
1269 status = AE_CTRL_PENDING; 1287 status = AE_CTRL_PENDING;
1270 walk_state->aml_last_while = 1288 walk_state->aml_last_while =
1271 walk_state->control_state->control.aml_predicate_start; 1289 control_state->control.aml_predicate_start;
1272 break; 1290 break;
1273 } 1291 }
1274 1292