aboutsummaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorBoaz Harrosh <bharrosh@panasas.com>2006-12-05 04:19:14 -0500
committerJens Axboe <axboe@nelson.home.kernel.dk>2006-12-12 04:22:23 -0500
commit2b02a1792000900ead4638f4d42fcdd742062cfa (patch)
treea996a02cd8d028fd53223bd17ae8793185d94702 /block
parent4259cb25d436a79bf6b07d8075423573567c211d (diff)
[PATCH] remove blk_queue_activity_fn
While working on bidi support at struct request level I have found that blk_queue_activity_fn is actually never used. The only user is in ide-probe.c with this code: /* enable led activity for disk drives only */ if (drive->media == ide_disk && hwif->led_act) blk_queue_activity_fn(q, hwif->led_act, drive); And led_act is never initialized anywhere. (Looking back at older kernels it was used in the PPC arch, but was removed around 2.6.18) Unless it is all for future use off course. (this patch is against linux-2.6-block.git as off 2006/12/4) Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r--block/ll_rw_blk.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index 785e61c9a81..a541b42c08e 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -129,13 +129,6 @@ struct backing_dev_info *blk_get_backing_dev_info(struct block_device *bdev)
129} 129}
130EXPORT_SYMBOL(blk_get_backing_dev_info); 130EXPORT_SYMBOL(blk_get_backing_dev_info);
131 131
132void blk_queue_activity_fn(request_queue_t *q, activity_fn *fn, void *data)
133{
134 q->activity_fn = fn;
135 q->activity_data = data;
136}
137EXPORT_SYMBOL(blk_queue_activity_fn);
138
139/** 132/**
140 * blk_queue_prep_rq - set a prepare_request function for queue 133 * blk_queue_prep_rq - set a prepare_request function for queue
141 * @q: queue 134 * @q: queue
@@ -238,8 +231,6 @@ void blk_queue_make_request(request_queue_t * q, make_request_fn * mfn)
238 * by default assume old behaviour and bounce for any highmem page 231 * by default assume old behaviour and bounce for any highmem page
239 */ 232 */
240 blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH); 233 blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH);
241
242 blk_queue_activity_fn(q, NULL, NULL);
243} 234}
244 235
245EXPORT_SYMBOL(blk_queue_make_request); 236EXPORT_SYMBOL(blk_queue_make_request);
@@ -2696,9 +2687,6 @@ static inline void add_request(request_queue_t * q, struct request * req)
2696{ 2687{
2697 drive_stat_acct(req, req->nr_sectors, 1); 2688 drive_stat_acct(req, req->nr_sectors, 1);
2698 2689
2699 if (q->activity_fn)
2700 q->activity_fn(q->activity_data, rq_data_dir(req));
2701
2702 /* 2690 /*
2703 * elevator indicated where it wants this request to be 2691 * elevator indicated where it wants this request to be
2704 * inserted at elevator_merge time 2692 * inserted at elevator_merge time