aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorRussell King <rmk+kernel@arm.linux.org.uk>2010-11-30 06:12:30 -0500
committerRussell King <rmk+kernel@arm.linux.org.uk>2010-12-20 10:09:10 -0500
commitbbc81fd4327f9ed4480b05981e38acd48b1d184a (patch)
treeeac37c1c598418589bf70badacd9509b566cdecc /arch
parent3c030beabf937b1d3b4ecaedfd1fb2f1e2aa0c70 (diff)
ARM: CPU hotplug: remove bug checks in platform_cpu_die()
platform_cpu_die() is entered from the CPU's own idle thread, which can not be migrated to other CPUs. Moreover, the 'cpu' argument comes from the thread info, which will always be the 'current' CPU. So remove this useless bug check. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch')
-rw-r--r--arch/arm/mach-omap2/omap-hotplug.c8
-rw-r--r--arch/arm/mach-realview/hotplug.c10
-rw-r--r--arch/arm/mach-s5pv310/hotplug.c10
-rw-r--r--arch/arm/mach-tegra/hotplug.c10
-rw-r--r--arch/arm/mach-ux500/hotplug.c10
5 files changed, 0 insertions, 48 deletions
diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c
index ace979d74bf..4976b9393e4 100644
--- a/arch/arm/mach-omap2/omap-hotplug.c
+++ b/arch/arm/mach-omap2/omap-hotplug.c
@@ -32,14 +32,6 @@ int platform_cpu_kill(unsigned int cpu)
32 */ 32 */
33void platform_cpu_die(unsigned int cpu) 33void platform_cpu_die(unsigned int cpu)
34{ 34{
35 unsigned int this_cpu = hard_smp_processor_id();
36
37 if (cpu != this_cpu) {
38 pr_crit("platform_cpu_die running on %u, should be %u\n",
39 this_cpu, cpu);
40 BUG();
41 }
42
43 flush_cache_all(); 35 flush_cache_all();
44 dsb(); 36 dsb();
45 37
diff --git a/arch/arm/mach-realview/hotplug.c b/arch/arm/mach-realview/hotplug.c
index 7d58c16c83a..e06572e6c49 100644
--- a/arch/arm/mach-realview/hotplug.c
+++ b/arch/arm/mach-realview/hotplug.c
@@ -102,16 +102,6 @@ int platform_cpu_kill(unsigned int cpu)
102 */ 102 */
103void platform_cpu_die(unsigned int cpu) 103void platform_cpu_die(unsigned int cpu)
104{ 104{
105#ifdef DEBUG
106 unsigned int this_cpu = hard_smp_processor_id();
107
108 if (cpu != this_cpu) {
109 printk(KERN_CRIT "Eek! platform_cpu_die running on %u, should be %u\n",
110 this_cpu, cpu);
111 BUG();
112 }
113#endif
114
115 /* 105 /*
116 * we're ready for shutdown now, so do it 106 * we're ready for shutdown now, so do it
117 */ 107 */
diff --git a/arch/arm/mach-s5pv310/hotplug.c b/arch/arm/mach-s5pv310/hotplug.c
index d7be70ac753..ea951ef6ea5 100644
--- a/arch/arm/mach-s5pv310/hotplug.c
+++ b/arch/arm/mach-s5pv310/hotplug.c
@@ -105,16 +105,6 @@ int platform_cpu_kill(unsigned int cpu)
105 */ 105 */
106void platform_cpu_die(unsigned int cpu) 106void platform_cpu_die(unsigned int cpu)
107{ 107{
108#ifdef DEBUG
109 unsigned int this_cpu = hard_smp_processor_id();
110
111 if (cpu != this_cpu) {
112 printk(KERN_CRIT "Eek! platform_cpu_die running on %u, should be %u\n",
113 this_cpu, cpu);
114 BUG();
115 }
116#endif
117
118 /* 108 /*
119 * we're ready for shutdown now, so do it 109 * we're ready for shutdown now, so do it
120 */ 110 */
diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
index ecaa41ce497..a5eeb912664 100644
--- a/arch/arm/mach-tegra/hotplug.c
+++ b/arch/arm/mach-tegra/hotplug.c
@@ -101,16 +101,6 @@ int platform_cpu_kill(unsigned int cpu)
101 */ 101 */
102void platform_cpu_die(unsigned int cpu) 102void platform_cpu_die(unsigned int cpu)
103{ 103{
104#ifdef DEBUG
105 unsigned int this_cpu = hard_smp_processor_id();
106
107 if (cpu != this_cpu) {
108 printk(KERN_CRIT "Eek! platform_cpu_die running on %u, should be %u\n",
109 this_cpu, cpu);
110 BUG();
111 }
112#endif
113
114 /* 104 /*
115 * we're ready for shutdown now, so do it 105 * we're ready for shutdown now, so do it
116 */ 106 */
diff --git a/arch/arm/mach-ux500/hotplug.c b/arch/arm/mach-ux500/hotplug.c
index 7a4890b96e5..dd8037ebccf 100644
--- a/arch/arm/mach-ux500/hotplug.c
+++ b/arch/arm/mach-ux500/hotplug.c
@@ -45,16 +45,6 @@ int platform_cpu_kill(unsigned int cpu)
45 */ 45 */
46void platform_cpu_die(unsigned int cpu) 46void platform_cpu_die(unsigned int cpu)
47{ 47{
48#ifdef DEBUG
49 unsigned int this_cpu = hard_smp_processor_id();
50
51 if (cpu != this_cpu) {
52 printk(KERN_CRIT "Eek! platform_cpu_die running on %u, should be %u\n",
53 this_cpu, cpu);
54 BUG();
55 }
56#endif
57
58 /* directly enter low power state, skipping secure registers */ 48 /* directly enter low power state, skipping secure registers */
59 platform_do_lowpower(cpu); 49 platform_do_lowpower(cpu);
60} 50}