diff options
author | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-08-09 13:02:50 -0400 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-08-09 13:04:08 -0400 |
commit | 10fe570fc16721d78afdba9689720094527c1ba3 (patch) | |
tree | 224d7b192039b1f0d24d1036269e44cf88b42f16 /arch/x86/xen | |
parent | 322a8b034003c0d46d39af85bf24fee27b902f48 (diff) |
Revert "xen/debug: WARN_ON when identity PFN has no _PAGE_IOMAP flag set."
We don' use it anymore and there are more false positives.
This reverts commit fc25151d9ac7d809239fe68de0a1490b504bb94a.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'arch/x86/xen')
-rw-r--r-- | arch/x86/xen/Kconfig | 8 | ||||
-rw-r--r-- | arch/x86/xen/mmu.c | 38 |
2 files changed, 0 insertions, 46 deletions
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 5cc821cb2e0..ae559fe91c2 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig | |||
@@ -49,11 +49,3 @@ config XEN_DEBUG_FS | |||
49 | help | 49 | help |
50 | Enable statistics output and various tuning options in debugfs. | 50 | Enable statistics output and various tuning options in debugfs. |
51 | Enabling this option may incur a significant performance overhead. | 51 | Enabling this option may incur a significant performance overhead. |
52 | |||
53 | config XEN_DEBUG | ||
54 | bool "Enable Xen debug checks" | ||
55 | depends on XEN | ||
56 | default n | ||
57 | help | ||
58 | Enable various WARN_ON checks in the Xen MMU code. | ||
59 | Enabling this option WILL incur a significant performance overhead. | ||
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index f987bde77c4..3c9aecd09ed 100644 --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c | |||
@@ -495,41 +495,6 @@ static pte_t xen_make_pte(pteval_t pte) | |||
495 | } | 495 | } |
496 | PV_CALLEE_SAVE_REGS_THUNK(xen_make_pte); | 496 | PV_CALLEE_SAVE_REGS_THUNK(xen_make_pte); |
497 | 497 | ||
498 | #ifdef CONFIG_XEN_DEBUG | ||
499 | pte_t xen_make_pte_debug(pteval_t pte) | ||
500 | { | ||
501 | phys_addr_t addr = (pte & PTE_PFN_MASK); | ||
502 | phys_addr_t other_addr; | ||
503 | bool io_page = false; | ||
504 | pte_t _pte; | ||
505 | |||
506 | if (pte & _PAGE_IOMAP) | ||
507 | io_page = true; | ||
508 | |||
509 | _pte = xen_make_pte(pte); | ||
510 | |||
511 | if (!addr) | ||
512 | return _pte; | ||
513 | |||
514 | if (io_page && | ||
515 | (xen_initial_domain() || addr >= ISA_END_ADDRESS)) { | ||
516 | other_addr = pfn_to_mfn(addr >> PAGE_SHIFT) << PAGE_SHIFT; | ||
517 | WARN_ONCE(addr != other_addr, | ||
518 | "0x%lx is using VM_IO, but it is 0x%lx!\n", | ||
519 | (unsigned long)addr, (unsigned long)other_addr); | ||
520 | } else { | ||
521 | pteval_t iomap_set = (_pte.pte & PTE_FLAGS_MASK) & _PAGE_IOMAP; | ||
522 | other_addr = (_pte.pte & PTE_PFN_MASK); | ||
523 | WARN_ONCE((addr == other_addr) && (!io_page) && (!iomap_set), | ||
524 | "0x%lx is missing VM_IO (and wasn't fixed)!\n", | ||
525 | (unsigned long)addr); | ||
526 | } | ||
527 | |||
528 | return _pte; | ||
529 | } | ||
530 | PV_CALLEE_SAVE_REGS_THUNK(xen_make_pte_debug); | ||
531 | #endif | ||
532 | |||
533 | static pgd_t xen_make_pgd(pgdval_t pgd) | 498 | static pgd_t xen_make_pgd(pgdval_t pgd) |
534 | { | 499 | { |
535 | pgd = pte_pfn_to_mfn(pgd); | 500 | pgd = pte_pfn_to_mfn(pgd); |
@@ -1988,9 +1953,6 @@ void __init xen_ident_map_ISA(void) | |||
1988 | 1953 | ||
1989 | static void __init xen_post_allocator_init(void) | 1954 | static void __init xen_post_allocator_init(void) |
1990 | { | 1955 | { |
1991 | #ifdef CONFIG_XEN_DEBUG | ||
1992 | pv_mmu_ops.make_pte = PV_CALLEE_SAVE(xen_make_pte_debug); | ||
1993 | #endif | ||
1994 | pv_mmu_ops.set_pte = xen_set_pte; | 1956 | pv_mmu_ops.set_pte = xen_set_pte; |
1995 | pv_mmu_ops.set_pmd = xen_set_pmd; | 1957 | pv_mmu_ops.set_pmd = xen_set_pmd; |
1996 | pv_mmu_ops.set_pud = xen_set_pud; | 1958 | pv_mmu_ops.set_pud = xen_set_pud; |