diff options
author | Luca Barbieri <luca@luca-barbieri.com> | 2010-03-01 13:55:49 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2010-03-01 14:39:03 -0500 |
commit | f3e83131469e29032a700217aa394996107b8fc5 (patch) | |
tree | 5f442f20148809121e977466fd0be4b59825fc2f /arch/x86/lib/atomic64_386_32.S | |
parent | 25a304f277ad70166eeae25a4958d2049005c33a (diff) |
x86-32: Fix atomic64_inc_not_zero return value convention
atomic64_inc_not_zero must return 1 if it perfomed the add and 0 otherwise.
It was doing the opposite thing.
Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-6-git-send-email-luca@luca-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/lib/atomic64_386_32.S')
-rw-r--r-- | arch/x86/lib/atomic64_386_32.S | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/x86/lib/atomic64_386_32.S b/arch/x86/lib/atomic64_386_32.S index a2f847c88b8..4a5979aa688 100644 --- a/arch/x86/lib/atomic64_386_32.S +++ b/arch/x86/lib/atomic64_386_32.S | |||
@@ -153,13 +153,12 @@ BEGIN inc_not_zero %esi | |||
153 | adcl $0, %edx | 153 | adcl $0, %edx |
154 | movl %eax, ($v) | 154 | movl %eax, ($v) |
155 | movl %edx, 4($v) | 155 | movl %edx, 4($v) |
156 | xorl %eax, %eax | 156 | movl $1, %eax |
157 | 2: | 157 | 2: |
158 | RETURN | 158 | RETURN |
159 | 3: | 159 | 3: |
160 | testl %edx, %edx | 160 | testl %edx, %edx |
161 | jne 1b | 161 | jne 1b |
162 | movl $1, %eax | ||
163 | jmp 2b | 162 | jmp 2b |
164 | END_ | 163 | END_ |
165 | 164 | ||