aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/kvm/x86.c
diff options
context:
space:
mode:
authorSheng Yang <sheng@linux.intel.com>2010-05-12 04:40:41 -0400
committerAvi Kivity <avi@redhat.com>2010-08-01 03:35:44 -0400
commit62ad07551a2ace89e35604d1c55fdae1dd3359a8 (patch)
treefa62d906a519406340b93f692f503655b2602b1c /arch/x86/kvm/x86.c
parent222b7c52c33bdef721248bfeba992af495800d30 (diff)
KVM: x86: Clean up duplicate assignment
mmu.free() already set root_hpa to INVALID_PAGE, no need to do it again in the destory_kvm_mmu(). kvm_x86_ops->set_cr4() and set_efer() already assign cr4/efer to vcpu->arch.cr4/efer, no need to do it again later. Signed-off-by: Sheng Yang <sheng@linux.intel.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'arch/x86/kvm/x86.c')
-rw-r--r--arch/x86/kvm/x86.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index ae9d6f3e5d0..03039fd8698 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -486,7 +486,7 @@ int __kvm_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4)
486 return 1; 486 return 1;
487 487
488 kvm_x86_ops->set_cr4(vcpu, cr4); 488 kvm_x86_ops->set_cr4(vcpu, cr4);
489 vcpu->arch.cr4 = cr4; 489
490 kvm_mmu_reset_context(vcpu); 490 kvm_mmu_reset_context(vcpu);
491 491
492 return 0; 492 return 0;
@@ -721,8 +721,6 @@ static int set_efer(struct kvm_vcpu *vcpu, u64 efer)
721 721
722 kvm_x86_ops->set_efer(vcpu, efer); 722 kvm_x86_ops->set_efer(vcpu, efer);
723 723
724 vcpu->arch.efer = efer;
725
726 vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled; 724 vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled;
727 kvm_mmu_reset_context(vcpu); 725 kvm_mmu_reset_context(vcpu);
728 726