diff options
author | David S. Miller <davem@davemloft.net> | 2012-04-17 16:08:29 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-04-17 16:08:29 -0400 |
commit | 7b56f76edf2da7ab3e356cc0db16f9af4c6a26e2 (patch) | |
tree | 655860580d081c983e643589e6f56cc1a01138f3 /arch/sparc/net/bpf_jit_asm.S | |
parent | b3d7b2f2f07ff0ab87442f2d499f2860ef59bfaa (diff) |
net: filter: Fix some minor issues in sparc JIT.
Correct conventions comments. %o4 and %o5 were swapped,
%g3 was not documented.
Use r_TMP instead of r_SKB_DATA + r_OFF where possible in
assembler stubs.
Correct discussion of %o4 and %o5 in one of bpf_jit_compile()'s
comments.
Based upon feedback from Richard Mortimer.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/net/bpf_jit_asm.S')
-rw-r--r-- | arch/sparc/net/bpf_jit_asm.S | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/sparc/net/bpf_jit_asm.S b/arch/sparc/net/bpf_jit_asm.S index fdc69324aab..46d8f59f14c 100644 --- a/arch/sparc/net/bpf_jit_asm.S +++ b/arch/sparc/net/bpf_jit_asm.S | |||
@@ -30,7 +30,7 @@ bpf_jit_load_word_positive_offset: | |||
30 | bne load_word_unaligned | 30 | bne load_word_unaligned |
31 | nop | 31 | nop |
32 | retl | 32 | retl |
33 | ld [r_SKB_DATA + r_OFF], r_A | 33 | ld [r_TMP], r_A |
34 | load_word_unaligned: | 34 | load_word_unaligned: |
35 | ldub [r_TMP + 0x0], r_OFF | 35 | ldub [r_TMP + 0x0], r_OFF |
36 | ldub [r_TMP + 0x1], r_TMP2 | 36 | ldub [r_TMP + 0x1], r_TMP2 |
@@ -59,7 +59,7 @@ bpf_jit_load_half_positive_offset: | |||
59 | bne load_half_unaligned | 59 | bne load_half_unaligned |
60 | nop | 60 | nop |
61 | retl | 61 | retl |
62 | lduh [r_SKB_DATA + r_OFF], r_A | 62 | lduh [r_TMP], r_A |
63 | load_half_unaligned: | 63 | load_half_unaligned: |
64 | ldub [r_TMP + 0x0], r_OFF | 64 | ldub [r_TMP + 0x0], r_OFF |
65 | ldub [r_TMP + 0x1], r_TMP2 | 65 | ldub [r_TMP + 0x1], r_TMP2 |