diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-11-03 16:30:25 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-11-14 14:55:39 -0500 |
commit | f3ec3bf527638b8efb576d1bdbaf8d66d1183f92 (patch) | |
tree | 13c2bdc78c7c13f8c92d5b97a2d31a1ae4341d2c | |
parent | 36f318bb124b231c01db6965a009f46d5731f012 (diff) |
drivers/net/wireless/ath/ath6kl/hif.c: drop if around WARN_ON
Just use WARN_ON rather than an if containing only WARN_ON(1).
A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
- if (e) WARN_ON(1);
+ WARN_ON(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/ath/ath6kl/hif.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c index 68ed6c2665b..9e47c4a138a 100644 --- a/drivers/net/wireless/ath/ath6kl/hif.c +++ b/drivers/net/wireless/ath/ath6kl/hif.c | |||
@@ -338,8 +338,7 @@ static int ath6kl_hif_proc_err_intr(struct ath6kl_device *dev) | |||
338 | status = hif_read_write_sync(dev->ar, ERROR_INT_STATUS_ADDRESS, | 338 | status = hif_read_write_sync(dev->ar, ERROR_INT_STATUS_ADDRESS, |
339 | reg_buf, 4, HIF_WR_SYNC_BYTE_FIX); | 339 | reg_buf, 4, HIF_WR_SYNC_BYTE_FIX); |
340 | 340 | ||
341 | if (status) | 341 | WARN_ON(status); |
342 | WARN_ON(1); | ||
343 | 342 | ||
344 | return status; | 343 | return status; |
345 | } | 344 | } |
@@ -383,8 +382,7 @@ static int ath6kl_hif_proc_cpu_intr(struct ath6kl_device *dev) | |||
383 | status = hif_read_write_sync(dev->ar, CPU_INT_STATUS_ADDRESS, | 382 | status = hif_read_write_sync(dev->ar, CPU_INT_STATUS_ADDRESS, |
384 | reg_buf, 4, HIF_WR_SYNC_BYTE_FIX); | 383 | reg_buf, 4, HIF_WR_SYNC_BYTE_FIX); |
385 | 384 | ||
386 | if (status) | 385 | WARN_ON(status); |
387 | WARN_ON(1); | ||
388 | 386 | ||
389 | return status; | 387 | return status; |
390 | } | 388 | } |