diff options
author | H Hartley Sweeten <hartleys@visionengravers.com> | 2012-04-27 19:27:20 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-29 21:42:51 -0400 |
commit | f21a38c453411660e85f9e68af4c20322021f941 (patch) | |
tree | a18f95a652ca591542cbd50ec656b26b0a761234 | |
parent | ccc66e0a06a08a2858bf81a334ee71e295ff8b7a (diff) |
staging: comedi: refactor pcl725 driver to remove forward declarations
Move the module_init/module_exit routines and the associated
struct comedi_driver and other variables to the end of the source.
This is more typical of how other drivers are written and removes
the need for the forward declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/comedi/drivers/pcl725.c | 42 |
1 files changed, 19 insertions, 23 deletions
diff --git a/drivers/staging/comedi/drivers/pcl725.c b/drivers/staging/comedi/drivers/pcl725.c index 24b223ca439..4b761a67ac1 100644 --- a/drivers/staging/comedi/drivers/pcl725.c +++ b/drivers/staging/comedi/drivers/pcl725.c | |||
@@ -20,29 +20,6 @@ Devices: [Advantech] PCL-725 (pcl725) | |||
20 | #define PCL725_DO 0 | 20 | #define PCL725_DO 0 |
21 | #define PCL725_DI 1 | 21 | #define PCL725_DI 1 |
22 | 22 | ||
23 | static int pcl725_attach(struct comedi_device *dev, | ||
24 | struct comedi_devconfig *it); | ||
25 | static int pcl725_detach(struct comedi_device *dev); | ||
26 | static struct comedi_driver driver_pcl725 = { | ||
27 | .driver_name = "pcl725", | ||
28 | .module = THIS_MODULE, | ||
29 | .attach = pcl725_attach, | ||
30 | .detach = pcl725_detach, | ||
31 | }; | ||
32 | |||
33 | static int __init driver_pcl725_init_module(void) | ||
34 | { | ||
35 | return comedi_driver_register(&driver_pcl725); | ||
36 | } | ||
37 | |||
38 | static void __exit driver_pcl725_cleanup_module(void) | ||
39 | { | ||
40 | comedi_driver_unregister(&driver_pcl725); | ||
41 | } | ||
42 | |||
43 | module_init(driver_pcl725_init_module); | ||
44 | module_exit(driver_pcl725_cleanup_module); | ||
45 | |||
46 | static int pcl725_do_insn(struct comedi_device *dev, struct comedi_subdevice *s, | 23 | static int pcl725_do_insn(struct comedi_device *dev, struct comedi_subdevice *s, |
47 | struct comedi_insn *insn, unsigned int *data) | 24 | struct comedi_insn *insn, unsigned int *data) |
48 | { | 25 | { |
@@ -122,6 +99,25 @@ static int pcl725_detach(struct comedi_device *dev) | |||
122 | return 0; | 99 | return 0; |
123 | } | 100 | } |
124 | 101 | ||
102 | static struct comedi_driver driver_pcl725 = { | ||
103 | .driver_name = "pcl725", | ||
104 | .module = THIS_MODULE, | ||
105 | .attach = pcl725_attach, | ||
106 | .detach = pcl725_detach, | ||
107 | }; | ||
108 | |||
109 | static int __init driver_pcl725_init_module(void) | ||
110 | { | ||
111 | return comedi_driver_register(&driver_pcl725); | ||
112 | } | ||
113 | module_init(driver_pcl725_init_module); | ||
114 | |||
115 | static void __exit driver_pcl725_cleanup_module(void) | ||
116 | { | ||
117 | comedi_driver_unregister(&driver_pcl725); | ||
118 | } | ||
119 | module_exit(driver_pcl725_cleanup_module); | ||
120 | |||
125 | MODULE_AUTHOR("Comedi http://www.comedi.org"); | 121 | MODULE_AUTHOR("Comedi http://www.comedi.org"); |
126 | MODULE_DESCRIPTION("Comedi low-level driver"); | 122 | MODULE_DESCRIPTION("Comedi low-level driver"); |
127 | MODULE_LICENSE("GPL"); | 123 | MODULE_LICENSE("GPL"); |