aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChuck Lever <cel@netapp.com>2005-08-25 19:25:53 -0400
committerTrond Myklebust <Trond.Myklebust@netapp.com>2005-09-23 12:38:47 -0400
commited63c003701a314c4893c11eceb9d68f8f46c662 (patch)
treec0567884d9cce53960061fece0ae9c2eabd0af77
parenta58dd398f5db4f73d5c581069fd70a4304cc4f0a (diff)
[PATCH] RPC: remove xprt->nocong
Get rid of the "xprt->nocong" variable. Test-plan: Use WAN simulation to cause sporadic bursty packet loss with UDP mounts. Look for significant regression in performance or client stability. Signed-off-by: Chuck Lever <cel@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r--fs/lockd/host.c1
-rw-r--r--include/linux/sunrpc/xprt.h1
-rw-r--r--net/sunrpc/xprtsock.c2
3 files changed, 0 insertions, 4 deletions
diff --git a/fs/lockd/host.c b/fs/lockd/host.c
index 7901f5b8092..c4c8601096e 100644
--- a/fs/lockd/host.c
+++ b/fs/lockd/host.c
@@ -188,7 +188,6 @@ nlm_bind_host(struct nlm_host *host)
188 goto forgetit; 188 goto forgetit;
189 189
190 xprt_set_timeout(&xprt->timeout, 5, nlmsvc_timeout); 190 xprt_set_timeout(&xprt->timeout, 5, nlmsvc_timeout);
191 xprt->nocong = 1; /* No congestion control for NLM */
192 xprt->resvport = 1; /* NLM requires a reserved port */ 191 xprt->resvport = 1; /* NLM requires a reserved port */
193 192
194 /* Existing NLM servers accept AUTH_UNIX only */ 193 /* Existing NLM servers accept AUTH_UNIX only */
diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h
index 64e77658fa3..559fb471f6f 100644
--- a/include/linux/sunrpc/xprt.h
+++ b/include/linux/sunrpc/xprt.h
@@ -172,7 +172,6 @@ struct rpc_xprt {
172 unsigned int max_reqs; /* total slots */ 172 unsigned int max_reqs; /* total slots */
173 unsigned long state; /* transport state */ 173 unsigned long state; /* transport state */
174 unsigned char shutdown : 1, /* being shut down */ 174 unsigned char shutdown : 1, /* being shut down */
175 nocong : 1, /* no congestion control */
176 resvport : 1; /* use a reserved port */ 175 resvport : 1; /* use a reserved port */
177 176
178 /* 177 /*
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 6c2f5dcea41..7e5e020fe78 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -1100,7 +1100,6 @@ int xs_setup_udp(struct rpc_xprt *xprt, struct rpc_timeout *to)
1100 xprt->prot = IPPROTO_UDP; 1100 xprt->prot = IPPROTO_UDP;
1101 xprt->port = XS_MAX_RESVPORT; 1101 xprt->port = XS_MAX_RESVPORT;
1102 xprt->tsh_size = 0; 1102 xprt->tsh_size = 0;
1103 xprt->nocong = 0;
1104 xprt->cwnd = RPC_INITCWND; 1103 xprt->cwnd = RPC_INITCWND;
1105 xprt->resvport = capable(CAP_NET_BIND_SERVICE) ? 1 : 0; 1104 xprt->resvport = capable(CAP_NET_BIND_SERVICE) ? 1 : 0;
1106 /* XXX: header size can vary due to auth type, IPv6, etc. */ 1105 /* XXX: header size can vary due to auth type, IPv6, etc. */
@@ -1140,7 +1139,6 @@ int xs_setup_tcp(struct rpc_xprt *xprt, struct rpc_timeout *to)
1140 xprt->prot = IPPROTO_TCP; 1139 xprt->prot = IPPROTO_TCP;
1141 xprt->port = XS_MAX_RESVPORT; 1140 xprt->port = XS_MAX_RESVPORT;
1142 xprt->tsh_size = sizeof(rpc_fraghdr) / sizeof(u32); 1141 xprt->tsh_size = sizeof(rpc_fraghdr) / sizeof(u32);
1143 xprt->nocong = 1;
1144 xprt->cwnd = RPC_MAXCWND(xprt); 1142 xprt->cwnd = RPC_MAXCWND(xprt);
1145 xprt->resvport = capable(CAP_NET_BIND_SERVICE) ? 1 : 0; 1143 xprt->resvport = capable(CAP_NET_BIND_SERVICE) ? 1 : 0;
1146 xprt->max_payload = RPC_MAX_FRAGMENT_SIZE; 1144 xprt->max_payload = RPC_MAX_FRAGMENT_SIZE;