aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Meyer <thomas@m3y3r.de>2011-12-02 07:35:43 -0500
committerDavid S. Miller <davem@davemloft.net>2011-12-04 01:32:06 -0500
commitddf98e6d30a966dbd6e675c90e2caa5b9486e519 (patch)
tree65b3c690bcbbe1a500b835b6776e0d895effe392
parenta1de22191bc4c47ff50ef3274295f4384074696b (diff)
ll_temac: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/xilinx/ll_temac_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 282330d9801..903a77b416d 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev)
237 struct sk_buff *skb; 237 struct sk_buff *skb;
238 int i; 238 int i;
239 239
240 lp->rx_skb = kzalloc(sizeof(*lp->rx_skb) * RX_BD_NUM, GFP_KERNEL); 240 lp->rx_skb = kcalloc(RX_BD_NUM, sizeof(*lp->rx_skb), GFP_KERNEL);
241 if (!lp->rx_skb) { 241 if (!lp->rx_skb) {
242 dev_err(&ndev->dev, 242 dev_err(&ndev->dev,
243 "can't allocate memory for DMA RX buffer\n"); 243 "can't allocate memory for DMA RX buffer\n");