aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYong Zhang <yong.zhang0@gmail.com>2011-10-22 05:56:28 -0400
committerPaul Mundt <lethal@linux-sh.org>2011-10-28 01:39:28 -0400
commitd11584a0449f881181dc94dd697d3f3896c15c73 (patch)
tree0ca8ec496e6ba3a5ae687b8ba4cea5f55cc5bec2
parentc63bcc6ff135397b38cdb510c173e4a6629cede5 (diff)
SH: irq: Remove IRQF_DISABLED
Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled], We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]). So now this flag is a NOOP and can be removed. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
-rw-r--r--arch/sh/boards/board-secureedge5410.c3
-rw-r--r--arch/sh/boards/mach-cayman/irq.c2
-rw-r--r--arch/sh/boards/mach-hp6xx/hp6xx_apm.c2
-rw-r--r--arch/sh/drivers/dma/dma-g2.c2
-rw-r--r--arch/sh/drivers/dma/dma-pvr2.c1
-rw-r--r--arch/sh/drivers/dma/dma-sh.c4
-rw-r--r--arch/sh/drivers/dma/dmabrg.c6
-rw-r--r--arch/sh/drivers/pci/pci-sh5.c4
-rw-r--r--arch/sh/drivers/pci/pci-sh7780.c2
-rw-r--r--arch/sh/drivers/push-switch.c2
-rw-r--r--arch/sh/kernel/cpu/sh4a/smp-shx3.c2
11 files changed, 13 insertions, 17 deletions
diff --git a/arch/sh/boards/board-secureedge5410.c b/arch/sh/boards/board-secureedge5410.c
index f968f17891a..03820c3c93d 100644
--- a/arch/sh/boards/board-secureedge5410.c
+++ b/arch/sh/boards/board-secureedge5410.c
@@ -41,8 +41,7 @@ static int __init eraseconfig_init(void)
41 printk("SnapGear: EraseConfig init\n"); 41 printk("SnapGear: EraseConfig init\n");
42 42
43 /* Setup "EraseConfig" switch on external IRQ 0 */ 43 /* Setup "EraseConfig" switch on external IRQ 0 */
44 if (request_irq(irq, eraseconfig_interrupt, IRQF_DISABLED, 44 if (request_irq(irq, eraseconfig_interrupt, 0, "Erase Config", NULL))
45 "Erase Config", NULL))
46 printk("SnapGear: failed to register IRQ%d for Reset witch\n", 45 printk("SnapGear: failed to register IRQ%d for Reset witch\n",
47 irq); 46 irq);
48 else 47 else
diff --git a/arch/sh/boards/mach-cayman/irq.c b/arch/sh/boards/mach-cayman/irq.c
index 311bcebdbd0..724e8b7271f 100644
--- a/arch/sh/boards/mach-cayman/irq.c
+++ b/arch/sh/boards/mach-cayman/irq.c
@@ -46,13 +46,11 @@ static irqreturn_t cayman_interrupt_pci2(int irq, void *dev_id)
46static struct irqaction cayman_action_smsc = { 46static struct irqaction cayman_action_smsc = {
47 .name = "Cayman SMSC Mux", 47 .name = "Cayman SMSC Mux",
48 .handler = cayman_interrupt_smsc, 48 .handler = cayman_interrupt_smsc,
49 .flags = IRQF_DISABLED,
50}; 49};
51 50
52static struct irqaction cayman_action_pci2 = { 51static struct irqaction cayman_action_pci2 = {
53 .name = "Cayman PCI2 Mux", 52 .name = "Cayman PCI2 Mux",
54 .handler = cayman_interrupt_pci2, 53 .handler = cayman_interrupt_pci2,
55 .flags = IRQF_DISABLED,
56}; 54};
57 55
58static void enable_cayman_irq(struct irq_data *data) 56static void enable_cayman_irq(struct irq_data *data)
diff --git a/arch/sh/boards/mach-hp6xx/hp6xx_apm.c b/arch/sh/boards/mach-hp6xx/hp6xx_apm.c
index b49535c0ddd..865d8d6e823 100644
--- a/arch/sh/boards/mach-hp6xx/hp6xx_apm.c
+++ b/arch/sh/boards/mach-hp6xx/hp6xx_apm.c
@@ -86,7 +86,7 @@ static int __init hp6x0_apm_init(void)
86 int ret; 86 int ret;
87 87
88 ret = request_irq(HP680_BTN_IRQ, hp6x0_apm_interrupt, 88 ret = request_irq(HP680_BTN_IRQ, hp6x0_apm_interrupt,
89 IRQF_DISABLED, MODNAME, NULL); 89 0, MODNAME, NULL);
90 if (unlikely(ret < 0)) { 90 if (unlikely(ret < 0)) {
91 printk(KERN_ERR MODNAME ": IRQ %d request failed\n", 91 printk(KERN_ERR MODNAME ": IRQ %d request failed\n",
92 HP680_BTN_IRQ); 92 HP680_BTN_IRQ);
diff --git a/arch/sh/drivers/dma/dma-g2.c b/arch/sh/drivers/dma/dma-g2.c
index af7bb589c2c..be9ca7ca0ce 100644
--- a/arch/sh/drivers/dma/dma-g2.c
+++ b/arch/sh/drivers/dma/dma-g2.c
@@ -170,7 +170,7 @@ static int __init g2_dma_init(void)
170{ 170{
171 int ret; 171 int ret;
172 172
173 ret = request_irq(HW_EVENT_G2_DMA, g2_dma_interrupt, IRQF_DISABLED, 173 ret = request_irq(HW_EVENT_G2_DMA, g2_dma_interrupt, 0,
174 "g2 DMA handler", &g2_dma_info); 174 "g2 DMA handler", &g2_dma_info);
175 if (unlikely(ret)) 175 if (unlikely(ret))
176 return -EINVAL; 176 return -EINVAL;
diff --git a/arch/sh/drivers/dma/dma-pvr2.c b/arch/sh/drivers/dma/dma-pvr2.c
index 3cee58e7f1e..706a3434af7 100644
--- a/arch/sh/drivers/dma/dma-pvr2.c
+++ b/arch/sh/drivers/dma/dma-pvr2.c
@@ -70,7 +70,6 @@ static int pvr2_xfer_dma(struct dma_channel *chan)
70static struct irqaction pvr2_dma_irq = { 70static struct irqaction pvr2_dma_irq = {
71 .name = "pvr2 DMA handler", 71 .name = "pvr2 DMA handler",
72 .handler = pvr2_dma_interrupt, 72 .handler = pvr2_dma_interrupt,
73 .flags = IRQF_DISABLED,
74}; 73};
75 74
76static struct dma_ops pvr2_dma_ops = { 75static struct dma_ops pvr2_dma_ops = {
diff --git a/arch/sh/drivers/dma/dma-sh.c b/arch/sh/drivers/dma/dma-sh.c
index 827208781ed..a60da6dd4d1 100644
--- a/arch/sh/drivers/dma/dma-sh.c
+++ b/arch/sh/drivers/dma/dma-sh.c
@@ -95,7 +95,7 @@ static int sh_dmac_request_dma(struct dma_channel *chan)
95#if defined(CONFIG_SH_DMA_IRQ_MULTI) 95#if defined(CONFIG_SH_DMA_IRQ_MULTI)
96 IRQF_SHARED, 96 IRQF_SHARED,
97#else 97#else
98 IRQF_DISABLED, 98 0,
99#endif 99#endif
100 chan->dev_id, chan); 100 chan->dev_id, chan);
101} 101}
@@ -305,7 +305,7 @@ static int __init sh_dmac_init(void)
305#if defined(CONFIG_SH_DMA_IRQ_MULTI) 305#if defined(CONFIG_SH_DMA_IRQ_MULTI)
306 IRQF_SHARED, 306 IRQF_SHARED,
307#else 307#else
308 IRQF_DISABLED, 308 0,
309#endif 309#endif
310 dmae_name[n], (void *)dmae_name[n]); 310 dmae_name[n], (void *)dmae_name[n]);
311 if (unlikely(i < 0)) { 311 if (unlikely(i < 0)) {
diff --git a/arch/sh/drivers/dma/dmabrg.c b/arch/sh/drivers/dma/dmabrg.c
index 6ab9c4a1543..3d66a32ce61 100644
--- a/arch/sh/drivers/dma/dmabrg.c
+++ b/arch/sh/drivers/dma/dmabrg.c
@@ -174,17 +174,17 @@ static int __init dmabrg_init(void)
174 or = __raw_readl(DMAOR); 174 or = __raw_readl(DMAOR);
175 __raw_writel(or | DMAOR_BRG | DMAOR_DMEN, DMAOR); 175 __raw_writel(or | DMAOR_BRG | DMAOR_DMEN, DMAOR);
176 176
177 ret = request_irq(DMABRGI0, dmabrg_irq, IRQF_DISABLED, 177 ret = request_irq(DMABRGI0, dmabrg_irq, 0,
178 "DMABRG USB address error", NULL); 178 "DMABRG USB address error", NULL);
179 if (ret) 179 if (ret)
180 goto out0; 180 goto out0;
181 181
182 ret = request_irq(DMABRGI1, dmabrg_irq, IRQF_DISABLED, 182 ret = request_irq(DMABRGI1, dmabrg_irq, 0,
183 "DMABRG Transfer End", NULL); 183 "DMABRG Transfer End", NULL);
184 if (ret) 184 if (ret)
185 goto out1; 185 goto out1;
186 186
187 ret = request_irq(DMABRGI2, dmabrg_irq, IRQF_DISABLED, 187 ret = request_irq(DMABRGI2, dmabrg_irq, 0,
188 "DMABRG Transfer Half", NULL); 188 "DMABRG Transfer Half", NULL);
189 if (ret == 0) 189 if (ret == 0)
190 return ret; 190 return ret;
diff --git a/arch/sh/drivers/pci/pci-sh5.c b/arch/sh/drivers/pci/pci-sh5.c
index 0bf296c7879..16c1e721bf5 100644
--- a/arch/sh/drivers/pci/pci-sh5.c
+++ b/arch/sh/drivers/pci/pci-sh5.c
@@ -107,13 +107,13 @@ static int __init sh5pci_init(void)
107 u32 uval; 107 u32 uval;
108 108
109 if (request_irq(IRQ_ERR, pcish5_err_irq, 109 if (request_irq(IRQ_ERR, pcish5_err_irq,
110 IRQF_DISABLED, "PCI Error",NULL) < 0) { 110 0, "PCI Error",NULL) < 0) {
111 printk(KERN_ERR "PCISH5: Cannot hook PCI_PERR interrupt\n"); 111 printk(KERN_ERR "PCISH5: Cannot hook PCI_PERR interrupt\n");
112 return -EINVAL; 112 return -EINVAL;
113 } 113 }
114 114
115 if (request_irq(IRQ_SERR, pcish5_serr_irq, 115 if (request_irq(IRQ_SERR, pcish5_serr_irq,
116 IRQF_DISABLED, "PCI SERR interrupt", NULL) < 0) { 116 0, "PCI SERR interrupt", NULL) < 0) {
117 printk(KERN_ERR "PCISH5: Cannot hook PCI_SERR interrupt\n"); 117 printk(KERN_ERR "PCISH5: Cannot hook PCI_SERR interrupt\n");
118 return -EINVAL; 118 return -EINVAL;
119 } 119 }
diff --git a/arch/sh/drivers/pci/pci-sh7780.c b/arch/sh/drivers/pci/pci-sh7780.c
index edb7cca1488..fa7b978cc72 100644
--- a/arch/sh/drivers/pci/pci-sh7780.c
+++ b/arch/sh/drivers/pci/pci-sh7780.c
@@ -172,7 +172,7 @@ static int __init sh7780_pci_setup_irqs(struct pci_channel *hose)
172 PCI_STATUS_SIG_TARGET_ABORT | \ 172 PCI_STATUS_SIG_TARGET_ABORT | \
173 PCI_STATUS_PARITY, hose->reg_base + PCI_STATUS); 173 PCI_STATUS_PARITY, hose->reg_base + PCI_STATUS);
174 174
175 ret = request_irq(hose->serr_irq, sh7780_pci_serr_irq, IRQF_DISABLED, 175 ret = request_irq(hose->serr_irq, sh7780_pci_serr_irq, 0,
176 "PCI SERR interrupt", hose); 176 "PCI SERR interrupt", hose);
177 if (unlikely(ret)) { 177 if (unlikely(ret)) {
178 printk(KERN_ERR "PCI: Failed hooking SERR IRQ\n"); 178 printk(KERN_ERR "PCI: Failed hooking SERR IRQ\n");
diff --git a/arch/sh/drivers/push-switch.c b/arch/sh/drivers/push-switch.c
index afc24556572..637b79b0965 100644
--- a/arch/sh/drivers/push-switch.c
+++ b/arch/sh/drivers/push-switch.c
@@ -63,7 +63,7 @@ static int switch_drv_probe(struct platform_device *pdev)
63 BUG_ON(!psw_info); 63 BUG_ON(!psw_info);
64 64
65 ret = request_irq(irq, psw_info->irq_handler, 65 ret = request_irq(irq, psw_info->irq_handler,
66 IRQF_DISABLED | psw_info->irq_flags, 66 psw_info->irq_flags,
67 psw_info->name ? psw_info->name : DRV_NAME, pdev); 67 psw_info->name ? psw_info->name : DRV_NAME, pdev);
68 if (unlikely(ret < 0)) 68 if (unlikely(ret < 0))
69 goto err; 69 goto err;
diff --git a/arch/sh/kernel/cpu/sh4a/smp-shx3.c b/arch/sh/kernel/cpu/sh4a/smp-shx3.c
index de865cac02e..03f2b55757c 100644
--- a/arch/sh/kernel/cpu/sh4a/smp-shx3.c
+++ b/arch/sh/kernel/cpu/sh4a/smp-shx3.c
@@ -79,7 +79,7 @@ static void shx3_prepare_cpus(unsigned int max_cpus)
79 79
80 for (i = 0; i < SMP_MSG_NR; i++) 80 for (i = 0; i < SMP_MSG_NR; i++)
81 request_irq(104 + i, ipi_interrupt_handler, 81 request_irq(104 + i, ipi_interrupt_handler,
82 IRQF_DISABLED | IRQF_PERCPU, "IPI", (void *)(long)i); 82 IRQF_PERCPU, "IPI", (void *)(long)i);
83 83
84 for (i = 0; i < max_cpus; i++) 84 for (i = 0; i < max_cpus; i++)
85 set_cpu_present(i, true); 85 set_cpu_present(i, true);