diff options
author | Tomas Winkler <tomas.winkler@intel.com> | 2011-02-10 07:55:23 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-02-18 15:40:00 -0500 |
commit | ccb6d2e5dc37605503d0a3182dbb27981f90df94 (patch) | |
tree | f46ff11af11b2bc4080e5bb204114e1163fcb128 | |
parent | 72075789ea6eba8b67516c5fc7e5c12fa1dac1c3 (diff) |
staging/easycap: don't mask return value of usb_control_msg() by 0xFF
masking return value of usb_control_msg() will mask negative
error values into positive.
Cc: Mike Thomas <rmthomas@sciolus.org>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/staging/easycap/easycap_low.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/easycap/easycap_low.c b/drivers/staging/easycap/easycap_low.c index 7b2de10bc68..5c41a27a683 100644 --- a/drivers/staging/easycap/easycap_low.c +++ b/drivers/staging/easycap/easycap_low.c | |||
@@ -270,7 +270,7 @@ static int regget(struct usb_device *pusb_device, | |||
270 | 0x00, | 270 | 0x00, |
271 | index, reg, reg_size, 50000); | 271 | index, reg, reg_size, 50000); |
272 | 272 | ||
273 | return 0xFF & rc; | 273 | return rc; |
274 | } | 274 | } |
275 | 275 | ||
276 | static int regset(struct usb_device *pusb_device, u16 index, u16 value) | 276 | static int regset(struct usb_device *pusb_device, u16 index, u16 value) |