aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarcos Paulo de Souza <marcos.souza.org@gmail.com>2012-11-06 18:11:12 -0500
committerAnton Vorontsov <anton.vorontsov@linaro.org>2012-11-18 19:10:45 -0500
commit9790f98fdcfb1c60b953973ae256d00857b5ebb7 (patch)
treed07c4b7b0e3d6748a7276c83103dcc580fb21546
parentec073c9b319fee6564dcb9f1fb7a70eb6a8a06b5 (diff)
jz4740-battery: Use devm_request_and_ioremap
No functional changes. Just a cleanup. Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
-rw-r--r--drivers/power/jz4740-battery.c33
1 files changed, 6 insertions, 27 deletions
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 529d22abe0e..fc7550d4d56 100644
--- a/drivers/power/jz4740-battery.c
+++ b/drivers/power/jz4740-battery.c
@@ -33,7 +33,6 @@ struct jz_battery {
33 struct jz_battery_platform_data *pdata; 33 struct jz_battery_platform_data *pdata;
34 struct platform_device *pdev; 34 struct platform_device *pdev;
35 35
36 struct resource *mem;
37 void __iomem *base; 36 void __iomem *base;
38 37
39 int irq; 38 int irq;
@@ -244,6 +243,7 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
244 struct jz_battery_platform_data *pdata = pdev->dev.parent->platform_data; 243 struct jz_battery_platform_data *pdata = pdev->dev.parent->platform_data;
245 struct jz_battery *jz_battery; 244 struct jz_battery *jz_battery;
246 struct power_supply *battery; 245 struct power_supply *battery;
246 struct resource *mem;
247 247
248 if (!pdata) { 248 if (!pdata) {
249 dev_err(&pdev->dev, "No platform_data supplied\n"); 249 dev_err(&pdev->dev, "No platform_data supplied\n");
@@ -264,26 +264,11 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
264 return jz_battery->irq; 264 return jz_battery->irq;
265 } 265 }
266 266
267 jz_battery->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); 267 mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
268 if (!jz_battery->mem) {
269 dev_err(&pdev->dev, "Failed to get platform mmio resource\n");
270 return -ENOENT;
271 }
272 268
273 jz_battery->mem = request_mem_region(jz_battery->mem->start, 269 jz_battery->base = devm_request_and_ioremap(&pdev->dev, mem);
274 resource_size(jz_battery->mem), pdev->name); 270 if (!jz_battery->base)
275 if (!jz_battery->mem) {
276 dev_err(&pdev->dev, "Failed to request mmio memory region\n");
277 return -EBUSY; 271 return -EBUSY;
278 }
279
280 jz_battery->base = ioremap_nocache(jz_battery->mem->start,
281 resource_size(jz_battery->mem));
282 if (!jz_battery->base) {
283 ret = -EBUSY;
284 dev_err(&pdev->dev, "Failed to ioremap mmio memory\n");
285 goto err_release_mem_region;
286 }
287 272
288 battery = &jz_battery->battery; 273 battery = &jz_battery->battery;
289 battery->name = pdata->info.name; 274 battery->name = pdata->info.name;
@@ -306,7 +291,7 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
306 jz_battery); 291 jz_battery);
307 if (ret) { 292 if (ret) {
308 dev_err(&pdev->dev, "Failed to request irq %d\n", ret); 293 dev_err(&pdev->dev, "Failed to request irq %d\n", ret);
309 goto err_iounmap; 294 goto err;
310 } 295 }
311 disable_irq(jz_battery->irq); 296 disable_irq(jz_battery->irq);
312 297
@@ -363,11 +348,8 @@ err_free_gpio:
363 gpio_free(jz_battery->pdata->gpio_charge); 348 gpio_free(jz_battery->pdata->gpio_charge);
364err_free_irq: 349err_free_irq:
365 free_irq(jz_battery->irq, jz_battery); 350 free_irq(jz_battery->irq, jz_battery);
366err_iounmap: 351err:
367 platform_set_drvdata(pdev, NULL); 352 platform_set_drvdata(pdev, NULL);
368 iounmap(jz_battery->base);
369err_release_mem_region:
370 release_mem_region(jz_battery->mem->start, resource_size(jz_battery->mem));
371 return ret; 353 return ret;
372} 354}
373 355
@@ -387,9 +369,6 @@ static int __devexit jz_battery_remove(struct platform_device *pdev)
387 369
388 free_irq(jz_battery->irq, jz_battery); 370 free_irq(jz_battery->irq, jz_battery);
389 371
390 iounmap(jz_battery->base);
391 release_mem_region(jz_battery->mem->start, resource_size(jz_battery->mem));
392
393 return 0; 372 return 0;
394} 373}
395 374