diff options
author | Vasiliy Kulikov <segooon@gmail.com> | 2010-10-03 13:22:48 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-10-05 14:42:20 -0400 |
commit | 86ee1e49cf8bd07d4e849be8f056c6bc179686b8 (patch) | |
tree | 0a55aeb8db9c6522069acd2c76b8e992db6d2ceb | |
parent | b7378b9ed641b9e39f613d22c762a8ac2a15b8b8 (diff) |
staging: ft1000: fix kernel info leak to userland for statistics
get_stat_data is not fully initialized before copy_to_user() call,
e.g. LedStat is not always set.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c index 46e72e4b91f..3325e876539 100644 --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | |||
@@ -616,7 +616,7 @@ static long ft1000_ChIoctl (struct file *File, unsigned int Command, | |||
616 | break; | 616 | break; |
617 | case IOCTL_GET_DSP_STAT_CMD: | 617 | case IOCTL_GET_DSP_STAT_CMD: |
618 | //DEBUG("FT1000:ft1000_ChIoctl: IOCTL_FT1000_GET_DSP_STAT called\n"); | 618 | //DEBUG("FT1000:ft1000_ChIoctl: IOCTL_FT1000_GET_DSP_STAT called\n"); |
619 | 619 | memset(&get_stat_data, 0, sizeof(get_stat_data)); | |
620 | memcpy(get_stat_data.DspVer, info->DspVer, DSPVERSZ); | 620 | memcpy(get_stat_data.DspVer, info->DspVer, DSPVERSZ); |
621 | memcpy(get_stat_data.HwSerNum, info->HwSerNum, HWSERNUMSZ); | 621 | memcpy(get_stat_data.HwSerNum, info->HwSerNum, HWSERNUMSZ); |
622 | memcpy(get_stat_data.Sku, info->Sku, SKUSZ); | 622 | memcpy(get_stat_data.Sku, info->Sku, SKUSZ); |