aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYogesh Ashok Powar <yogeshp@marvell.com>2012-03-13 22:22:34 -0400
committerJohn W. Linville <linville@tuxdriver.com>2012-03-14 14:39:32 -0400
commit842668417c13f5fca19d9db29f508500cd621af0 (patch)
tree5d90f2ca575f5f21dc1738b888dbc3f34f9f1be5
parent3117bbdb7899d43927c8ce4fe885ab7c1231c121 (diff)
mwifiex: fix checkpatch --strict warnings/errors Part 1
For files 11n.c, 11n.h, 11n_aggr.c, 11n_rxreorder.c Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com> Signed-off-by: Bing Zhao <bzhao@marvell.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/mwifiex/11n.c22
-rw-r--r--drivers/net/wireless/mwifiex/11n.h7
-rw-r--r--drivers/net/wireless/mwifiex/11n_aggr.c15
-rw-r--r--drivers/net/wireless/mwifiex/11n_rxreorder.c42
4 files changed, 43 insertions, 43 deletions
diff --git a/drivers/net/wireless/mwifiex/11n.c b/drivers/net/wireless/mwifiex/11n.c
index aeb456d6396..a5e182b5e94 100644
--- a/drivers/net/wireless/mwifiex/11n.c
+++ b/drivers/net/wireless/mwifiex/11n.c
@@ -44,16 +44,16 @@ mwifiex_fill_cap_info(struct mwifiex_private *priv, u8 radio_type,
44 44
45 ht_cap->ht_cap.ampdu_params_info = 45 ht_cap->ht_cap.ampdu_params_info =
46 (sband->ht_cap.ampdu_factor & 46 (sband->ht_cap.ampdu_factor &
47 IEEE80211_HT_AMPDU_PARM_FACTOR)| 47 IEEE80211_HT_AMPDU_PARM_FACTOR) |
48 ((sband->ht_cap.ampdu_density << 48 ((sband->ht_cap.ampdu_density <<
49 IEEE80211_HT_AMPDU_PARM_DENSITY_SHIFT) & 49 IEEE80211_HT_AMPDU_PARM_DENSITY_SHIFT) &
50 IEEE80211_HT_AMPDU_PARM_DENSITY); 50 IEEE80211_HT_AMPDU_PARM_DENSITY);
51 51
52 memcpy((u8 *) &ht_cap->ht_cap.mcs, &sband->ht_cap.mcs, 52 memcpy((u8 *) &ht_cap->ht_cap.mcs, &sband->ht_cap.mcs,
53 sizeof(sband->ht_cap.mcs)); 53 sizeof(sband->ht_cap.mcs));
54 54
55 if (priv->bss_mode == NL80211_IFTYPE_STATION || 55 if (priv->bss_mode == NL80211_IFTYPE_STATION ||
56 (sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40)) 56 sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40)
57 /* Set MCS32 for infra mode or ad-hoc mode with 40MHz support */ 57 /* Set MCS32 for infra mode or ad-hoc mode with 40MHz support */
58 SETHT_MCS32(ht_cap->ht_cap.mcs.rx_mask); 58 SETHT_MCS32(ht_cap->ht_cap.mcs.rx_mask);
59 59
@@ -389,9 +389,9 @@ mwifiex_cmd_append_11n_tlv(struct mwifiex_private *priv,
389 chan_list->chan_scan_param[0].radio_type = 389 chan_list->chan_scan_param[0].radio_type =
390 mwifiex_band_to_radio_type((u8) bss_desc->bss_band); 390 mwifiex_band_to_radio_type((u8) bss_desc->bss_band);
391 391
392 if ((sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40) 392 if (sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40 &&
393 && (bss_desc->bcn_ht_info->ht_param & 393 bss_desc->bcn_ht_info->ht_param &
394 IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)) 394 IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)
395 SET_SECONDARYCHAN(chan_list->chan_scan_param[0]. 395 SET_SECONDARYCHAN(chan_list->chan_scan_param[0].
396 radio_type, 396 radio_type,
397 (bss_desc->bcn_ht_info->ht_param & 397 (bss_desc->bcn_ht_info->ht_param &
@@ -464,7 +464,7 @@ mwifiex_cfg_tx_buf(struct mwifiex_private *priv,
464 tx_buf = min(priv->adapter->max_tx_buf_size, max_amsdu); 464 tx_buf = min(priv->adapter->max_tx_buf_size, max_amsdu);
465 465
466 dev_dbg(priv->adapter->dev, "info: max_amsdu=%d, max_tx_buf=%d\n", 466 dev_dbg(priv->adapter->dev, "info: max_amsdu=%d, max_tx_buf=%d\n",
467 max_amsdu, priv->adapter->max_tx_buf_size); 467 max_amsdu, priv->adapter->max_tx_buf_size);
468 468
469 if (priv->adapter->curr_tx_buf_size <= MWIFIEX_TX_DATA_BUF_SIZE_2K) 469 if (priv->adapter->curr_tx_buf_size <= MWIFIEX_TX_DATA_BUF_SIZE_2K)
470 curr_tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K; 470 curr_tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K;
@@ -504,7 +504,7 @@ void mwifiex_11n_delete_tx_ba_stream_tbl_entry(struct mwifiex_private *priv,
504 struct mwifiex_tx_ba_stream_tbl *tx_ba_tsr_tbl) 504 struct mwifiex_tx_ba_stream_tbl *tx_ba_tsr_tbl)
505{ 505{
506 if (!tx_ba_tsr_tbl && 506 if (!tx_ba_tsr_tbl &&
507 mwifiex_is_tx_ba_stream_ptr_valid(priv, tx_ba_tsr_tbl)) 507 mwifiex_is_tx_ba_stream_ptr_valid(priv, tx_ba_tsr_tbl))
508 return; 508 return;
509 509
510 dev_dbg(priv->adapter->dev, "info: tx_ba_tsr_tbl %p\n", tx_ba_tsr_tbl); 510 dev_dbg(priv->adapter->dev, "info: tx_ba_tsr_tbl %p\n", tx_ba_tsr_tbl);
@@ -548,8 +548,8 @@ mwifiex_get_ba_tbl(struct mwifiex_private *priv, int tid, u8 *ra)
548 548
549 spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags); 549 spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
550 list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) { 550 list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
551 if ((!memcmp(tx_ba_tsr_tbl->ra, ra, ETH_ALEN)) 551 if (!memcmp(tx_ba_tsr_tbl->ra, ra, ETH_ALEN) &&
552 && (tx_ba_tsr_tbl->tid == tid)) { 552 tx_ba_tsr_tbl->tid == tid) {
553 spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, 553 spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock,
554 flags); 554 flags);
555 return tx_ba_tsr_tbl; 555 return tx_ba_tsr_tbl;
@@ -718,7 +718,7 @@ int mwifiex_get_tx_ba_stream_tbl(struct mwifiex_private *priv,
718 list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) { 718 list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
719 rx_reo_tbl->tid = (u16) tx_ba_tsr_tbl->tid; 719 rx_reo_tbl->tid = (u16) tx_ba_tsr_tbl->tid;
720 dev_dbg(priv->adapter->dev, "data: %s tid=%d\n", 720 dev_dbg(priv->adapter->dev, "data: %s tid=%d\n",
721 __func__, rx_reo_tbl->tid); 721 __func__, rx_reo_tbl->tid);
722 memcpy(rx_reo_tbl->ra, tx_ba_tsr_tbl->ra, ETH_ALEN); 722 memcpy(rx_reo_tbl->ra, tx_ba_tsr_tbl->ra, ETH_ALEN);
723 rx_reo_tbl++; 723 rx_reo_tbl++;
724 count++; 724 count++;
diff --git a/drivers/net/wireless/mwifiex/11n.h b/drivers/net/wireless/mwifiex/11n.h
index 139aa6ee1fb..77646d777dc 100644
--- a/drivers/net/wireless/mwifiex/11n.h
+++ b/drivers/net/wireless/mwifiex/11n.h
@@ -86,9 +86,8 @@ mwifiex_is_ampdu_allowed(struct mwifiex_private *priv, int tid)
86static inline u8 86static inline u8
87mwifiex_is_amsdu_allowed(struct mwifiex_private *priv, int tid) 87mwifiex_is_amsdu_allowed(struct mwifiex_private *priv, int tid)
88{ 88{
89 return (((priv->aggr_prio_tbl[tid].amsdu != BA_STREAM_NOT_ALLOWED) 89 return (((priv->aggr_prio_tbl[tid].amsdu != BA_STREAM_NOT_ALLOWED) &&
90 && ((priv->is_data_rate_auto) 90 (priv->is_data_rate_auto || !(priv->bitmap_rates[2] & 0x03)))
91 || !((priv->bitmap_rates[2]) & 0x03)))
92 ? true : false); 91 ? true : false);
93} 92}
94 93
@@ -149,7 +148,7 @@ mwifiex_find_stream_to_delete(struct mwifiex_private *priv, int ptr_tid,
149 */ 148 */
150static inline int 149static inline int
151mwifiex_is_ba_stream_setup(struct mwifiex_private *priv, 150mwifiex_is_ba_stream_setup(struct mwifiex_private *priv,
152 struct mwifiex_ra_list_tbl *ptr, int tid) 151 struct mwifiex_ra_list_tbl *ptr, int tid)
153{ 152{
154 struct mwifiex_tx_ba_stream_tbl *tx_tbl; 153 struct mwifiex_tx_ba_stream_tbl *tx_tbl;
155 154
diff --git a/drivers/net/wireless/mwifiex/11n_aggr.c b/drivers/net/wireless/mwifiex/11n_aggr.c
index ea6832dc667..9eefb2a0ce9 100644
--- a/drivers/net/wireless/mwifiex/11n_aggr.c
+++ b/drivers/net/wireless/mwifiex/11n_aggr.c
@@ -84,7 +84,7 @@ mwifiex_11n_form_amsdu_pkt(struct sk_buff *skb_aggr,
84 /* Add payload */ 84 /* Add payload */
85 skb_put(skb_aggr, skb_src->len); 85 skb_put(skb_aggr, skb_src->len);
86 memcpy(skb_aggr->data + sizeof(*tx_header), skb_src->data, 86 memcpy(skb_aggr->data + sizeof(*tx_header), skb_src->data,
87 skb_src->len); 87 skb_src->len);
88 *pad = (((skb_src->len + LLC_SNAP_LEN) & 3)) ? (4 - (((skb_src->len + 88 *pad = (((skb_src->len + LLC_SNAP_LEN) & 3)) ? (4 - (((skb_src->len +
89 LLC_SNAP_LEN)) & 3)) : 0; 89 LLC_SNAP_LEN)) & 3)) : 0;
90 skb_put(skb_aggr, *pad); 90 skb_put(skb_aggr, *pad);
@@ -119,14 +119,14 @@ mwifiex_11n_form_amsdu_txpd(struct mwifiex_private *priv,
119 local_tx_pd->tx_pkt_offset = cpu_to_le16(sizeof(struct txpd)); 119 local_tx_pd->tx_pkt_offset = cpu_to_le16(sizeof(struct txpd));
120 local_tx_pd->tx_pkt_type = cpu_to_le16(PKT_TYPE_AMSDU); 120 local_tx_pd->tx_pkt_type = cpu_to_le16(PKT_TYPE_AMSDU);
121 local_tx_pd->tx_pkt_length = cpu_to_le16(skb->len - 121 local_tx_pd->tx_pkt_length = cpu_to_le16(skb->len -
122 sizeof(*local_tx_pd)); 122 sizeof(*local_tx_pd));
123 123
124 if (local_tx_pd->tx_control == 0) 124 if (local_tx_pd->tx_control == 0)
125 /* TxCtrl set by user or default */ 125 /* TxCtrl set by user or default */
126 local_tx_pd->tx_control = cpu_to_le32(priv->pkt_tx_ctrl); 126 local_tx_pd->tx_control = cpu_to_le32(priv->pkt_tx_ctrl);
127 127
128 if ((GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA) && 128 if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA &&
129 (priv->adapter->pps_uapsd_mode)) { 129 priv->adapter->pps_uapsd_mode) {
130 if (true == mwifiex_check_last_packet_indication(priv)) { 130 if (true == mwifiex_check_last_packet_indication(priv)) {
131 priv->adapter->tx_lock_flag = true; 131 priv->adapter->tx_lock_flag = true;
132 local_tx_pd->flags = 132 local_tx_pd->flags =
@@ -257,9 +257,8 @@ mwifiex_11n_aggregate_pkt(struct mwifiex_private *priv,
257 mwifiex_write_data_complete(adapter, skb_aggr, -1); 257 mwifiex_write_data_complete(adapter, skb_aggr, -1);
258 return -1; 258 return -1;
259 } 259 }
260 if ((GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA) && 260 if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA &&
261 (adapter->pps_uapsd_mode) && 261 adapter->pps_uapsd_mode && adapter->tx_lock_flag) {
262 (adapter->tx_lock_flag)) {
263 priv->adapter->tx_lock_flag = false; 262 priv->adapter->tx_lock_flag = false;
264 if (ptx_pd) 263 if (ptx_pd)
265 ptx_pd->flags = 0; 264 ptx_pd->flags = 0;
@@ -279,7 +278,7 @@ mwifiex_11n_aggregate_pkt(struct mwifiex_private *priv,
279 case -1: 278 case -1:
280 adapter->data_sent = false; 279 adapter->data_sent = false;
281 dev_err(adapter->dev, "%s: host_to_card failed: %#x\n", 280 dev_err(adapter->dev, "%s: host_to_card failed: %#x\n",
282 __func__, ret); 281 __func__, ret);
283 adapter->dbg.num_tx_host_to_card_failure++; 282 adapter->dbg.num_tx_host_to_card_failure++;
284 mwifiex_write_data_complete(adapter, skb_aggr, ret); 283 mwifiex_write_data_complete(adapter, skb_aggr, ret);
285 return 0; 284 return 0;
diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c b/drivers/net/wireless/mwifiex/11n_rxreorder.c
index 06f5d368402..9c44088054d 100644
--- a/drivers/net/wireless/mwifiex/11n_rxreorder.c
+++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c
@@ -220,7 +220,7 @@ mwifiex_flush_data(unsigned long context)
220 */ 220 */
221static void 221static void
222mwifiex_11n_create_rx_reorder_tbl(struct mwifiex_private *priv, u8 *ta, 222mwifiex_11n_create_rx_reorder_tbl(struct mwifiex_private *priv, u8 *ta,
223 int tid, int win_size, int seq_num) 223 int tid, int win_size, int seq_num)
224{ 224{
225 int i; 225 int i;
226 struct mwifiex_rx_reorder_tbl *tbl, *new_node; 226 struct mwifiex_rx_reorder_tbl *tbl, *new_node;
@@ -240,7 +240,7 @@ mwifiex_11n_create_rx_reorder_tbl(struct mwifiex_private *priv, u8 *ta,
240 new_node = kzalloc(sizeof(struct mwifiex_rx_reorder_tbl), GFP_KERNEL); 240 new_node = kzalloc(sizeof(struct mwifiex_rx_reorder_tbl), GFP_KERNEL);
241 if (!new_node) { 241 if (!new_node) {
242 dev_err(priv->adapter->dev, "%s: failed to alloc new_node\n", 242 dev_err(priv->adapter->dev, "%s: failed to alloc new_node\n",
243 __func__); 243 __func__);
244 return; 244 return;
245 } 245 }
246 246
@@ -352,7 +352,8 @@ int mwifiex_cmd_11n_addba_rsp_gen(struct mwifiex_private *priv,
352 cmd_addba_req->block_ack_param_set = cpu_to_le16(block_ack_param_set); 352 cmd_addba_req->block_ack_param_set = cpu_to_le16(block_ack_param_set);
353 353
354 mwifiex_11n_create_rx_reorder_tbl(priv, cmd_addba_req->peer_mac_addr, 354 mwifiex_11n_create_rx_reorder_tbl(priv, cmd_addba_req->peer_mac_addr,
355 tid, win_size, le16_to_cpu(cmd_addba_req->ssn)); 355 tid, win_size,
356 le16_to_cpu(cmd_addba_req->ssn));
356 return 0; 357 return 0;
357} 358}
358 359
@@ -416,11 +417,11 @@ int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv,
416 * packet 417 * packet
417 */ 418 */
418 if ((start_win + TWOPOW11) > (MAX_TID_VALUE - 1)) {/* Wrap */ 419 if ((start_win + TWOPOW11) > (MAX_TID_VALUE - 1)) {/* Wrap */
419 if (seq_num >= ((start_win + (TWOPOW11)) & (MAX_TID_VALUE - 1)) 420 if (seq_num >= ((start_win + TWOPOW11) &
420 && (seq_num < start_win)) 421 (MAX_TID_VALUE - 1)) && (seq_num < start_win))
421 return -1; 422 return -1;
422 } else if ((seq_num < start_win) 423 } else if ((seq_num < start_win) ||
423 || (seq_num > (start_win + (TWOPOW11)))) { 424 (seq_num > (start_win + TWOPOW11))) {
424 return -1; 425 return -1;
425 } 426 }
426 427
@@ -431,10 +432,11 @@ int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv,
431 if (pkt_type == PKT_TYPE_BAR) 432 if (pkt_type == PKT_TYPE_BAR)
432 seq_num = ((seq_num + win_size) - 1) & (MAX_TID_VALUE - 1); 433 seq_num = ((seq_num + win_size) - 1) & (MAX_TID_VALUE - 1);
433 434
434 if (((end_win < start_win) 435 if (((end_win < start_win) &&
435 && (seq_num < (TWOPOW11 - (MAX_TID_VALUE - start_win))) 436 (seq_num < (TWOPOW11 - (MAX_TID_VALUE - start_win))) &&
436 && (seq_num > end_win)) || ((end_win > start_win) 437 (seq_num > end_win)) ||
437 && ((seq_num > end_win) || (seq_num < start_win)))) { 438 ((end_win > start_win) && ((seq_num > end_win) ||
439 (seq_num < start_win)))) {
438 end_win = seq_num; 440 end_win = seq_num;
439 if (((seq_num - win_size) + 1) >= 0) 441 if (((seq_num - win_size) + 1) >= 0)
440 start_win = (end_win - win_size) + 1; 442 start_win = (end_win - win_size) + 1;
@@ -483,15 +485,15 @@ mwifiex_del_ba_tbl(struct mwifiex_private *priv, int tid, u8 *peer_mac,
483 else 485 else
484 cleanup_rx_reorder_tbl = (initiator) ? false : true; 486 cleanup_rx_reorder_tbl = (initiator) ? false : true;
485 487
486 dev_dbg(priv->adapter->dev, "event: DELBA: %pM tid=%d, " 488 dev_dbg(priv->adapter->dev, "event: DELBA: %pM tid=%d initiator=%d\n",
487 "initiator=%d\n", peer_mac, tid, initiator); 489 peer_mac, tid, initiator);
488 490
489 if (cleanup_rx_reorder_tbl) { 491 if (cleanup_rx_reorder_tbl) {
490 tbl = mwifiex_11n_get_rx_reorder_tbl(priv, tid, 492 tbl = mwifiex_11n_get_rx_reorder_tbl(priv, tid,
491 peer_mac); 493 peer_mac);
492 if (!tbl) { 494 if (!tbl) {
493 dev_dbg(priv->adapter->dev, 495 dev_dbg(priv->adapter->dev,
494 "event: TID, TA not found in table\n"); 496 "event: TID, TA not found in table\n");
495 return; 497 return;
496 } 498 }
497 mwifiex_del_rx_reorder_entry(priv, tbl); 499 mwifiex_del_rx_reorder_entry(priv, tbl);
@@ -499,7 +501,7 @@ mwifiex_del_ba_tbl(struct mwifiex_private *priv, int tid, u8 *peer_mac,
499 ptx_tbl = mwifiex_get_ba_tbl(priv, tid, peer_mac); 501 ptx_tbl = mwifiex_get_ba_tbl(priv, tid, peer_mac);
500 if (!ptx_tbl) { 502 if (!ptx_tbl) {
501 dev_dbg(priv->adapter->dev, 503 dev_dbg(priv->adapter->dev,
502 "event: TID, RA not found in table\n"); 504 "event: TID, RA not found in table\n");
503 return; 505 return;
504 } 506 }
505 507
@@ -538,13 +540,13 @@ int mwifiex_ret_11n_addba_resp(struct mwifiex_private *priv,
538 IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK) 540 IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK)
539 >> BLOCKACKPARAM_WINSIZE_POS; 541 >> BLOCKACKPARAM_WINSIZE_POS;
540 542
541 dev_dbg(priv->adapter->dev, "cmd: ADDBA RSP: %pM" 543 dev_dbg(priv->adapter->dev,
542 " tid=%d ssn=%d win_size=%d\n", 544 "cmd: ADDBA RSP: %pM tid=%d ssn=%d win_size=%d\n",
543 add_ba_rsp->peer_mac_addr, 545 add_ba_rsp->peer_mac_addr, tid,
544 tid, add_ba_rsp->ssn, win_size); 546 add_ba_rsp->ssn, win_size);
545 } else { 547 } else {
546 dev_err(priv->adapter->dev, "ADDBA RSP: failed %pM tid=%d)\n", 548 dev_err(priv->adapter->dev, "ADDBA RSP: failed %pM tid=%d)\n",
547 add_ba_rsp->peer_mac_addr, tid); 549 add_ba_rsp->peer_mac_addr, tid);
548 550
549 tbl = mwifiex_11n_get_rx_reorder_tbl(priv, tid, 551 tbl = mwifiex_11n_get_rx_reorder_tbl(priv, tid,
550 add_ba_rsp->peer_mac_addr); 552 add_ba_rsp->peer_mac_addr);