aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBorislav Petkov <borislav.petkov@amd.com>2012-07-25 14:06:54 -0400
committerH. Peter Anvin <hpa@linux.intel.com>2012-08-22 19:15:50 -0400
commit5f5b747282c6cc57b91baba37f76de27398b9e60 (patch)
treea741c6bf98fb9dfe3d83833b1b279381ceb55db3
parent685ca6d797af9d41164dd64dd60145d4946fc152 (diff)
x86, microcode, AMD: Read CPUID(1).EAX on the correct cpu
Read the CPUID(1).EAX leaf at the correct cpu and use it to search the equivalence table for matching microcode patch. No functionality change. Signed-off-by: Borislav Petkov <borislav.petkov@amd.com> Link: http://lkml.kernel.org/r/1344361461-10076-9-git-send-email-bp@amd64.org Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
-rw-r--r--arch/x86/kernel/microcode_amd.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
index 8fdf7d99b80..25d34b17748 100644
--- a/arch/x86/kernel/microcode_amd.c
+++ b/arch/x86/kernel/microcode_amd.c
@@ -82,6 +82,7 @@ static int collect_cpu_info_amd(int cpu, struct cpu_signature *csig)
82{ 82{
83 struct cpuinfo_x86 *c = &cpu_data(cpu); 83 struct cpuinfo_x86 *c = &cpu_data(cpu);
84 84
85 csig->sig = cpuid_eax(0x00000001);
85 csig->rev = c->microcode; 86 csig->rev = c->microcode;
86 pr_info("CPU%d: patch_level=0x%08x\n", cpu, csig->rev); 87 pr_info("CPU%d: patch_level=0x%08x\n", cpu, csig->rev);
87 88
@@ -118,16 +119,15 @@ static unsigned int verify_ucode_size(int cpu, u32 patch_size,
118 return patch_size; 119 return patch_size;
119} 120}
120 121
121static u16 find_equiv_id(void) 122static u16 find_equiv_id(unsigned int cpu)
122{ 123{
123 unsigned int current_cpu_id, i = 0; 124 struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
125 int i = 0;
124 126
125 BUG_ON(equiv_cpu_table == NULL); 127 BUG_ON(equiv_cpu_table == NULL);
126 128
127 current_cpu_id = cpuid_eax(0x00000001);
128
129 while (equiv_cpu_table[i].installed_cpu != 0) { 129 while (equiv_cpu_table[i].installed_cpu != 0) {
130 if (current_cpu_id == equiv_cpu_table[i].installed_cpu) 130 if (uci->cpu_sig.sig == equiv_cpu_table[i].installed_cpu)
131 return equiv_cpu_table[i].equiv_cpu; 131 return equiv_cpu_table[i].equiv_cpu;
132 132
133 i++; 133 i++;
@@ -150,7 +150,7 @@ static int get_matching_microcode(int cpu, const u8 *ucode_ptr,
150 patch_size = *(u32 *)(ucode_ptr + 4); 150 patch_size = *(u32 *)(ucode_ptr + 4);
151 *current_size = patch_size + SECTION_HDR_SIZE; 151 *current_size = patch_size + SECTION_HDR_SIZE;
152 152
153 equiv_cpu_id = find_equiv_id(); 153 equiv_cpu_id = find_equiv_id(cpu);
154 if (!equiv_cpu_id) 154 if (!equiv_cpu_id)
155 return 0; 155 return 0;
156 156