aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordave graham <david.graham@intel.com>2009-02-10 07:52:05 -0500
committerDavid S. Miller <davem@davemloft.net>2009-02-10 20:00:28 -0500
commit573cca8c6fdbf6bd2dae8f9e9b66931990849c83 (patch)
tree16aa90922250cb036d2230256e0fc890ba3476b8
parent5df3f0eaf8b236cc785e2733a3df1e5c84e4aad8 (diff)
e1000e: remove RXSEQ link monitoring for serdes
RXSEQ interrupts were used to force link state interrogation of serdes links, as the Si was not guaranteed to report LSC interrupts when the link changed state. On some bladeservers this resulted in false link up reports if no link partner was connected. The RXSEQ treatment is not necessary, as the link can be monitored from the watchdog timer, and the false link indications cease. Signed-off-by: dave graham <david.graham@intel.com> Acked-by: Bruce Allan <bruce.w.allan@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/e1000e/netdev.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 00e19e93bb9..04e007dcf47 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -1153,7 +1153,7 @@ static irqreturn_t e1000_intr_msi(int irq, void *data)
1153 * read ICR disables interrupts using IAM 1153 * read ICR disables interrupts using IAM
1154 */ 1154 */
1155 1155
1156 if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) { 1156 if (icr & E1000_ICR_LSC) {
1157 hw->mac.get_link_status = 1; 1157 hw->mac.get_link_status = 1;
1158 /* 1158 /*
1159 * ICH8 workaround-- Call gig speed drop workaround on cable 1159 * ICH8 workaround-- Call gig speed drop workaround on cable
@@ -1219,7 +1219,7 @@ static irqreturn_t e1000_intr(int irq, void *data)
1219 * IMC write 1219 * IMC write
1220 */ 1220 */
1221 1221
1222 if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) { 1222 if (icr & E1000_ICR_LSC) {
1223 hw->mac.get_link_status = 1; 1223 hw->mac.get_link_status = 1;
1224 /* 1224 /*
1225 * ICH8 workaround-- Call gig speed drop workaround on cable 1225 * ICH8 workaround-- Call gig speed drop workaround on cable