diff options
author | Arend van Spriel <arend@broadcom.com> | 2012-12-05 09:26:03 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-12-10 15:47:27 -0500 |
commit | 4e8a008e578635addbd5470215fdb6678051435a (patch) | |
tree | 0169afd2e96c9dc0eaf5cf3ecdeac1ca55661bbf | |
parent | d96b801f0f549f86510e1731b56dfb4c3de86b6f (diff) |
brcmfmac: remove WL_SCAN() macro
Get rid of WL_SCAN(...) macro in favor of brcmf_dbg(SCAN,...)
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 77 | ||||
-rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h | 1 |
2 files changed, 39 insertions, 39 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c index 1a24c77cf86..f196613a32e 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | |||
@@ -539,19 +539,20 @@ static void brcmf_escan_prep(struct brcmf_scan_params_le *params_le, | |||
539 | n_ssids = request->n_ssids; | 539 | n_ssids = request->n_ssids; |
540 | n_channels = request->n_channels; | 540 | n_channels = request->n_channels; |
541 | /* Copy channel array if applicable */ | 541 | /* Copy channel array if applicable */ |
542 | WL_SCAN("### List of channelspecs to scan ### %d\n", n_channels); | 542 | brcmf_dbg(SCAN, "### List of channelspecs to scan ### %d\n", |
543 | n_channels); | ||
543 | if (n_channels > 0) { | 544 | if (n_channels > 0) { |
544 | for (i = 0; i < n_channels; i++) { | 545 | for (i = 0; i < n_channels; i++) { |
545 | chanspec = channel_to_chanspec(request->channels[i]); | 546 | chanspec = channel_to_chanspec(request->channels[i]); |
546 | WL_SCAN("Chan : %d, Channel spec: %x\n", | 547 | brcmf_dbg(SCAN, "Chan : %d, Channel spec: %x\n", |
547 | request->channels[i]->hw_value, chanspec); | 548 | request->channels[i]->hw_value, chanspec); |
548 | params_le->channel_list[i] = cpu_to_le16(chanspec); | 549 | params_le->channel_list[i] = cpu_to_le16(chanspec); |
549 | } | 550 | } |
550 | } else { | 551 | } else { |
551 | WL_SCAN("Scanning all channels\n"); | 552 | brcmf_dbg(SCAN, "Scanning all channels\n"); |
552 | } | 553 | } |
553 | /* Copy ssid array if applicable */ | 554 | /* Copy ssid array if applicable */ |
554 | WL_SCAN("### List of SSIDs to scan ### %d\n", n_ssids); | 555 | brcmf_dbg(SCAN, "### List of SSIDs to scan ### %d\n", n_ssids); |
555 | if (n_ssids > 0) { | 556 | if (n_ssids > 0) { |
556 | offset = offsetof(struct brcmf_scan_params_le, channel_list) + | 557 | offset = offsetof(struct brcmf_scan_params_le, channel_list) + |
557 | n_channels * sizeof(u16); | 558 | n_channels * sizeof(u16); |
@@ -564,18 +565,19 @@ static void brcmf_escan_prep(struct brcmf_scan_params_le *params_le, | |||
564 | memcpy(ssid_le.SSID, request->ssids[i].ssid, | 565 | memcpy(ssid_le.SSID, request->ssids[i].ssid, |
565 | request->ssids[i].ssid_len); | 566 | request->ssids[i].ssid_len); |
566 | if (!ssid_le.SSID_len) | 567 | if (!ssid_le.SSID_len) |
567 | WL_SCAN("%d: Broadcast scan\n", i); | 568 | brcmf_dbg(SCAN, "%d: Broadcast scan\n", i); |
568 | else | 569 | else |
569 | WL_SCAN("%d: scan for %s size =%d\n", i, | 570 | brcmf_dbg(SCAN, "%d: scan for %s size =%d\n", |
570 | ssid_le.SSID, ssid_le.SSID_len); | 571 | i, ssid_le.SSID, ssid_le.SSID_len); |
571 | memcpy(ptr, &ssid_le, sizeof(ssid_le)); | 572 | memcpy(ptr, &ssid_le, sizeof(ssid_le)); |
572 | ptr += sizeof(ssid_le); | 573 | ptr += sizeof(ssid_le); |
573 | } | 574 | } |
574 | } else { | 575 | } else { |
575 | WL_SCAN("Broadcast scan %p\n", request->ssids); | 576 | brcmf_dbg(SCAN, "Broadcast scan %p\n", request->ssids); |
576 | if ((request->ssids) && request->ssids->ssid_len) { | 577 | if ((request->ssids) && request->ssids->ssid_len) { |
577 | WL_SCAN("SSID %s len=%d\n", params_le->ssid_le.SSID, | 578 | brcmf_dbg(SCAN, "SSID %s len=%d\n", |
578 | request->ssids->ssid_len); | 579 | params_le->ssid_le.SSID, |
580 | request->ssids->ssid_len); | ||
579 | params_le->ssid_le.SSID_len = | 581 | params_le->ssid_le.SSID_len = |
580 | cpu_to_le32(request->ssids->ssid_len); | 582 | cpu_to_le32(request->ssids->ssid_len); |
581 | memcpy(¶ms_le->ssid_le.SSID, request->ssids->ssid, | 583 | memcpy(¶ms_le->ssid_le.SSID, request->ssids->ssid, |
@@ -597,7 +599,7 @@ brcmf_notify_escan_complete(struct brcmf_cfg80211_info *cfg, | |||
597 | struct cfg80211_scan_request *scan_request; | 599 | struct cfg80211_scan_request *scan_request; |
598 | s32 err = 0; | 600 | s32 err = 0; |
599 | 601 | ||
600 | WL_SCAN("Enter\n"); | 602 | brcmf_dbg(SCAN, "Enter\n"); |
601 | 603 | ||
602 | /* clear scan request, because the FW abort can cause a second call */ | 604 | /* clear scan request, because the FW abort can cause a second call */ |
603 | /* to this functon and might cause a double cfg80211_scan_done */ | 605 | /* to this functon and might cause a double cfg80211_scan_done */ |
@@ -609,7 +611,7 @@ brcmf_notify_escan_complete(struct brcmf_cfg80211_info *cfg, | |||
609 | 611 | ||
610 | if (fw_abort) { | 612 | if (fw_abort) { |
611 | /* Do a scan abort to stop the driver's scan engine */ | 613 | /* Do a scan abort to stop the driver's scan engine */ |
612 | WL_SCAN("ABORT scan in firmware\n"); | 614 | brcmf_dbg(SCAN, "ABORT scan in firmware\n"); |
613 | memset(¶ms_le, 0, sizeof(params_le)); | 615 | memset(¶ms_le, 0, sizeof(params_le)); |
614 | memset(params_le.bssid, 0xFF, ETH_ALEN); | 616 | memset(params_le.bssid, 0xFF, ETH_ALEN); |
615 | params_le.bss_type = DOT11_BSSTYPE_ANY; | 617 | params_le.bss_type = DOT11_BSSTYPE_ANY; |
@@ -632,14 +634,14 @@ brcmf_notify_escan_complete(struct brcmf_cfg80211_info *cfg, | |||
632 | * which takes precedence. | 634 | * which takes precedence. |
633 | */ | 635 | */ |
634 | if (cfg->sched_escan) { | 636 | if (cfg->sched_escan) { |
635 | WL_SCAN("scheduled scan completed\n"); | 637 | brcmf_dbg(SCAN, "scheduled scan completed\n"); |
636 | cfg->sched_escan = false; | 638 | cfg->sched_escan = false; |
637 | if (!aborted) | 639 | if (!aborted) |
638 | cfg80211_sched_scan_results(cfg_to_wiphy(cfg)); | 640 | cfg80211_sched_scan_results(cfg_to_wiphy(cfg)); |
639 | brcmf_set_mpc(ndev, 1); | 641 | brcmf_set_mpc(ndev, 1); |
640 | } else if (scan_request) { | 642 | } else if (scan_request) { |
641 | WL_SCAN("ESCAN Completed scan: %s\n", | 643 | brcmf_dbg(SCAN, "ESCAN Completed scan: %s\n", |
642 | aborted ? "Aborted" : "Done"); | 644 | aborted ? "Aborted" : "Done"); |
643 | cfg80211_scan_done(scan_request, aborted); | 645 | cfg80211_scan_done(scan_request, aborted); |
644 | brcmf_set_mpc(ndev, 1); | 646 | brcmf_set_mpc(ndev, 1); |
645 | } | 647 | } |
@@ -660,7 +662,7 @@ brcmf_run_escan(struct brcmf_cfg80211_info *cfg, struct net_device *ndev, | |||
660 | struct brcmf_escan_params_le *params; | 662 | struct brcmf_escan_params_le *params; |
661 | s32 err = 0; | 663 | s32 err = 0; |
662 | 664 | ||
663 | WL_SCAN("E-SCAN START\n"); | 665 | brcmf_dbg(SCAN, "E-SCAN START\n"); |
664 | 666 | ||
665 | if (request != NULL) { | 667 | if (request != NULL) { |
666 | /* Allocate space for populating ssids in struct */ | 668 | /* Allocate space for populating ssids in struct */ |
@@ -703,7 +705,7 @@ brcmf_do_escan(struct brcmf_cfg80211_info *cfg, struct wiphy *wiphy, | |||
703 | u32 passive_scan; | 705 | u32 passive_scan; |
704 | struct brcmf_scan_results *results; | 706 | struct brcmf_scan_results *results; |
705 | 707 | ||
706 | WL_SCAN("Enter\n"); | 708 | brcmf_dbg(SCAN, "Enter\n"); |
707 | cfg->escan_info.ndev = ndev; | 709 | cfg->escan_info.ndev = ndev; |
708 | cfg->escan_info.wiphy = wiphy; | 710 | cfg->escan_info.wiphy = wiphy; |
709 | cfg->escan_info.escan_state = WL_ESCAN_STATE_SCANNING; | 711 | cfg->escan_info.escan_state = WL_ESCAN_STATE_SCANNING; |
@@ -741,7 +743,7 @@ brcmf_cfg80211_escan(struct wiphy *wiphy, struct net_device *ndev, | |||
741 | s32 err; | 743 | s32 err; |
742 | u32 SSID_len; | 744 | u32 SSID_len; |
743 | 745 | ||
744 | WL_SCAN("START ESCAN\n"); | 746 | brcmf_dbg(SCAN, "START ESCAN\n"); |
745 | 747 | ||
746 | if (test_bit(BRCMF_SCAN_STATUS_BUSY, &cfg->scan_status)) { | 748 | if (test_bit(BRCMF_SCAN_STATUS_BUSY, &cfg->scan_status)) { |
747 | brcmf_err("Scanning already: status (%lu)\n", cfg->scan_status); | 749 | brcmf_err("Scanning already: status (%lu)\n", cfg->scan_status); |
@@ -779,8 +781,8 @@ brcmf_cfg80211_escan(struct wiphy *wiphy, struct net_device *ndev, | |||
779 | if (err) | 781 | if (err) |
780 | goto scan_out; | 782 | goto scan_out; |
781 | } else { | 783 | } else { |
782 | WL_SCAN("ssid \"%s\", ssid_len (%d)\n", | 784 | brcmf_dbg(SCAN, "ssid \"%s\", ssid_len (%d)\n", |
783 | ssids->ssid, ssids->ssid_len); | 785 | ssids->ssid, ssids->ssid_len); |
784 | memset(&sr->ssid_le, 0, sizeof(sr->ssid_le)); | 786 | memset(&sr->ssid_le, 0, sizeof(sr->ssid_le)); |
785 | SSID_len = min_t(u8, sizeof(sr->ssid_le.SSID), ssids->ssid_len); | 787 | SSID_len = min_t(u8, sizeof(sr->ssid_le.SSID), ssids->ssid_len); |
786 | sr->ssid_le.SSID_len = cpu_to_le32(0); | 788 | sr->ssid_le.SSID_len = cpu_to_le32(0); |
@@ -790,7 +792,7 @@ brcmf_cfg80211_escan(struct wiphy *wiphy, struct net_device *ndev, | |||
790 | sr->ssid_le.SSID_len = cpu_to_le32(SSID_len); | 792 | sr->ssid_le.SSID_len = cpu_to_le32(SSID_len); |
791 | spec_scan = true; | 793 | spec_scan = true; |
792 | } else | 794 | } else |
793 | WL_SCAN("Broadcast scan\n"); | 795 | brcmf_dbg(SCAN, "Broadcast scan\n"); |
794 | 796 | ||
795 | passive_scan = cfg->active_scan ? 0 : 1; | 797 | passive_scan = cfg->active_scan ? 0 : 1; |
796 | err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_PASSIVE_SCAN, | 798 | err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_PASSIVE_SCAN, |
@@ -2150,7 +2152,7 @@ static s32 brcmf_inform_bss(struct brcmf_cfg80211_info *cfg) | |||
2150 | bss_list->version); | 2152 | bss_list->version); |
2151 | return -EOPNOTSUPP; | 2153 | return -EOPNOTSUPP; |
2152 | } | 2154 | } |
2153 | WL_SCAN("scanned AP count (%d)\n", bss_list->count); | 2155 | brcmf_dbg(SCAN, "scanned AP count (%d)\n", bss_list->count); |
2154 | for (i = 0; i < bss_list->count; i++) { | 2156 | for (i = 0; i < bss_list->count; i++) { |
2155 | bi = next_bss_le(bss_list, bi); | 2157 | bi = next_bss_le(bss_list, bi); |
2156 | err = brcmf_inform_single_bss(cfg, bi); | 2158 | err = brcmf_inform_single_bss(cfg, bi); |
@@ -2462,14 +2464,14 @@ brcmf_cfg80211_escan_handler(struct brcmf_if *ifp, | |||
2462 | } | 2464 | } |
2463 | 2465 | ||
2464 | if (status == BRCMF_E_STATUS_PARTIAL) { | 2466 | if (status == BRCMF_E_STATUS_PARTIAL) { |
2465 | WL_SCAN("ESCAN Partial result\n"); | 2467 | brcmf_dbg(SCAN, "ESCAN Partial result\n"); |
2466 | escan_result_le = (struct brcmf_escan_result_le *) data; | 2468 | escan_result_le = (struct brcmf_escan_result_le *) data; |
2467 | if (!escan_result_le) { | 2469 | if (!escan_result_le) { |
2468 | brcmf_err("Invalid escan result (NULL pointer)\n"); | 2470 | brcmf_err("Invalid escan result (NULL pointer)\n"); |
2469 | goto exit; | 2471 | goto exit; |
2470 | } | 2472 | } |
2471 | if (!cfg->scan_request) { | 2473 | if (!cfg->scan_request) { |
2472 | WL_SCAN("result without cfg80211 request\n"); | 2474 | brcmf_dbg(SCAN, "result without cfg80211 request\n"); |
2473 | goto exit; | 2475 | goto exit; |
2474 | } | 2476 | } |
2475 | 2477 | ||
@@ -2770,10 +2772,10 @@ brcmf_notify_sched_scan_results(struct brcmf_if *ifp, | |||
2770 | u32 result_count; | 2772 | u32 result_count; |
2771 | u32 status; | 2773 | u32 status; |
2772 | 2774 | ||
2773 | WL_SCAN("Enter\n"); | 2775 | brcmf_dbg(SCAN, "Enter\n"); |
2774 | 2776 | ||
2775 | if (e->event_code == BRCMF_E_PFN_NET_LOST) { | 2777 | if (e->event_code == BRCMF_E_PFN_NET_LOST) { |
2776 | WL_SCAN("PFN NET LOST event. Do Nothing\n"); | 2778 | brcmf_dbg(SCAN, "PFN NET LOST event. Do Nothing\n"); |
2777 | return 0; | 2779 | return 0; |
2778 | } | 2780 | } |
2779 | 2781 | ||
@@ -2786,7 +2788,7 @@ brcmf_notify_sched_scan_results(struct brcmf_if *ifp, | |||
2786 | * multiple NET_FOUND events. For now place a warning here. | 2788 | * multiple NET_FOUND events. For now place a warning here. |
2787 | */ | 2789 | */ |
2788 | WARN_ON(status != BRCMF_PNO_SCAN_COMPLETE); | 2790 | WARN_ON(status != BRCMF_PNO_SCAN_COMPLETE); |
2789 | WL_SCAN("PFN NET FOUND event. count: %d\n", result_count); | 2791 | brcmf_dbg(SCAN, "PFN NET FOUND event. count: %d\n", result_count); |
2790 | if (result_count > 0) { | 2792 | if (result_count > 0) { |
2791 | int i; | 2793 | int i; |
2792 | 2794 | ||
@@ -2811,8 +2813,8 @@ brcmf_notify_sched_scan_results(struct brcmf_if *ifp, | |||
2811 | goto out_err; | 2813 | goto out_err; |
2812 | } | 2814 | } |
2813 | 2815 | ||
2814 | WL_SCAN("SSID:%s Channel:%d\n", | 2816 | brcmf_dbg(SCAN, "SSID:%s Channel:%d\n", |
2815 | netinfo->SSID, netinfo->channel); | 2817 | netinfo->SSID, netinfo->channel); |
2816 | memcpy(ssid[i].ssid, netinfo->SSID, netinfo->SSID_len); | 2818 | memcpy(ssid[i].ssid, netinfo->SSID, netinfo->SSID_len); |
2817 | ssid[i].ssid_len = netinfo->SSID_len; | 2819 | ssid[i].ssid_len = netinfo->SSID_len; |
2818 | request->n_ssids++; | 2820 | request->n_ssids++; |
@@ -2913,8 +2915,8 @@ brcmf_cfg80211_sched_scan_start(struct wiphy *wiphy, | |||
2913 | int i; | 2915 | int i; |
2914 | int ret = 0; | 2916 | int ret = 0; |
2915 | 2917 | ||
2916 | WL_SCAN("Enter n_match_sets:%d n_ssids:%d\n", | 2918 | brcmf_dbg(SCAN, "Enter n_match_sets:%d n_ssids:%d\n", |
2917 | request->n_match_sets, request->n_ssids); | 2919 | request->n_match_sets, request->n_ssids); |
2918 | if (test_bit(BRCMF_SCAN_STATUS_BUSY, &cfg->scan_status)) { | 2920 | if (test_bit(BRCMF_SCAN_STATUS_BUSY, &cfg->scan_status)) { |
2919 | brcmf_err("Scanning already: status (%lu)\n", cfg->scan_status); | 2921 | brcmf_err("Scanning already: status (%lu)\n", cfg->scan_status); |
2920 | return -EAGAIN; | 2922 | return -EAGAIN; |
@@ -2929,8 +2931,8 @@ brcmf_cfg80211_sched_scan_start(struct wiphy *wiphy, | |||
2929 | if (request->n_ssids > 0) { | 2931 | if (request->n_ssids > 0) { |
2930 | for (i = 0; i < request->n_ssids; i++) { | 2932 | for (i = 0; i < request->n_ssids; i++) { |
2931 | /* Active scan req for ssids */ | 2933 | /* Active scan req for ssids */ |
2932 | WL_SCAN(">>> Active scan req for ssid (%s)\n", | 2934 | brcmf_dbg(SCAN, ">>> Active scan req for ssid (%s)\n", |
2933 | request->ssids[i].ssid); | 2935 | request->ssids[i].ssid); |
2934 | 2936 | ||
2935 | /* | 2937 | /* |
2936 | * match_set ssids is a supert set of n_ssid list, | 2938 | * match_set ssids is a supert set of n_ssid list, |
@@ -2975,9 +2977,8 @@ brcmf_cfg80211_sched_scan_start(struct wiphy *wiphy, | |||
2975 | memcpy(pfn.ssid.SSID, ssid->ssid, ssid_len); | 2977 | memcpy(pfn.ssid.SSID, ssid->ssid, ssid_len); |
2976 | ret = brcmf_fil_iovar_data_set(ifp, "pfn_add", &pfn, | 2978 | ret = brcmf_fil_iovar_data_set(ifp, "pfn_add", &pfn, |
2977 | sizeof(pfn)); | 2979 | sizeof(pfn)); |
2978 | WL_SCAN(">>> PNO filter %s for ssid (%s)\n", | 2980 | brcmf_dbg(SCAN, ">>> PNO filter %s for ssid (%s)\n", |
2979 | ret == 0 ? "set" : "failed", | 2981 | ret == 0 ? "set" : "failed", ssid->ssid); |
2980 | ssid->ssid); | ||
2981 | } | 2982 | } |
2982 | /* Enable the PNO */ | 2983 | /* Enable the PNO */ |
2983 | if (brcmf_fil_iovar_int_set(ifp, "pfn", 1) < 0) { | 2984 | if (brcmf_fil_iovar_int_set(ifp, "pfn", 1) < 0) { |
@@ -2996,7 +2997,7 @@ static int brcmf_cfg80211_sched_scan_stop(struct wiphy *wiphy, | |||
2996 | { | 2997 | { |
2997 | struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy); | 2998 | struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy); |
2998 | 2999 | ||
2999 | WL_SCAN("enter\n"); | 3000 | brcmf_dbg(SCAN, "enter\n"); |
3000 | brcmf_dev_pno_clean(ndev); | 3001 | brcmf_dev_pno_clean(ndev); |
3001 | if (cfg->sched_escan) | 3002 | if (cfg->sched_escan) |
3002 | brcmf_notify_escan_complete(cfg, ndev, true, true); | 3003 | brcmf_notify_escan_complete(cfg, ndev, true, true); |
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h index 577152f53b3..e63681372d5 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h | |||
@@ -19,7 +19,6 @@ | |||
19 | 19 | ||
20 | #include "dhd_dbg.h" | 20 | #include "dhd_dbg.h" |
21 | 21 | ||
22 | #define WL_SCAN(fmt, ...) brcmf_dbg(SCAN, fmt, ##__VA_ARGS__) | ||
23 | #define WL_CONN(fmt, ...) brcmf_dbg(CONN, fmt, ##__VA_ARGS__) | 22 | #define WL_CONN(fmt, ...) brcmf_dbg(CONN, fmt, ##__VA_ARGS__) |
24 | 23 | ||
25 | #define WL_NUM_SCAN_MAX 10 | 24 | #define WL_NUM_SCAN_MAX 10 |