aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Huewe <peterhuewe@gmx.de>2012-02-24 19:19:41 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-02-29 18:43:21 -0500
commit480491889f684662a95234f2205ed4d70afe7a10 (patch)
tree04c9154004ffc575e5b4ee4c9988738116c27de7
parent1ca7e782864222bcdbe305e543df25df4e343963 (diff)
staging: asus_oled: Remove superfluous loop
This patch removes a superfluous loop in asus_oled.c The code is equivalent to do{...} while (0) and thus executes the code exactly once -> so we can simply remove the loop. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/asus_oled/asus_oled.c19
1 files changed, 8 insertions, 11 deletions
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 1df9586f273..83549d9cfef 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -159,7 +159,6 @@ static void setup_packet_header(struct asus_oled_packet *packet, char flags,
159 159
160static void enable_oled(struct asus_oled_dev *odev, uint8_t enabl) 160static void enable_oled(struct asus_oled_dev *odev, uint8_t enabl)
161{ 161{
162 int a;
163 int retval; 162 int retval;
164 int act_len; 163 int act_len;
165 struct asus_oled_packet *packet; 164 struct asus_oled_packet *packet;
@@ -178,17 +177,15 @@ static void enable_oled(struct asus_oled_dev *odev, uint8_t enabl)
178 else 177 else
179 packet->bitmap[0] = 0xae; 178 packet->bitmap[0] = 0xae;
180 179
181 for (a = 0; a < 1; a++) { 180 retval = usb_bulk_msg(odev->udev,
182 retval = usb_bulk_msg(odev->udev, 181 usb_sndbulkpipe(odev->udev, 2),
183 usb_sndbulkpipe(odev->udev, 2), 182 packet,
184 packet, 183 sizeof(struct asus_oled_header) + 1,
185 sizeof(struct asus_oled_header) + 1, 184 &act_len,
186 &act_len, 185 -1);
187 -1);
188 186
189 if (retval) 187 if (retval)
190 dev_dbg(&odev->udev->dev, "retval = %d\n", retval); 188 dev_dbg(&odev->udev->dev, "retval = %d\n", retval);
191 }
192 189
193 odev->enabled = enabl; 190 odev->enabled = enabl;
194 191