aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSzymon Janc <szymon@janc.net.pl>2012-01-11 17:22:46 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-02-08 20:16:50 -0500
commit3991eae9437b14454881b64ba5627c3aef9a1ba5 (patch)
tree0c81fc96717e6d9847bcb75f0a5a9cd905d669e5
parent4a0908322a916d15269f2ced8f548ebee9aebd28 (diff)
Staging: quickstart: Get rid of quickstart_data struct
Signed-off-by: Szymon Janc <szymon@janc.net.pl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/quickstart/quickstart.c25
1 files changed, 11 insertions, 14 deletions
diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
index 9d827f2850d..03cb6752e06 100644
--- a/drivers/staging/quickstart/quickstart.c
+++ b/drivers/staging/quickstart/quickstart.c
@@ -63,10 +63,8 @@ struct quickstart_acpi {
63 struct quickstart_btn *btn; 63 struct quickstart_btn *btn;
64}; 64};
65 65
66static struct quickstart_driver_data { 66static struct quickstart_btn *btn_list;
67 struct quickstart_btn *btn_lst; 67static struct quickstart_btn *pressed;
68 struct quickstart_btn *pressed;
69} quickstart_data;
70 68
71static struct input_dev *quickstart_input; 69static struct input_dev *quickstart_input;
72 70
@@ -76,7 +74,7 @@ static ssize_t quickstart_buttons_show(struct device *dev,
76 char *buf) 74 char *buf)
77{ 75{
78 int count = 0; 76 int count = 0;
79 struct quickstart_btn *ptr = quickstart_data.btn_lst; 77 struct quickstart_btn *ptr = btn_list;
80 78
81 if (!ptr) 79 if (!ptr)
82 return snprintf(buf, PAGE_SIZE, "none"); 80 return snprintf(buf, PAGE_SIZE, "none");
@@ -98,8 +96,7 @@ static ssize_t quickstart_pressed_button_show(struct device *dev,
98 char *buf) 96 char *buf)
99{ 97{
100 return snprintf(buf, PAGE_SIZE, "%s\n", 98 return snprintf(buf, PAGE_SIZE, "%s\n",
101 (quickstart_data.pressed ? 99 (pressed ? pressed->name : "none"));
102 quickstart_data.pressed->name : "none"));
103} 100}
104 101
105 102
@@ -113,14 +110,14 @@ static ssize_t quickstart_pressed_button_store(struct device *dev,
113 if (strncasecmp(buf, "none", 4) != 0) 110 if (strncasecmp(buf, "none", 4) != 0)
114 return -EINVAL; 111 return -EINVAL;
115 112
116 quickstart_data.pressed = NULL; 113 pressed = NULL;
117 return count; 114 return count;
118} 115}
119 116
120/* Helper functions */ 117/* Helper functions */
121static int quickstart_btnlst_add(struct quickstart_btn **data) 118static int quickstart_btnlst_add(struct quickstart_btn **data)
122{ 119{
123 struct quickstart_btn **ptr = &quickstart_data.btn_lst; 120 struct quickstart_btn **ptr = &btn_list;
124 121
125 while (*ptr) 122 while (*ptr)
126 ptr = &((*ptr)->next); 123 ptr = &((*ptr)->next);
@@ -137,7 +134,7 @@ static int quickstart_btnlst_add(struct quickstart_btn **data)
137 134
138static void quickstart_btnlst_del(struct quickstart_btn *data) 135static void quickstart_btnlst_del(struct quickstart_btn *data)
139{ 136{
140 struct quickstart_btn **ptr = &quickstart_data.btn_lst; 137 struct quickstart_btn **ptr = &btn_list;
141 138
142 if (!data) 139 if (!data)
143 return; 140 return;
@@ -156,7 +153,7 @@ static void quickstart_btnlst_del(struct quickstart_btn *data)
156 153
157static void quickstart_btnlst_free(void) 154static void quickstart_btnlst_free(void)
158{ 155{
159 struct quickstart_btn *ptr = quickstart_data.btn_lst; 156 struct quickstart_btn *ptr = btn_list;
160 struct quickstart_btn *lptr = NULL; 157 struct quickstart_btn *lptr = NULL;
161 158
162 while (ptr) { 159 while (ptr) {
@@ -179,7 +176,7 @@ static void quickstart_acpi_notify(acpi_handle handle, u32 event, void *data)
179 176
180 switch (event) { 177 switch (event) {
181 case QUICKSTART_EVENT_WAKE: 178 case QUICKSTART_EVENT_WAKE:
182 quickstart_data.pressed = quickstart->btn; 179 pressed = quickstart->btn;
183 break; 180 break;
184 case QUICKSTART_EVENT_RUNTIME: 181 case QUICKSTART_EVENT_RUNTIME:
185 input_report_key(quickstart_input, quickstart->btn->id, 1); 182 input_report_key(quickstart_input, quickstart->btn->id, 1);
@@ -385,7 +382,7 @@ static void quickstart_exit(void)
385 382
386static int __init quickstart_init_input(void) 383static int __init quickstart_init_input(void)
387{ 384{
388 struct quickstart_btn **ptr = &quickstart_data.btn_lst; 385 struct quickstart_btn **ptr = &btn_list;
389 int count; 386 int count;
390 int ret; 387 int ret;
391 388
@@ -427,7 +424,7 @@ static int __init quickstart_init(void)
427 return ret; 424 return ret;
428 425
429 /* If existing bus with no devices */ 426 /* If existing bus with no devices */
430 if (!quickstart_data.btn_lst) { 427 if (!btn_list) {
431 ret = -ENODEV; 428 ret = -ENODEV;
432 goto fail_pfdrv_reg; 429 goto fail_pfdrv_reg;
433 } 430 }