diff options
| author | Stephen Hemminger <shemminger@osdl.org> | 2006-03-07 14:06:35 -0500 |
|---|---|---|
| committer | Francois Romieu <romieu@fr.zoreil.com> | 2006-03-09 17:19:01 -0500 |
| commit | 28a31860191c0d5710d42f85510daac0a3c26a01 (patch) | |
| tree | b20aa66646cefeff18d559745018f2f459bdd2ab | |
| parent | 39bf4295bb4bcb0c108f74b72dd2eb5b9b9dfacc (diff) | |
sky2: not random enough
Don't use sky2 to seed random pool beacause the network packet arrival time
will not be truly random due to NAPI and interrupt mitigation.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
| -rw-r--r-- | drivers/net/sky2.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c index 72c1630977d..dc4feaf79be 100644 --- a/drivers/net/sky2.c +++ b/drivers/net/sky2.c | |||
| @@ -3243,8 +3243,7 @@ static int __devinit sky2_probe(struct pci_dev *pdev, | |||
| 3243 | } | 3243 | } |
| 3244 | } | 3244 | } |
| 3245 | 3245 | ||
| 3246 | err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ | SA_SAMPLE_RANDOM, | 3246 | err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ, DRV_NAME, hw); |
| 3247 | DRV_NAME, hw); | ||
| 3248 | if (err) { | 3247 | if (err) { |
| 3249 | printk(KERN_ERR PFX "%s: cannot assign irq %d\n", | 3248 | printk(KERN_ERR PFX "%s: cannot assign irq %d\n", |
| 3250 | pci_name(pdev), pdev->irq); | 3249 | pci_name(pdev), pdev->irq); |