diff options
author | Devendra Naga <devendra.aaru@gmail.com> | 2012-10-27 02:10:00 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-29 17:54:34 -0400 |
commit | 1f5466b0a6c82a1489f5d1ff9ef20c919b56a2cc (patch) | |
tree | 385f2bd949909c1603a35552605ec09b638e31ac | |
parent | 75254af8908501f9cfc6be878c595da02859a0b5 (diff) |
staging: csr: remove func_exit_r macro
this macro is used for debugging purposes,
it actually defined as
if (unifi_debug >= 5) {
printk("unifi: <= %s %d\n", __FUNCTION__, (int)rc);
}
which produces too many of those prints if the unifi_debug is >=5.
remove these calls and the macro itself altogether
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/csr/csr_wifi_hip_card_sdio.c | 69 | ||||
-rw-r--r-- | drivers/staging/csr/csr_wifi_hip_download.c | 11 | ||||
-rw-r--r-- | drivers/staging/csr/csr_wifi_hip_dump.c | 7 | ||||
-rw-r--r-- | drivers/staging/csr/drv.c | 5 | ||||
-rw-r--r-- | drivers/staging/csr/sdio_mmc.c | 6 | ||||
-rw-r--r-- | drivers/staging/csr/sme_wext.c | 2 | ||||
-rw-r--r-- | drivers/staging/csr/unifi_os.h | 9 |
7 files changed, 0 insertions, 109 deletions
diff --git a/drivers/staging/csr/csr_wifi_hip_card_sdio.c b/drivers/staging/csr/csr_wifi_hip_card_sdio.c index f025efd0679..25cabf3234c 100644 --- a/drivers/staging/csr/csr_wifi_hip_card_sdio.c +++ b/drivers/staging/csr/csr_wifi_hip_card_sdio.c | |||
@@ -171,27 +171,23 @@ CsrResult unifi_init_card(card_t *card, s32 led_mask) | |||
171 | 171 | ||
172 | if (card == NULL) | 172 | if (card == NULL) |
173 | { | 173 | { |
174 | func_exit_r(CSR_WIFI_HIP_RESULT_INVALID_VALUE); | ||
175 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; | 174 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; |
176 | } | 175 | } |
177 | 176 | ||
178 | r = unifi_init(card); | 177 | r = unifi_init(card); |
179 | if (r != CSR_RESULT_SUCCESS) | 178 | if (r != CSR_RESULT_SUCCESS) |
180 | { | 179 | { |
181 | func_exit_r(r); | ||
182 | return r; | 180 | return r; |
183 | } | 181 | } |
184 | 182 | ||
185 | r = unifi_hip_init(card); | 183 | r = unifi_hip_init(card); |
186 | if (r == CSR_WIFI_HIP_RESULT_NO_DEVICE) | 184 | if (r == CSR_WIFI_HIP_RESULT_NO_DEVICE) |
187 | { | 185 | { |
188 | func_exit_r(r); | ||
189 | return r; | 186 | return r; |
190 | } | 187 | } |
191 | if (r != CSR_RESULT_SUCCESS) | 188 | if (r != CSR_RESULT_SUCCESS) |
192 | { | 189 | { |
193 | unifi_error(card->ospriv, "Failed to start host protocol.\n"); | 190 | unifi_error(card->ospriv, "Failed to start host protocol.\n"); |
194 | func_exit_r(r); | ||
195 | return r; | 191 | return r; |
196 | } | 192 | } |
197 | 193 | ||
@@ -220,7 +216,6 @@ CsrResult unifi_init(card_t *card) | |||
220 | 216 | ||
221 | if (card == NULL) | 217 | if (card == NULL) |
222 | { | 218 | { |
223 | func_exit_r(CSR_WIFI_HIP_RESULT_INVALID_VALUE); | ||
224 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; | 219 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; |
225 | } | 220 | } |
226 | 221 | ||
@@ -243,7 +238,6 @@ CsrResult unifi_init(card_t *card) | |||
243 | if (csrResult != CSR_RESULT_SUCCESS) | 238 | if (csrResult != CSR_RESULT_SUCCESS) |
244 | { | 239 | { |
245 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); | 240 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); |
246 | func_exit_r(r); | ||
247 | return r; | 241 | return r; |
248 | } | 242 | } |
249 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_SAFE_HZ; | 243 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_SAFE_HZ; |
@@ -261,7 +255,6 @@ CsrResult unifi_init(card_t *card) | |||
261 | if (r != CSR_RESULT_SUCCESS) | 255 | if (r != CSR_RESULT_SUCCESS) |
262 | { | 256 | { |
263 | unifi_error(card->ospriv, "Failed to reset UniFi\n"); | 257 | unifi_error(card->ospriv, "Failed to reset UniFi\n"); |
264 | func_exit_r(r); | ||
265 | return r; | 258 | return r; |
266 | } | 259 | } |
267 | 260 | ||
@@ -271,7 +264,6 @@ CsrResult unifi_init(card_t *card) | |||
271 | if (r != CSR_RESULT_SUCCESS) | 264 | if (r != CSR_RESULT_SUCCESS) |
272 | { | 265 | { |
273 | unifi_error(card->ospriv, "Failed to set power save mode\n"); | 266 | unifi_error(card->ospriv, "Failed to set power save mode\n"); |
274 | func_exit_r(r); | ||
275 | return r; | 267 | return r; |
276 | } | 268 | } |
277 | 269 | ||
@@ -291,7 +283,6 @@ CsrResult unifi_init(card_t *card) | |||
291 | if (r != CSR_RESULT_SUCCESS) | 283 | if (r != CSR_RESULT_SUCCESS) |
292 | { | 284 | { |
293 | unifi_error(card->ospriv, "Failed to write SHARED_DMEM_PAGE\n"); | 285 | unifi_error(card->ospriv, "Failed to write SHARED_DMEM_PAGE\n"); |
294 | func_exit_r(r); | ||
295 | return r; | 286 | return r; |
296 | } | 287 | } |
297 | r = unifi_write_direct16(card, ChipHelper_HOST_WINDOW2_PAGE(card->helper) * 2, 0); | 288 | r = unifi_write_direct16(card, ChipHelper_HOST_WINDOW2_PAGE(card->helper) * 2, 0); |
@@ -302,7 +293,6 @@ CsrResult unifi_init(card_t *card) | |||
302 | if (r != CSR_RESULT_SUCCESS) | 293 | if (r != CSR_RESULT_SUCCESS) |
303 | { | 294 | { |
304 | unifi_error(card->ospriv, "Failed to write PROG_MEM2_PAGE\n"); | 295 | unifi_error(card->ospriv, "Failed to write PROG_MEM2_PAGE\n"); |
305 | func_exit_r(r); | ||
306 | return r; | 296 | return r; |
307 | } | 297 | } |
308 | 298 | ||
@@ -331,7 +321,6 @@ CsrResult unifi_init(card_t *card) | |||
331 | unifi_error(card->ospriv, "Probe for Flash failed\n"); | 321 | unifi_error(card->ospriv, "Probe for Flash failed\n"); |
332 | } | 322 | } |
333 | 323 | ||
334 | func_exit_r(r); | ||
335 | return r; | 324 | return r; |
336 | } /* unifi_init() */ | 325 | } /* unifi_init() */ |
337 | 326 | ||
@@ -358,7 +347,6 @@ CsrResult unifi_download(card_t *card, s32 led_mask) | |||
358 | 347 | ||
359 | if (card == NULL) | 348 | if (card == NULL) |
360 | { | 349 | { |
361 | func_exit_r(CSR_WIFI_HIP_RESULT_INVALID_VALUE); | ||
362 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; | 350 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; |
363 | } | 351 | } |
364 | 352 | ||
@@ -371,7 +359,6 @@ CsrResult unifi_download(card_t *card, s32 led_mask) | |||
371 | dlpriv = unifi_dl_fw_read_start(card, UNIFI_FW_STA); | 359 | dlpriv = unifi_dl_fw_read_start(card, UNIFI_FW_STA); |
372 | if (dlpriv == NULL) | 360 | if (dlpriv == NULL) |
373 | { | 361 | { |
374 | func_exit_r(CSR_WIFI_HIP_RESULT_NOT_FOUND); | ||
375 | return CSR_WIFI_HIP_RESULT_NOT_FOUND; | 362 | return CSR_WIFI_HIP_RESULT_NOT_FOUND; |
376 | } | 363 | } |
377 | 364 | ||
@@ -380,7 +367,6 @@ CsrResult unifi_download(card_t *card, s32 led_mask) | |||
380 | if (r != CSR_RESULT_SUCCESS) | 367 | if (r != CSR_RESULT_SUCCESS) |
381 | { | 368 | { |
382 | unifi_error(card->ospriv, "Failed to download firmware\n"); | 369 | unifi_error(card->ospriv, "Failed to download firmware\n"); |
383 | func_exit_r(r); | ||
384 | return r; | 370 | return r; |
385 | } | 371 | } |
386 | 372 | ||
@@ -422,7 +408,6 @@ static CsrResult unifi_hip_init(card_t *card) | |||
422 | if (r != CSR_RESULT_SUCCESS) | 408 | if (r != CSR_RESULT_SUCCESS) |
423 | { | 409 | { |
424 | unifi_error(card->ospriv, "Failed to establish communication with UniFi\n"); | 410 | unifi_error(card->ospriv, "Failed to establish communication with UniFi\n"); |
425 | func_exit_r(r); | ||
426 | return r; | 411 | return r; |
427 | } | 412 | } |
428 | #ifdef CSR_PRE_ALLOC_NET_DATA | 413 | #ifdef CSR_PRE_ALLOC_NET_DATA |
@@ -442,7 +427,6 @@ static CsrResult unifi_hip_init(card_t *card) | |||
442 | if (r != CSR_RESULT_SUCCESS) | 427 | if (r != CSR_RESULT_SUCCESS) |
443 | { | 428 | { |
444 | unifi_error(card->ospriv, "Init slots failed: %d\n", r); | 429 | unifi_error(card->ospriv, "Init slots failed: %d\n", r); |
445 | func_exit_r(r); | ||
446 | return r; | 430 | return r; |
447 | } | 431 | } |
448 | 432 | ||
@@ -451,7 +435,6 @@ static CsrResult unifi_hip_init(card_t *card) | |||
451 | r = unifi_set_host_state(card, UNIFI_HOST_STATE_AWAKE); | 435 | r = unifi_set_host_state(card, UNIFI_HOST_STATE_AWAKE); |
452 | if (r != CSR_RESULT_SUCCESS) | 436 | if (r != CSR_RESULT_SUCCESS) |
453 | { | 437 | { |
454 | func_exit_r(r); | ||
455 | return r; | 438 | return r; |
456 | } | 439 | } |
457 | 440 | ||
@@ -466,7 +449,6 @@ static CsrResult unifi_hip_init(card_t *card) | |||
466 | r = CardGenInt(card); | 449 | r = CardGenInt(card); |
467 | if (r != CSR_RESULT_SUCCESS) | 450 | if (r != CSR_RESULT_SUCCESS) |
468 | { | 451 | { |
469 | func_exit_r(r); | ||
470 | return r; | 452 | return r; |
471 | } | 453 | } |
472 | 454 | ||
@@ -618,7 +600,6 @@ static CsrResult card_hw_init(card_t *card) | |||
618 | if (r != CSR_RESULT_SUCCESS) | 600 | if (r != CSR_RESULT_SUCCESS) |
619 | { | 601 | { |
620 | unifi_error(card->ospriv, "Firmware hasn't started\n"); | 602 | unifi_error(card->ospriv, "Firmware hasn't started\n"); |
621 | func_exit_r(r); | ||
622 | return r; | 603 | return r; |
623 | } | 604 | } |
624 | unifi_trace(card->ospriv, UDBG4, "SLUT addr 0x%lX\n", slut_address); | 605 | unifi_trace(card->ospriv, UDBG4, "SLUT addr 0x%lX\n", slut_address); |
@@ -635,7 +616,6 @@ static CsrResult card_hw_init(card_t *card) | |||
635 | if (csrResult != CSR_RESULT_SUCCESS) | 616 | if (csrResult != CSR_RESULT_SUCCESS) |
636 | { | 617 | { |
637 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); | 618 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); |
638 | func_exit_r(r); | ||
639 | return r; | 619 | return r; |
640 | } | 620 | } |
641 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_INIT_HZ; | 621 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_INIT_HZ; |
@@ -654,14 +634,12 @@ static CsrResult card_hw_init(card_t *card) | |||
654 | if (r != CSR_RESULT_SUCCESS) | 634 | if (r != CSR_RESULT_SUCCESS) |
655 | { | 635 | { |
656 | unifi_error(card->ospriv, "Failed to read SLUT finger print\n"); | 636 | unifi_error(card->ospriv, "Failed to read SLUT finger print\n"); |
657 | func_exit_r(r); | ||
658 | return r; | 637 | return r; |
659 | } | 638 | } |
660 | 639 | ||
661 | if (finger_print != SLUT_FINGERPRINT) | 640 | if (finger_print != SLUT_FINGERPRINT) |
662 | { | 641 | { |
663 | unifi_error(card->ospriv, "Failed to find Symbol lookup table fingerprint\n"); | 642 | unifi_error(card->ospriv, "Failed to find Symbol lookup table fingerprint\n"); |
664 | func_exit_r(CSR_RESULT_FAILURE); | ||
665 | return CSR_RESULT_FAILURE; | 643 | return CSR_RESULT_FAILURE; |
666 | } | 644 | } |
667 | 645 | ||
@@ -679,7 +657,6 @@ static CsrResult card_hw_init(card_t *card) | |||
679 | r = unifi_card_read16(card, slut_address, &s); | 657 | r = unifi_card_read16(card, slut_address, &s); |
680 | if (r != CSR_RESULT_SUCCESS) | 658 | if (r != CSR_RESULT_SUCCESS) |
681 | { | 659 | { |
682 | func_exit_r(r); | ||
683 | return r; | 660 | return r; |
684 | } | 661 | } |
685 | slut_address += 2; | 662 | slut_address += 2; |
@@ -693,7 +670,6 @@ static CsrResult card_hw_init(card_t *card) | |||
693 | r = unifi_read32(card, slut_address, &l); | 670 | r = unifi_read32(card, slut_address, &l); |
694 | if (r != CSR_RESULT_SUCCESS) | 671 | if (r != CSR_RESULT_SUCCESS) |
695 | { | 672 | { |
696 | func_exit_r(r); | ||
697 | return r; | 673 | return r; |
698 | } | 674 | } |
699 | slut_address += 4; | 675 | slut_address += 4; |
@@ -722,7 +698,6 @@ static CsrResult card_hw_init(card_t *card) | |||
722 | if (r != CSR_RESULT_SUCCESS) | 698 | if (r != CSR_RESULT_SUCCESS) |
723 | { | 699 | { |
724 | unifi_error(card->ospriv, "Failed to read config data\n"); | 700 | unifi_error(card->ospriv, "Failed to read config data\n"); |
725 | func_exit_r(r); | ||
726 | return r; | 701 | return r; |
727 | } | 702 | } |
728 | /* .. and then we copy the data to the host structure */ | 703 | /* .. and then we copy the data to the host structure */ |
@@ -736,7 +711,6 @@ static CsrResult card_hw_init(card_t *card) | |||
736 | { | 711 | { |
737 | unifi_error(card->ospriv, "From host data slots %d\n", cfg_data->num_fromhost_data_slots); | 712 | unifi_error(card->ospriv, "From host data slots %d\n", cfg_data->num_fromhost_data_slots); |
738 | unifi_error(card->ospriv, "need to be (queues * x + 2) (UNIFI_RESERVED_COMMAND_SLOTS for commands)\n"); | 713 | unifi_error(card->ospriv, "need to be (queues * x + 2) (UNIFI_RESERVED_COMMAND_SLOTS for commands)\n"); |
739 | func_exit_r(CSR_RESULT_FAILURE); | ||
740 | return CSR_RESULT_FAILURE; | 714 | return CSR_RESULT_FAILURE; |
741 | } | 715 | } |
742 | 716 | ||
@@ -764,7 +738,6 @@ static CsrResult card_hw_init(card_t *card) | |||
764 | if ((card->sdio_io_block_size % cfg_data->sig_frag_size) != 0) | 738 | if ((card->sdio_io_block_size % cfg_data->sig_frag_size) != 0) |
765 | { | 739 | { |
766 | unifi_error(card->ospriv, "Configuration error: Can not pad to-host signals.\n"); | 740 | unifi_error(card->ospriv, "Configuration error: Can not pad to-host signals.\n"); |
767 | func_exit_r(CSR_WIFI_HIP_RESULT_INVALID_VALUE); | ||
768 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; | 741 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; |
769 | } | 742 | } |
770 | cfg_data->tohost_signal_padding = (u16) (card->sdio_io_block_size / cfg_data->sig_frag_size); | 743 | cfg_data->tohost_signal_padding = (u16) (card->sdio_io_block_size / cfg_data->sig_frag_size); |
@@ -778,7 +751,6 @@ static CsrResult card_hw_init(card_t *card) | |||
778 | if (r != CSR_RESULT_SUCCESS) | 751 | if (r != CSR_RESULT_SUCCESS) |
779 | { | 752 | { |
780 | unifi_error(card->ospriv, "Failed to write To-Host Signal Padding Fragments\n"); | 753 | unifi_error(card->ospriv, "Failed to write To-Host Signal Padding Fragments\n"); |
781 | func_exit_r(r); | ||
782 | return r; | 754 | return r; |
783 | } | 755 | } |
784 | } | 756 | } |
@@ -801,7 +773,6 @@ static CsrResult card_hw_init(card_t *card) | |||
801 | if (r != CSR_RESULT_SUCCESS) | 773 | if (r != CSR_RESULT_SUCCESS) |
802 | { | 774 | { |
803 | unifi_error(card->ospriv, "Failed to read build id\n"); | 775 | unifi_error(card->ospriv, "Failed to read build id\n"); |
804 | func_exit_r(r); | ||
805 | return r; | 776 | return r; |
806 | } | 777 | } |
807 | card->build_id = n; | 778 | card->build_id = n; |
@@ -818,7 +789,6 @@ static CsrResult card_hw_init(card_t *card) | |||
818 | if (r != CSR_RESULT_SUCCESS) | 789 | if (r != CSR_RESULT_SUCCESS) |
819 | { | 790 | { |
820 | unifi_error(card->ospriv, "Failed to read build string\n"); | 791 | unifi_error(card->ospriv, "Failed to read build string\n"); |
821 | func_exit_r(r); | ||
822 | return r; | 792 | return r; |
823 | } | 793 | } |
824 | break; | 794 | break; |
@@ -836,7 +806,6 @@ static CsrResult card_hw_init(card_t *card) | |||
836 | if (r != CSR_RESULT_SUCCESS) | 806 | if (r != CSR_RESULT_SUCCESS) |
837 | { | 807 | { |
838 | unifi_error(card->ospriv, "Failed to write loader load image command\n"); | 808 | unifi_error(card->ospriv, "Failed to write loader load image command\n"); |
839 | func_exit_r(r); | ||
840 | return r; | 809 | return r; |
841 | } | 810 | } |
842 | 811 | ||
@@ -854,7 +823,6 @@ static CsrResult card_hw_init(card_t *card) | |||
854 | if (r != CSR_RESULT_SUCCESS) | 823 | if (r != CSR_RESULT_SUCCESS) |
855 | { | 824 | { |
856 | unifi_error(card->ospriv, "Failed to patch firmware\n"); | 825 | unifi_error(card->ospriv, "Failed to patch firmware\n"); |
857 | func_exit_r(r); | ||
858 | return r; | 826 | return r; |
859 | } | 827 | } |
860 | } | 828 | } |
@@ -865,7 +833,6 @@ static CsrResult card_hw_init(card_t *card) | |||
865 | if (r != CSR_RESULT_SUCCESS) | 833 | if (r != CSR_RESULT_SUCCESS) |
866 | { | 834 | { |
867 | unifi_error(card->ospriv, "Failed to write loader restart command\n"); | 835 | unifi_error(card->ospriv, "Failed to write loader restart command\n"); |
868 | func_exit_r(r); | ||
869 | return r; | 836 | return r; |
870 | } | 837 | } |
871 | 838 | ||
@@ -896,7 +863,6 @@ static CsrResult card_hw_init(card_t *card) | |||
896 | if (cfg_data == NULL) | 863 | if (cfg_data == NULL) |
897 | { | 864 | { |
898 | unifi_error(card->ospriv, "Failed to find SDIO_SLOT_CONFIG Symbol\n"); | 865 | unifi_error(card->ospriv, "Failed to find SDIO_SLOT_CONFIG Symbol\n"); |
899 | func_exit_r(CSR_RESULT_FAILURE); | ||
900 | return CSR_RESULT_FAILURE; | 866 | return CSR_RESULT_FAILURE; |
901 | } | 867 | } |
902 | 868 | ||
@@ -913,12 +879,10 @@ static CsrResult card_hw_init(card_t *card) | |||
913 | { | 879 | { |
914 | unifi_error(card->ospriv, "Failed to read init flag at %08lx\n", | 880 | unifi_error(card->ospriv, "Failed to read init flag at %08lx\n", |
915 | card->init_flag_addr); | 881 | card->init_flag_addr); |
916 | func_exit_r(r); | ||
917 | return r; | 882 | return r; |
918 | } | 883 | } |
919 | if (initialised != 0) | 884 | if (initialised != 0) |
920 | { | 885 | { |
921 | func_exit_r(CSR_RESULT_FAILURE); | ||
922 | return CSR_RESULT_FAILURE; | 886 | return CSR_RESULT_FAILURE; |
923 | } | 887 | } |
924 | 888 | ||
@@ -940,7 +904,6 @@ static CsrResult card_hw_init(card_t *card) | |||
940 | unifi_error(card->ospriv, "UniFi f/w protocol major version (%d) is different from driver (v%d.%d)\n", | 904 | unifi_error(card->ospriv, "UniFi f/w protocol major version (%d) is different from driver (v%d.%d)\n", |
941 | major, UNIFI_HIP_MAJOR_VERSION, UNIFI_HIP_MINOR_VERSION); | 905 | major, UNIFI_HIP_MAJOR_VERSION, UNIFI_HIP_MINOR_VERSION); |
942 | #ifndef CSR_WIFI_DISABLE_HIP_VERSION_CHECK | 906 | #ifndef CSR_WIFI_DISABLE_HIP_VERSION_CHECK |
943 | func_exit_r(CSR_RESULT_FAILURE); | ||
944 | return CSR_RESULT_FAILURE; | 907 | return CSR_RESULT_FAILURE; |
945 | #endif | 908 | #endif |
946 | } | 909 | } |
@@ -950,7 +913,6 @@ static CsrResult card_hw_init(card_t *card) | |||
950 | major, minor, | 913 | major, minor, |
951 | UNIFI_HIP_MAJOR_VERSION, UNIFI_HIP_MINOR_VERSION); | 914 | UNIFI_HIP_MAJOR_VERSION, UNIFI_HIP_MINOR_VERSION); |
952 | #ifndef CSR_WIFI_DISABLE_HIP_VERSION_CHECK | 915 | #ifndef CSR_WIFI_DISABLE_HIP_VERSION_CHECK |
953 | func_exit_r(CSR_RESULT_FAILURE); | ||
954 | return CSR_RESULT_FAILURE; | 916 | return CSR_RESULT_FAILURE; |
955 | #endif | 917 | #endif |
956 | } | 918 | } |
@@ -1250,7 +1212,6 @@ CsrResult card_wait_for_firmware_to_start(card_t *card, u32 *paddr) | |||
1250 | if (r != CSR_RESULT_SUCCESS) | 1212 | if (r != CSR_RESULT_SUCCESS) |
1251 | { | 1213 | { |
1252 | unifi_error(card->ospriv, "Failed to read UniFi Mailbox1 register for second time\n"); | 1214 | unifi_error(card->ospriv, "Failed to read UniFi Mailbox1 register for second time\n"); |
1253 | func_exit_r(r); | ||
1254 | return r; | 1215 | return r; |
1255 | } | 1216 | } |
1256 | unifi_trace(card->ospriv, UDBG1, "MAILBOX1 value=0x%04X\n", mbox1); | 1217 | unifi_trace(card->ospriv, UDBG1, "MAILBOX1 value=0x%04X\n", mbox1); |
@@ -1269,7 +1230,6 @@ CsrResult card_wait_for_firmware_to_start(card_t *card, u32 *paddr) | |||
1269 | { | 1230 | { |
1270 | unifi_trace(card->ospriv, UDBG1, "Timeout waiting for firmware to start, Mailbox1 still 0 after %d ms\n", | 1231 | unifi_trace(card->ospriv, UDBG1, "Timeout waiting for firmware to start, Mailbox1 still 0 after %d ms\n", |
1271 | MAILBOX1_ATTEMPTS * MAILBOX1_TIMEOUT); | 1232 | MAILBOX1_ATTEMPTS * MAILBOX1_TIMEOUT); |
1272 | func_exit_r(CSR_RESULT_FAILURE); | ||
1273 | return CSR_RESULT_FAILURE; | 1233 | return CSR_RESULT_FAILURE; |
1274 | } | 1234 | } |
1275 | 1235 | ||
@@ -1285,7 +1245,6 @@ CsrResult card_wait_for_firmware_to_start(card_t *card, u32 *paddr) | |||
1285 | if (r != CSR_RESULT_SUCCESS) | 1245 | if (r != CSR_RESULT_SUCCESS) |
1286 | { | 1246 | { |
1287 | unifi_error(card->ospriv, "Failed to write f/w startup handshake to MAILBOX2\n"); | 1247 | unifi_error(card->ospriv, "Failed to write f/w startup handshake to MAILBOX2\n"); |
1288 | func_exit_r(r); | ||
1289 | return r; | 1248 | return r; |
1290 | } | 1249 | } |
1291 | 1250 | ||
@@ -1303,7 +1262,6 @@ CsrResult card_wait_for_firmware_to_start(card_t *card, u32 *paddr) | |||
1303 | if (r != CSR_RESULT_SUCCESS) | 1262 | if (r != CSR_RESULT_SUCCESS) |
1304 | { | 1263 | { |
1305 | unifi_error(card->ospriv, "Failed to read UniFi Mailbox0 register\n"); | 1264 | unifi_error(card->ospriv, "Failed to read UniFi Mailbox0 register\n"); |
1306 | func_exit_r(r); | ||
1307 | return r; | 1265 | return r; |
1308 | } | 1266 | } |
1309 | 1267 | ||
@@ -1480,7 +1438,6 @@ static CsrResult card_access_panic(card_t *card) | |||
1480 | } | 1438 | } |
1481 | 1439 | ||
1482 | r = ConvertCsrSdioToCsrHipResult(card, sr); | 1440 | r = ConvertCsrSdioToCsrHipResult(card, sr); |
1483 | func_exit_r(r); | ||
1484 | return r; | 1441 | return r; |
1485 | } | 1442 | } |
1486 | 1443 | ||
@@ -1596,7 +1553,6 @@ static CsrResult card_allocate_memory_resources(card_t *card) | |||
1596 | if (card->fh_buffer.buf == NULL) | 1553 | if (card->fh_buffer.buf == NULL) |
1597 | { | 1554 | { |
1598 | unifi_error(card->ospriv, "Failed to allocate memory for F-H signals\n"); | 1555 | unifi_error(card->ospriv, "Failed to allocate memory for F-H signals\n"); |
1599 | func_exit_r(CSR_WIFI_HIP_RESULT_NO_MEMORY); | ||
1600 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; | 1556 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; |
1601 | } | 1557 | } |
1602 | card->fh_buffer.bufsize = UNIFI_FH_BUF_SIZE; | 1558 | card->fh_buffer.bufsize = UNIFI_FH_BUF_SIZE; |
@@ -1607,7 +1563,6 @@ static CsrResult card_allocate_memory_resources(card_t *card) | |||
1607 | if (card->th_buffer.buf == NULL) | 1563 | if (card->th_buffer.buf == NULL) |
1608 | { | 1564 | { |
1609 | unifi_error(card->ospriv, "Failed to allocate memory for T-H signals\n"); | 1565 | unifi_error(card->ospriv, "Failed to allocate memory for T-H signals\n"); |
1610 | func_exit_r(CSR_WIFI_HIP_RESULT_NO_MEMORY); | ||
1611 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; | 1566 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; |
1612 | } | 1567 | } |
1613 | card->th_buffer.bufsize = UNIFI_FH_BUF_SIZE; | 1568 | card->th_buffer.bufsize = UNIFI_FH_BUF_SIZE; |
@@ -1629,7 +1584,6 @@ static CsrResult card_allocate_memory_resources(card_t *card) | |||
1629 | if (card->from_host_data == NULL) | 1584 | if (card->from_host_data == NULL) |
1630 | { | 1585 | { |
1631 | unifi_error(card->ospriv, "Failed to allocate memory for F-H bulk data array\n"); | 1586 | unifi_error(card->ospriv, "Failed to allocate memory for F-H bulk data array\n"); |
1632 | func_exit_r(CSR_WIFI_HIP_RESULT_NO_MEMORY); | ||
1633 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; | 1587 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; |
1634 | } | 1588 | } |
1635 | 1589 | ||
@@ -1645,7 +1599,6 @@ static CsrResult card_allocate_memory_resources(card_t *card) | |||
1645 | if (card->fh_slot_host_tag_record == NULL) | 1599 | if (card->fh_slot_host_tag_record == NULL) |
1646 | { | 1600 | { |
1647 | unifi_error(card->ospriv, "Failed to allocate memory for F-H slot host tag mapping array\n"); | 1601 | unifi_error(card->ospriv, "Failed to allocate memory for F-H slot host tag mapping array\n"); |
1648 | func_exit_r(CSR_WIFI_HIP_RESULT_NO_MEMORY); | ||
1649 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; | 1602 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; |
1650 | } | 1603 | } |
1651 | 1604 | ||
@@ -1664,7 +1617,6 @@ static CsrResult card_allocate_memory_resources(card_t *card) | |||
1664 | if (card->to_host_data == NULL) | 1617 | if (card->to_host_data == NULL) |
1665 | { | 1618 | { |
1666 | unifi_error(card->ospriv, "Failed to allocate memory for T-H bulk data array\n"); | 1619 | unifi_error(card->ospriv, "Failed to allocate memory for T-H bulk data array\n"); |
1667 | func_exit_r(CSR_WIFI_HIP_RESULT_NO_MEMORY); | ||
1668 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; | 1620 | return CSR_WIFI_HIP_RESULT_NO_MEMORY; |
1669 | } | 1621 | } |
1670 | 1622 | ||
@@ -1957,14 +1909,12 @@ static CsrResult card_init_slots(card_t *card) | |||
1957 | { | 1909 | { |
1958 | unifi_error(card->ospriv, "Failed to allocate card memory resources.\n"); | 1910 | unifi_error(card->ospriv, "Failed to allocate card memory resources.\n"); |
1959 | card_free_memory_resources(card); | 1911 | card_free_memory_resources(card); |
1960 | func_exit_r(r); | ||
1961 | return r; | 1912 | return r; |
1962 | } | 1913 | } |
1963 | 1914 | ||
1964 | if (card->sdio_ctrl_addr == 0) | 1915 | if (card->sdio_ctrl_addr == 0) |
1965 | { | 1916 | { |
1966 | unifi_error(card->ospriv, "Failed to find config struct!\n"); | 1917 | unifi_error(card->ospriv, "Failed to find config struct!\n"); |
1967 | func_exit_r(CSR_WIFI_HIP_RESULT_INVALID_VALUE); | ||
1968 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; | 1918 | return CSR_WIFI_HIP_RESULT_INVALID_VALUE; |
1969 | } | 1919 | } |
1970 | 1920 | ||
@@ -1987,7 +1937,6 @@ static CsrResult card_init_slots(card_t *card) | |||
1987 | if (r != CSR_RESULT_SUCCESS) | 1937 | if (r != CSR_RESULT_SUCCESS) |
1988 | { | 1938 | { |
1989 | unifi_error(card->ospriv, "Failed to read from-host sig written count\n"); | 1939 | unifi_error(card->ospriv, "Failed to read from-host sig written count\n"); |
1990 | func_exit_r(r); | ||
1991 | return r; | 1940 | return r; |
1992 | } | 1941 | } |
1993 | card->from_host_signals_w = (s16)s; | 1942 | card->from_host_signals_w = (s16)s; |
@@ -2001,7 +1950,6 @@ static CsrResult card_init_slots(card_t *card) | |||
2001 | if (r != CSR_RESULT_SUCCESS) | 1950 | if (r != CSR_RESULT_SUCCESS) |
2002 | { | 1951 | { |
2003 | unifi_error(card->ospriv, "Failed to read to-host sig read count\n"); | 1952 | unifi_error(card->ospriv, "Failed to read to-host sig read count\n"); |
2004 | func_exit_r(r); | ||
2005 | return r; | 1953 | return r; |
2006 | } | 1954 | } |
2007 | card->to_host_signals_r = (s16)s; | 1955 | card->to_host_signals_r = (s16)s; |
@@ -2016,7 +1964,6 @@ static CsrResult card_init_slots(card_t *card) | |||
2016 | if (r != CSR_RESULT_SUCCESS) | 1964 | if (r != CSR_RESULT_SUCCESS) |
2017 | { | 1965 | { |
2018 | unifi_error(card->ospriv, "Failed to write initialised flag\n"); | 1966 | unifi_error(card->ospriv, "Failed to write initialised flag\n"); |
2019 | func_exit_r(r); | ||
2020 | return r; | 1967 | return r; |
2021 | } | 1968 | } |
2022 | 1969 | ||
@@ -2482,7 +2429,6 @@ static CsrResult unifi_prepare_hw(card_t *card) | |||
2482 | if (r != CSR_RESULT_SUCCESS) | 2429 | if (r != CSR_RESULT_SUCCESS) |
2483 | { | 2430 | { |
2484 | unifi_error(card->ospriv, "Failed to identify hw\n"); | 2431 | unifi_error(card->ospriv, "Failed to identify hw\n"); |
2485 | func_exit_r(r); | ||
2486 | return r; | 2432 | return r; |
2487 | } | 2433 | } |
2488 | 2434 | ||
@@ -2507,7 +2453,6 @@ static CsrResult unifi_prepare_hw(card_t *card) | |||
2507 | if (csrResult != CSR_RESULT_SUCCESS) | 2453 | if (csrResult != CSR_RESULT_SUCCESS) |
2508 | { | 2454 | { |
2509 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); | 2455 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); |
2510 | func_exit_r(r); | ||
2511 | return r; | 2456 | return r; |
2512 | } | 2457 | } |
2513 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_INIT_HZ; | 2458 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_INIT_HZ; |
@@ -2527,7 +2472,6 @@ static CsrResult unifi_prepare_hw(card_t *card) | |||
2527 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); | 2472 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); |
2528 | /* Can't enable WLAN function. Try resetting the SDIO block. */ | 2473 | /* Can't enable WLAN function. Try resetting the SDIO block. */ |
2529 | unifi_error(card->ospriv, "Failed to re-enable function %d.\n", card->function); | 2474 | unifi_error(card->ospriv, "Failed to re-enable function %d.\n", card->function); |
2530 | func_exit_r(r); | ||
2531 | return r; | 2475 | return r; |
2532 | } | 2476 | } |
2533 | 2477 | ||
@@ -2541,7 +2485,6 @@ static CsrResult unifi_prepare_hw(card_t *card) | |||
2541 | r = unifi_read_chip_version(card); | 2485 | r = unifi_read_chip_version(card); |
2542 | if (r != CSR_RESULT_SUCCESS) | 2486 | if (r != CSR_RESULT_SUCCESS) |
2543 | { | 2487 | { |
2544 | func_exit_r(r); | ||
2545 | return r; | 2488 | return r; |
2546 | } | 2489 | } |
2547 | 2490 | ||
@@ -2568,7 +2511,6 @@ static CsrResult unifi_read_chip_version(card_t *card) | |||
2568 | if (r != CSR_RESULT_SUCCESS) | 2511 | if (r != CSR_RESULT_SUCCESS) |
2569 | { | 2512 | { |
2570 | unifi_error(card->ospriv, "Failed to read GBL_CHIP_VERSION\n"); | 2513 | unifi_error(card->ospriv, "Failed to read GBL_CHIP_VERSION\n"); |
2571 | func_exit_r(r); | ||
2572 | return r; | 2514 | return r; |
2573 | } | 2515 | } |
2574 | card->chip_version = ver; | 2516 | card->chip_version = ver; |
@@ -2581,7 +2523,6 @@ static CsrResult unifi_read_chip_version(card_t *card) | |||
2581 | 2523 | ||
2582 | unifi_info(card->ospriv, "Chip Version 0x%04X\n", card->chip_version); | 2524 | unifi_info(card->ospriv, "Chip Version 0x%04X\n", card->chip_version); |
2583 | 2525 | ||
2584 | func_exit_r(r); | ||
2585 | return r; | 2526 | return r; |
2586 | } /* unifi_read_chip_version() */ | 2527 | } /* unifi_read_chip_version() */ |
2587 | 2528 | ||
@@ -2635,7 +2576,6 @@ static CsrResult unifi_reset_hardware(card_t *card) | |||
2635 | if (r != CSR_RESULT_SUCCESS) | 2576 | if (r != CSR_RESULT_SUCCESS) |
2636 | { | 2577 | { |
2637 | unifi_error(card->ospriv, "unifi_prepare_hw failed after hard reset\n"); | 2578 | unifi_error(card->ospriv, "unifi_prepare_hw failed after hard reset\n"); |
2638 | func_exit_r(r); | ||
2639 | return r; | 2579 | return r; |
2640 | } | 2580 | } |
2641 | } | 2581 | } |
@@ -2655,7 +2595,6 @@ static CsrResult unifi_reset_hardware(card_t *card) | |||
2655 | if (r != CSR_RESULT_SUCCESS) | 2595 | if (r != CSR_RESULT_SUCCESS) |
2656 | { | 2596 | { |
2657 | unifi_error(card->ospriv, "software hard reset failed\n"); | 2597 | unifi_error(card->ospriv, "software hard reset failed\n"); |
2658 | func_exit_r(r); | ||
2659 | return r; | 2598 | return r; |
2660 | } | 2599 | } |
2661 | 2600 | ||
@@ -2668,7 +2607,6 @@ static CsrResult unifi_reset_hardware(card_t *card) | |||
2668 | r = unifi_read_chip_version(card); | 2607 | r = unifi_read_chip_version(card); |
2669 | if (r != CSR_RESULT_SUCCESS) | 2608 | if (r != CSR_RESULT_SUCCESS) |
2670 | { | 2609 | { |
2671 | func_exit_r(r); | ||
2672 | return r; | 2610 | return r; |
2673 | } | 2611 | } |
2674 | } | 2612 | } |
@@ -2718,7 +2656,6 @@ static CsrResult unifi_reset_hardware(card_t *card) | |||
2718 | } | 2656 | } |
2719 | 2657 | ||
2720 | 2658 | ||
2721 | func_exit_r(r); | ||
2722 | return r; | 2659 | return r; |
2723 | } /* unifi_reset_hardware() */ | 2660 | } /* unifi_reset_hardware() */ |
2724 | 2661 | ||
@@ -2793,7 +2730,6 @@ static CsrResult card_reset_method_io_enable(card_t *card) | |||
2793 | if (r != CSR_RESULT_SUCCESS) | 2730 | if (r != CSR_RESULT_SUCCESS) |
2794 | { | 2731 | { |
2795 | unifi_warning(card->ospriv, "SDIO error writing SDIO_CSR_FUNC_EN: %d\n", r); | 2732 | unifi_warning(card->ospriv, "SDIO error writing SDIO_CSR_FUNC_EN: %d\n", r); |
2796 | func_exit_r(r); | ||
2797 | return r; | 2733 | return r; |
2798 | } | 2734 | } |
2799 | else | 2735 | else |
@@ -2851,7 +2787,6 @@ static CsrResult card_reset_method_dbg_reset(card_t *card) | |||
2851 | if (r != CSR_RESULT_SUCCESS) | 2787 | if (r != CSR_RESULT_SUCCESS) |
2852 | { | 2788 | { |
2853 | unifi_error(card->ospriv, "Failed to set UNIFI_HOST_STATE_DROWSY\n"); | 2789 | unifi_error(card->ospriv, "Failed to set UNIFI_HOST_STATE_DROWSY\n"); |
2854 | func_exit_r(r); | ||
2855 | return r; | 2790 | return r; |
2856 | } | 2791 | } |
2857 | CsrThreadSleep(5); | 2792 | CsrThreadSleep(5); |
@@ -2883,7 +2818,6 @@ static CsrResult card_reset_method_dbg_reset(card_t *card) | |||
2883 | if (r != CSR_RESULT_SUCCESS) | 2818 | if (r != CSR_RESULT_SUCCESS) |
2884 | { | 2819 | { |
2885 | unifi_warning(card->ospriv, "SDIO error writing DBG_RESET: %d\n", r); | 2820 | unifi_warning(card->ospriv, "SDIO error writing DBG_RESET: %d\n", r); |
2886 | func_exit_r(r); | ||
2887 | return r; | 2821 | return r; |
2888 | } | 2822 | } |
2889 | 2823 | ||
@@ -2955,7 +2889,6 @@ CsrResult unifi_card_hard_reset(card_t *card) | |||
2955 | unifi_error(card->ospriv, | 2889 | unifi_error(card->ospriv, |
2956 | "Hard reset (Code download) is unsupported\n"); | 2890 | "Hard reset (Code download) is unsupported\n"); |
2957 | 2891 | ||
2958 | func_exit_r(CSR_RESULT_FAILURE); | ||
2959 | return CSR_RESULT_FAILURE; | 2892 | return CSR_RESULT_FAILURE; |
2960 | } | 2893 | } |
2961 | 2894 | ||
@@ -2981,7 +2914,6 @@ CsrResult unifi_card_hard_reset(card_t *card) | |||
2981 | /* Software hard reset */ | 2914 | /* Software hard reset */ |
2982 | r = card_reset_method_dbg_reset(card); | 2915 | r = card_reset_method_dbg_reset(card); |
2983 | 2916 | ||
2984 | func_exit_r(r); | ||
2985 | return r; | 2917 | return r; |
2986 | } /* unifi_card_hard_reset() */ | 2918 | } /* unifi_card_hard_reset() */ |
2987 | 2919 | ||
@@ -3030,7 +2962,6 @@ CsrResult CardGenInt(card_t *card) | |||
3030 | if (r != CSR_RESULT_SUCCESS) | 2962 | if (r != CSR_RESULT_SUCCESS) |
3031 | { | 2963 | { |
3032 | unifi_error(card->ospriv, "SDIO error writing UNIFI_SHARED_IO_INTERRUPT: %d\n", r); | 2964 | unifi_error(card->ospriv, "SDIO error writing UNIFI_SHARED_IO_INTERRUPT: %d\n", r); |
3033 | func_exit_r(r); | ||
3034 | return r; | 2965 | return r; |
3035 | } | 2966 | } |
3036 | 2967 | ||
diff --git a/drivers/staging/csr/csr_wifi_hip_download.c b/drivers/staging/csr/csr_wifi_hip_download.c index 4dcb151b897..2f44a383d2c 100644 --- a/drivers/staging/csr/csr_wifi_hip_download.c +++ b/drivers/staging/csr/csr_wifi_hip_download.c | |||
@@ -68,7 +68,6 @@ static CsrResult _find_in_slut(card_t *card, symbol_t *psym, u32 *pslut) | |||
68 | if (r != CSR_RESULT_SUCCESS) | 68 | if (r != CSR_RESULT_SUCCESS) |
69 | { | 69 | { |
70 | unifi_error(card->ospriv, "Firmware hasn't started\n"); | 70 | unifi_error(card->ospriv, "Firmware hasn't started\n"); |
71 | func_exit_r(r); | ||
72 | return r; | 71 | return r; |
73 | } | 72 | } |
74 | *pslut = slut_address; | 73 | *pslut = slut_address; |
@@ -81,7 +80,6 @@ static CsrResult _find_in_slut(card_t *card, symbol_t *psym, u32 *pslut) | |||
81 | if (csrResult != CSR_RESULT_SUCCESS) | 80 | if (csrResult != CSR_RESULT_SUCCESS) |
82 | { | 81 | { |
83 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); | 82 | r = ConvertCsrSdioToCsrHipResult(card, csrResult); |
84 | func_exit_r(r); | ||
85 | return r; | 83 | return r; |
86 | } | 84 | } |
87 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_INIT_HZ; | 85 | card->sdio_clock_speed = UNIFI_SDIO_CLOCK_INIT_HZ; |
@@ -106,14 +104,12 @@ static CsrResult _find_in_slut(card_t *card, symbol_t *psym, u32 *pslut) | |||
106 | if (r != CSR_RESULT_SUCCESS) | 104 | if (r != CSR_RESULT_SUCCESS) |
107 | { | 105 | { |
108 | unifi_error(card->ospriv, "Failed to read SLUT finger print\n"); | 106 | unifi_error(card->ospriv, "Failed to read SLUT finger print\n"); |
109 | func_exit_r(r); | ||
110 | return r; | 107 | return r; |
111 | } | 108 | } |
112 | 109 | ||
113 | if (finger_print != SLUT_FINGERPRINT) | 110 | if (finger_print != SLUT_FINGERPRINT) |
114 | { | 111 | { |
115 | unifi_error(card->ospriv, "Failed to find SLUT fingerprint\n"); | 112 | unifi_error(card->ospriv, "Failed to find SLUT fingerprint\n"); |
116 | func_exit_r(CSR_RESULT_FAILURE); | ||
117 | return CSR_RESULT_FAILURE; | 113 | return CSR_RESULT_FAILURE; |
118 | } | 114 | } |
119 | 115 | ||
@@ -128,7 +124,6 @@ static CsrResult _find_in_slut(card_t *card, symbol_t *psym, u32 *pslut) | |||
128 | r = unifi_card_read16(card, slut_address, &id); | 124 | r = unifi_card_read16(card, slut_address, &id); |
129 | if (r != CSR_RESULT_SUCCESS) | 125 | if (r != CSR_RESULT_SUCCESS) |
130 | { | 126 | { |
131 | func_exit_r(r); | ||
132 | return r; | 127 | return r; |
133 | } | 128 | } |
134 | slut_address += 2; | 129 | slut_address += 2; |
@@ -143,7 +138,6 @@ static CsrResult _find_in_slut(card_t *card, symbol_t *psym, u32 *pslut) | |||
143 | r = unifi_read32(card, slut_address, &obj); | 138 | r = unifi_read32(card, slut_address, &obj); |
144 | if (r != CSR_RESULT_SUCCESS) | 139 | if (r != CSR_RESULT_SUCCESS) |
145 | { | 140 | { |
146 | func_exit_r(r); | ||
147 | return r; | 141 | return r; |
148 | } | 142 | } |
149 | slut_address += 4; | 143 | slut_address += 4; |
@@ -161,7 +155,6 @@ static CsrResult _find_in_slut(card_t *card, symbol_t *psym, u32 *pslut) | |||
161 | } | 155 | } |
162 | } | 156 | } |
163 | 157 | ||
164 | func_exit_r(r); | ||
165 | return r; | 158 | return r; |
166 | } | 159 | } |
167 | 160 | ||
@@ -279,7 +272,6 @@ static CsrResult do_patch_convert_download(card_t *card, void *dlpriv, xbv1_t *p | |||
279 | if (r != CSR_RESULT_SUCCESS) | 272 | if (r != CSR_RESULT_SUCCESS) |
280 | { | 273 | { |
281 | unifi_error(card->ospriv, "Converted patch download failed\n"); | 274 | unifi_error(card->ospriv, "Converted patch download failed\n"); |
282 | func_exit_r(r); | ||
283 | return r; | 275 | return r; |
284 | } | 276 | } |
285 | else | 277 | else |
@@ -294,7 +286,6 @@ static CsrResult do_patch_convert_download(card_t *card, void *dlpriv, xbv1_t *p | |||
294 | unifi_error(card->ospriv, "Failed to write loader restart cmd\n"); | 286 | unifi_error(card->ospriv, "Failed to write loader restart cmd\n"); |
295 | } | 287 | } |
296 | 288 | ||
297 | func_exit_r(r); | ||
298 | return r; | 289 | return r; |
299 | } | 290 | } |
300 | } | 291 | } |
@@ -374,7 +365,6 @@ CsrResult unifi_dl_firmware(card_t *card, void *dlpriv) | |||
374 | } | 365 | } |
375 | 366 | ||
376 | kfree(fwinfo); | 367 | kfree(fwinfo); |
377 | func_exit_r(r); | ||
378 | return r; | 368 | return r; |
379 | } /* unifi_dl_firmware() */ | 369 | } /* unifi_dl_firmware() */ |
380 | 370 | ||
@@ -456,7 +446,6 @@ CsrResult unifi_dl_patch(card_t *card, void *dlpriv, u32 boot_ctrl) | |||
456 | 446 | ||
457 | kfree(fwinfo); | 447 | kfree(fwinfo); |
458 | 448 | ||
459 | func_exit_r(r); | ||
460 | return r; | 449 | return r; |
461 | } /* unifi_dl_patch() */ | 450 | } /* unifi_dl_patch() */ |
462 | 451 | ||
diff --git a/drivers/staging/csr/csr_wifi_hip_dump.c b/drivers/staging/csr/csr_wifi_hip_dump.c index c16715165b7..7b7eec49d02 100644 --- a/drivers/staging/csr/csr_wifi_hip_dump.c +++ b/drivers/staging/csr/csr_wifi_hip_dump.c | |||
@@ -119,7 +119,6 @@ CsrResult unifi_coredump_request_at_next_reset(card_t *card, s8 enable) | |||
119 | r = CSR_RESULT_SUCCESS; | 119 | r = CSR_RESULT_SUCCESS; |
120 | } | 120 | } |
121 | 121 | ||
122 | func_exit_r(r); | ||
123 | return r; | 122 | return r; |
124 | } | 123 | } |
125 | 124 | ||
@@ -156,7 +155,6 @@ CsrResult unifi_coredump_handle_request(card_t *card) | |||
156 | } | 155 | } |
157 | } | 156 | } |
158 | 157 | ||
159 | func_exit_r(r); | ||
160 | return r; | 158 | return r; |
161 | } | 159 | } |
162 | 160 | ||
@@ -263,7 +261,6 @@ CsrResult unifi_coredump_capture(card_t *card, struct unifi_coredump_req *req) | |||
263 | } | 261 | } |
264 | 262 | ||
265 | done: | 263 | done: |
266 | func_exit_r(r); | ||
267 | return r; | 264 | return r; |
268 | } /* unifi_coredump_capture() */ | 265 | } /* unifi_coredump_capture() */ |
269 | 266 | ||
@@ -444,7 +441,6 @@ CsrResult unifi_coredump_get_value(card_t *card, struct unifi_coredump_req *req) | |||
444 | req->serial = find_dump->count; | 441 | req->serial = find_dump->count; |
445 | 442 | ||
446 | done: | 443 | done: |
447 | func_exit_r(r); | ||
448 | return r; | 444 | return r; |
449 | } /* unifi_coredump_get_value() */ | 445 | } /* unifi_coredump_get_value() */ |
450 | 446 | ||
@@ -511,7 +507,6 @@ static CsrResult unifi_coredump_read_zone(card_t *card, u16 *zonebuf, const stru | |||
511 | } | 507 | } |
512 | 508 | ||
513 | done: | 509 | done: |
514 | func_exit_r(r); | ||
515 | return r; | 510 | return r; |
516 | } | 511 | } |
517 | 512 | ||
@@ -549,7 +544,6 @@ static CsrResult unifi_coredump_read_zones(card_t *card, coredump_buffer *dump_b | |||
549 | r = unifi_coredump_read_zone(card, dump_buf->zone[i], &zonedef_table[i]); | 544 | r = unifi_coredump_read_zone(card, dump_buf->zone[i], &zonedef_table[i]); |
550 | } | 545 | } |
551 | 546 | ||
552 | func_exit_r(r); | ||
553 | return r; | 547 | return r; |
554 | } | 548 | } |
555 | 549 | ||
@@ -620,7 +614,6 @@ static CsrResult unifi_coredump_from_sdio(card_t *card, coredump_buffer *dump_bu | |||
620 | } | 614 | } |
621 | 615 | ||
622 | done: | 616 | done: |
623 | func_exit_r(r); | ||
624 | return r; | 617 | return r; |
625 | } /* unifi_coredump_from_sdio() */ | 618 | } /* unifi_coredump_from_sdio() */ |
626 | 619 | ||
diff --git a/drivers/staging/csr/drv.c b/drivers/staging/csr/drv.c index a5e5d776747..e92c8d2f1e8 100644 --- a/drivers/staging/csr/drv.c +++ b/drivers/staging/csr/drv.c | |||
@@ -516,7 +516,6 @@ unifi_read(struct file *filp, char *p, size_t len, loff_t *poff) | |||
516 | /* It is our resposibility to free the message buffer. */ | 516 | /* It is our resposibility to free the message buffer. */ |
517 | kfree(logptr); | 517 | kfree(logptr); |
518 | 518 | ||
519 | func_exit_r(msglen); | ||
520 | return msglen; | 519 | return msglen; |
521 | 520 | ||
522 | } /* unifi_read() */ | 521 | } /* unifi_read() */ |
@@ -729,8 +728,6 @@ udi_send_signal_raw(unifi_priv_t *priv, unsigned char *buf, int buflen) | |||
729 | } | 728 | } |
730 | #endif | 729 | #endif |
731 | 730 | ||
732 | func_exit_r(bytecount); | ||
733 | |||
734 | return bytecount; | 731 | return bytecount; |
735 | } /* udi_send_signal_raw */ | 732 | } /* udi_send_signal_raw */ |
736 | 733 | ||
@@ -925,8 +922,6 @@ unifi_write(struct file *filp, const char *p, size_t len, loff_t *poff) | |||
925 | 922 | ||
926 | kfree(buf); | 923 | kfree(buf); |
927 | 924 | ||
928 | func_exit_r(bytes_written); | ||
929 | |||
930 | return bytes_written; | 925 | return bytes_written; |
931 | } /* unifi_write() */ | 926 | } /* unifi_write() */ |
932 | 927 | ||
diff --git a/drivers/staging/csr/sdio_mmc.c b/drivers/staging/csr/sdio_mmc.c index 862edb8934d..b6a16de08f4 100644 --- a/drivers/staging/csr/sdio_mmc.c +++ b/drivers/staging/csr/sdio_mmc.c | |||
@@ -151,7 +151,6 @@ CsrSdioRead8(CsrSdioFunction *function, u32 address, u8 *data) | |||
151 | _sdio_release_host(func); | 151 | _sdio_release_host(func); |
152 | 152 | ||
153 | if (err) { | 153 | if (err) { |
154 | func_exit_r(err); | ||
155 | return ConvertSdioToCsrSdioResult(err); | 154 | return ConvertSdioToCsrSdioResult(err); |
156 | } | 155 | } |
157 | 156 | ||
@@ -169,7 +168,6 @@ CsrSdioWrite8(CsrSdioFunction *function, u32 address, u8 data) | |||
169 | _sdio_release_host(func); | 168 | _sdio_release_host(func); |
170 | 169 | ||
171 | if (err) { | 170 | if (err) { |
172 | func_exit_r(err); | ||
173 | return ConvertSdioToCsrSdioResult(err); | 171 | return ConvertSdioToCsrSdioResult(err); |
174 | } | 172 | } |
175 | 173 | ||
@@ -245,7 +243,6 @@ CsrSdioF0Read8(CsrSdioFunction *function, u32 address, u8 *data) | |||
245 | _sdio_release_host(func); | 243 | _sdio_release_host(func); |
246 | 244 | ||
247 | if (err) { | 245 | if (err) { |
248 | func_exit_r(err); | ||
249 | return ConvertSdioToCsrSdioResult(err); | 246 | return ConvertSdioToCsrSdioResult(err); |
250 | } | 247 | } |
251 | 248 | ||
@@ -267,7 +264,6 @@ CsrSdioF0Write8(CsrSdioFunction *function, u32 address, u8 data) | |||
267 | _sdio_release_host(func); | 264 | _sdio_release_host(func); |
268 | 265 | ||
269 | if (err) { | 266 | if (err) { |
270 | func_exit_r(err); | ||
271 | return ConvertSdioToCsrSdioResult(err); | 267 | return ConvertSdioToCsrSdioResult(err); |
272 | } | 268 | } |
273 | 269 | ||
@@ -286,7 +282,6 @@ CsrSdioRead(CsrSdioFunction *function, u32 address, void *data, u32 length) | |||
286 | _sdio_release_host(func); | 282 | _sdio_release_host(func); |
287 | 283 | ||
288 | if (err) { | 284 | if (err) { |
289 | func_exit_r(err); | ||
290 | return ConvertSdioToCsrSdioResult(err); | 285 | return ConvertSdioToCsrSdioResult(err); |
291 | } | 286 | } |
292 | 287 | ||
@@ -304,7 +299,6 @@ CsrSdioWrite(CsrSdioFunction *function, u32 address, const void *data, u32 lengt | |||
304 | _sdio_release_host(func); | 299 | _sdio_release_host(func); |
305 | 300 | ||
306 | if (err) { | 301 | if (err) { |
307 | func_exit_r(err); | ||
308 | return ConvertSdioToCsrSdioResult(err); | 302 | return ConvertSdioToCsrSdioResult(err); |
309 | } | 303 | } |
310 | 304 | ||
diff --git a/drivers/staging/csr/sme_wext.c b/drivers/staging/csr/sme_wext.c index 9b8385b5142..5e06a380b40 100644 --- a/drivers/staging/csr/sme_wext.c +++ b/drivers/staging/csr/sme_wext.c | |||
@@ -2202,7 +2202,6 @@ unifi_siwencode(struct net_device *dev, struct iw_request_info *info, | |||
2202 | CSR_WIFI_SME_ENCRYPTION_CIPHER_NONE; | 2202 | CSR_WIFI_SME_ENCRYPTION_CIPHER_NONE; |
2203 | } | 2203 | } |
2204 | 2204 | ||
2205 | func_exit_r(rc); | ||
2206 | return convert_sme_error(rc); | 2205 | return convert_sme_error(rc); |
2207 | 2206 | ||
2208 | } /* unifi_siwencode() */ | 2207 | } /* unifi_siwencode() */ |
@@ -2453,7 +2452,6 @@ unifi_siwmlme(struct net_device *dev, struct iw_request_info *info, | |||
2453 | UF_RTNL_LOCK(); | 2452 | UF_RTNL_LOCK(); |
2454 | break; | 2453 | break; |
2455 | default: | 2454 | default: |
2456 | func_exit_r(-EOPNOTSUPP); | ||
2457 | return -EOPNOTSUPP; | 2455 | return -EOPNOTSUPP; |
2458 | } | 2456 | } |
2459 | 2457 | ||
diff --git a/drivers/staging/csr/unifi_os.h b/drivers/staging/csr/unifi_os.h index c72b3a6266a..56a26982070 100644 --- a/drivers/staging/csr/unifi_os.h +++ b/drivers/staging/csr/unifi_os.h | |||
@@ -61,14 +61,6 @@ extern int unifi_debug; | |||
61 | * etc. | 61 | * etc. |
62 | */ | 62 | */ |
63 | 63 | ||
64 | #define func_exit_r(_rc) \ | ||
65 | do { \ | ||
66 | if (unifi_debug >= 5) { \ | ||
67 | printk("unifi: <= %s %d\n", __FUNCTION__, (int)(_rc)); \ | ||
68 | } \ | ||
69 | } while (0) | ||
70 | |||
71 | |||
72 | #define ASSERT(cond) \ | 64 | #define ASSERT(cond) \ |
73 | do { \ | 65 | do { \ |
74 | if (!(cond)) { \ | 66 | if (!(cond)) { \ |
@@ -95,7 +87,6 @@ void unifi_trace(void* ospriv, int level, const char *fmt, ...); | |||
95 | #else | 87 | #else |
96 | 88 | ||
97 | /* Stubs */ | 89 | /* Stubs */ |
98 | #define func_exit_r(_rc) | ||
99 | 90 | ||
100 | #define ASSERT(cond) | 91 | #define ASSERT(cond) |
101 | 92 | ||