diff options
| author | Tejun Heo <tj@kernel.org> | 2010-09-03 05:56:16 -0400 |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2010-09-10 06:35:36 -0400 |
| commit | 0da2f50944976e890ccc9436ab88c0da87788d02 (patch) | |
| tree | d535494f58873f468b73aa39e21e2c0c116a8c62 | |
| parent | 76be97c1fc945db08aae1f1b746012662d643e97 (diff) | |
ide: remove unnecessary blk_queue_flushing() test in do_ide_request()
Unplugging from a request function doesn't really help much (it's
already in the request_fn) and soon block layer will be updated to mix
barrier sequence with other commands, so there's no need to treat
queue flushing any differently.
ide was the only user of blk_queue_flushing(). Remove it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
| -rw-r--r-- | drivers/ide/ide-io.c | 13 | ||||
| -rw-r--r-- | include/linux/blkdev.h | 1 |
2 files changed, 0 insertions, 14 deletions
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index a381be81407..999dac054bc 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c | |||
| @@ -441,19 +441,6 @@ void do_ide_request(struct request_queue *q) | |||
| 441 | struct request *rq = NULL; | 441 | struct request *rq = NULL; |
| 442 | ide_startstop_t startstop; | 442 | ide_startstop_t startstop; |
| 443 | 443 | ||
| 444 | /* | ||
| 445 | * drive is doing pre-flush, ordered write, post-flush sequence. even | ||
| 446 | * though that is 3 requests, it must be seen as a single transaction. | ||
| 447 | * we must not preempt this drive until that is complete | ||
| 448 | */ | ||
| 449 | if (blk_queue_flushing(q)) | ||
| 450 | /* | ||
| 451 | * small race where queue could get replugged during | ||
| 452 | * the 3-request flush cycle, just yank the plug since | ||
| 453 | * we want it to finish asap | ||
| 454 | */ | ||
| 455 | blk_remove_plug(q); | ||
| 456 | |||
| 457 | spin_unlock_irq(q->queue_lock); | 444 | spin_unlock_irq(q->queue_lock); |
| 458 | 445 | ||
| 459 | /* HLD do_request() callback might sleep, make sure it's okay */ | 446 | /* HLD do_request() callback might sleep, make sure it's okay */ |
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 2c54906f678..015375c7d03 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h | |||
| @@ -521,7 +521,6 @@ enum { | |||
| 521 | #define blk_queue_nonrot(q) test_bit(QUEUE_FLAG_NONROT, &(q)->queue_flags) | 521 | #define blk_queue_nonrot(q) test_bit(QUEUE_FLAG_NONROT, &(q)->queue_flags) |
| 522 | #define blk_queue_io_stat(q) test_bit(QUEUE_FLAG_IO_STAT, &(q)->queue_flags) | 522 | #define blk_queue_io_stat(q) test_bit(QUEUE_FLAG_IO_STAT, &(q)->queue_flags) |
| 523 | #define blk_queue_add_random(q) test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags) | 523 | #define blk_queue_add_random(q) test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags) |
| 524 | #define blk_queue_flushing(q) ((q)->ordseq) | ||
| 525 | #define blk_queue_stackable(q) \ | 524 | #define blk_queue_stackable(q) \ |
| 526 | test_bit(QUEUE_FLAG_STACKABLE, &(q)->queue_flags) | 525 | test_bit(QUEUE_FLAG_STACKABLE, &(q)->queue_flags) |
| 527 | #define blk_queue_discard(q) test_bit(QUEUE_FLAG_DISCARD, &(q)->queue_flags) | 526 | #define blk_queue_discard(q) test_bit(QUEUE_FLAG_DISCARD, &(q)->queue_flags) |