diff options
Diffstat (limited to 'fs/xfs/xfs_log_recover.c')
-rw-r--r-- | fs/xfs/xfs_log_recover.c | 33 |
1 files changed, 11 insertions, 22 deletions
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index 04142caedb2..b75fd67ca37 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c | |||
@@ -3159,37 +3159,26 @@ xlog_recover_process_iunlinks( | |||
3159 | */ | 3159 | */ |
3160 | continue; | 3160 | continue; |
3161 | } | 3161 | } |
3162 | /* | ||
3163 | * Unlock the buffer so that it can be acquired in the normal | ||
3164 | * course of the transaction to truncate and free each inode. | ||
3165 | * Because we are not racing with anyone else here for the AGI | ||
3166 | * buffer, we don't even need to hold it locked to read the | ||
3167 | * initial unlinked bucket entries out of the buffer. We keep | ||
3168 | * buffer reference though, so that it stays pinned in memory | ||
3169 | * while we need the buffer. | ||
3170 | */ | ||
3162 | agi = XFS_BUF_TO_AGI(agibp); | 3171 | agi = XFS_BUF_TO_AGI(agibp); |
3172 | xfs_buf_unlock(agibp); | ||
3163 | 3173 | ||
3164 | for (bucket = 0; bucket < XFS_AGI_UNLINKED_BUCKETS; bucket++) { | 3174 | for (bucket = 0; bucket < XFS_AGI_UNLINKED_BUCKETS; bucket++) { |
3165 | agino = be32_to_cpu(agi->agi_unlinked[bucket]); | 3175 | agino = be32_to_cpu(agi->agi_unlinked[bucket]); |
3166 | while (agino != NULLAGINO) { | 3176 | while (agino != NULLAGINO) { |
3167 | /* | ||
3168 | * Release the agi buffer so that it can | ||
3169 | * be acquired in the normal course of the | ||
3170 | * transaction to truncate and free the inode. | ||
3171 | */ | ||
3172 | xfs_buf_relse(agibp); | ||
3173 | |||
3174 | agino = xlog_recover_process_one_iunlink(mp, | 3177 | agino = xlog_recover_process_one_iunlink(mp, |
3175 | agno, agino, bucket); | 3178 | agno, agino, bucket); |
3176 | |||
3177 | /* | ||
3178 | * Reacquire the agibuffer and continue around | ||
3179 | * the loop. This should never fail as we know | ||
3180 | * the buffer was good earlier on. | ||
3181 | */ | ||
3182 | error = xfs_read_agi(mp, NULL, agno, &agibp); | ||
3183 | ASSERT(error == 0); | ||
3184 | agi = XFS_BUF_TO_AGI(agibp); | ||
3185 | } | 3179 | } |
3186 | } | 3180 | } |
3187 | 3181 | xfs_buf_rele(agibp); | |
3188 | /* | ||
3189 | * Release the buffer for the current agi so we can | ||
3190 | * go on to the next one. | ||
3191 | */ | ||
3192 | xfs_buf_relse(agibp); | ||
3193 | } | 3182 | } |
3194 | 3183 | ||
3195 | mp->m_dmevmask = mp_dmevmask; | 3184 | mp->m_dmevmask = mp_dmevmask; |