diff options
Diffstat (limited to 'fs/cifs/connect.c')
-rw-r--r-- | fs/cifs/connect.c | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 95c2ea67edf..ec0ea4a43bd 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
@@ -1673,7 +1673,9 @@ cifs_find_smb_ses(struct TCP_Server_Info *server, struct smb_vol *vol) | |||
1673 | MAX_USERNAME_SIZE)) | 1673 | MAX_USERNAME_SIZE)) |
1674 | continue; | 1674 | continue; |
1675 | if (strlen(vol->username) != 0 && | 1675 | if (strlen(vol->username) != 0 && |
1676 | strncmp(ses->password, vol->password, | 1676 | ses->password != NULL && |
1677 | strncmp(ses->password, | ||
1678 | vol->password ? vol->password : "", | ||
1677 | MAX_PASSWORD_SIZE)) | 1679 | MAX_PASSWORD_SIZE)) |
1678 | continue; | 1680 | continue; |
1679 | } | 1681 | } |
@@ -1706,6 +1708,7 @@ cifs_put_smb_ses(struct cifsSesInfo *ses) | |||
1706 | CIFSSMBLogoff(xid, ses); | 1708 | CIFSSMBLogoff(xid, ses); |
1707 | _FreeXid(xid); | 1709 | _FreeXid(xid); |
1708 | } | 1710 | } |
1711 | cifs_crypto_shash_release(server); | ||
1709 | sesInfoFree(ses); | 1712 | sesInfoFree(ses); |
1710 | cifs_put_tcp_session(server); | 1713 | cifs_put_tcp_session(server); |
1711 | } | 1714 | } |
@@ -1785,13 +1788,23 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info) | |||
1785 | ses->linux_uid = volume_info->linux_uid; | 1788 | ses->linux_uid = volume_info->linux_uid; |
1786 | ses->overrideSecFlg = volume_info->secFlg; | 1789 | ses->overrideSecFlg = volume_info->secFlg; |
1787 | 1790 | ||
1791 | rc = cifs_crypto_shash_allocate(server); | ||
1792 | if (rc) { | ||
1793 | cERROR(1, "could not setup hash structures rc %d", rc); | ||
1794 | goto get_ses_fail; | ||
1795 | } | ||
1796 | server->tilen = 0; | ||
1797 | server->tiblob = NULL; | ||
1798 | |||
1788 | mutex_lock(&ses->session_mutex); | 1799 | mutex_lock(&ses->session_mutex); |
1789 | rc = cifs_negotiate_protocol(xid, ses); | 1800 | rc = cifs_negotiate_protocol(xid, ses); |
1790 | if (!rc) | 1801 | if (!rc) |
1791 | rc = cifs_setup_session(xid, ses, volume_info->local_nls); | 1802 | rc = cifs_setup_session(xid, ses, volume_info->local_nls); |
1792 | mutex_unlock(&ses->session_mutex); | 1803 | mutex_unlock(&ses->session_mutex); |
1793 | if (rc) | 1804 | if (rc) { |
1805 | cifs_crypto_shash_release(ses->server); | ||
1794 | goto get_ses_fail; | 1806 | goto get_ses_fail; |
1807 | } | ||
1795 | 1808 | ||
1796 | /* success, put it on the list */ | 1809 | /* success, put it on the list */ |
1797 | write_lock(&cifs_tcp_ses_lock); | 1810 | write_lock(&cifs_tcp_ses_lock); |