diff options
| author | Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> | 2012-02-03 12:01:13 -0500 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2012-03-08 07:23:32 -0500 |
| commit | b6c393161ca85be14cca0b9f007cb784a1a8c7f6 (patch) | |
| tree | ed0b576ede967a157e779152abab0ab400e1eba9 /tools | |
| parent | e8271f9a5beb91dcb00123ef90d0aa448bb27473 (diff) | |
perf evsel: Fix an issue where perf report fails to show the proper percentage
BugLink: http://bugs.launchpad.net/bugs/937915
commit a4a03fc7ef89020baca4f19174e6a43767c6d78a upstream.
This patch fixes an issue where perf report shows nan% for certain
perf.data files. The below is from a report for a do_fork probe:
-nan% sshd [kernel.kallsyms] [k] do_fork
-nan% packagekitd [kernel.kallsyms] [k] do_fork
-nan% dbus-daemon [kernel.kallsyms] [k] do_fork
-nan% bash [kernel.kallsyms] [k] do_fork
A git bisect shows commit f3bda2c as the cause. However, looking back
through the git history, I saw commit 640c03c which seems to have
removed the required initialization for perf_sample->period. The problem
only started showing after commit f3bda2c. The below patch re-introduces
the initialization and it fixes the problem for me.
With the below patch, for the same perf.data:
73.08% bash [kernel.kallsyms] [k] do_fork
8.97% 11-dhclient [kernel.kallsyms] [k] do_fork
6.41% sshd [kernel.kallsyms] [k] do_fork
3.85% 20-chrony [kernel.kallsyms] [k] do_fork
2.56% sendmail [kernel.kallsyms] [k] do_fork
This patch applies over current linux-tip commit 9949284.
Problem introduced in:
$ git describe 640c03c
v2.6.37-rc3-83-g640c03c
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20120203170113.5190.25558.stgit@localhost6.localdomain6
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Brad Figg <brad.figg@canonical.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/evsel.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 0239eb87b23..ad2183c98ac 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c | |||
| @@ -348,6 +348,7 @@ int perf_event__parse_sample(const union perf_event *event, u64 type, | |||
| 348 | 348 | ||
| 349 | data->cpu = data->pid = data->tid = -1; | 349 | data->cpu = data->pid = data->tid = -1; |
| 350 | data->stream_id = data->id = data->time = -1ULL; | 350 | data->stream_id = data->id = data->time = -1ULL; |
| 351 | data->period = 1; | ||
| 351 | 352 | ||
| 352 | if (event->header.type != PERF_RECORD_SAMPLE) { | 353 | if (event->header.type != PERF_RECORD_SAMPLE) { |
| 353 | if (!sample_id_all) | 354 | if (!sample_id_all) |