diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-10 14:44:20 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-10 14:44:20 -0400 |
commit | 59e8fe32fc0cc9dff6b0c269d099a49e004dc45e (patch) | |
tree | 55133961ebcbf9ea5b5ab674360207876c189349 /tools/perf/util/ui/browsers/annotate.c | |
parent | f1e9214cc99644101d957c5c660946c6f2f86d7c (diff) |
perf ui browser: Add ui_browser__show counterpart: __hide
So that the common tasks of providing a helpline at __run entry and
destroying the window and releasing resourses at exit can be abstracted
away, reducing a bit more the coupling with libnewt.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/ui/browsers/annotate.c')
-rw-r--r-- | tools/perf/util/ui/browsers/annotate.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/tools/perf/util/ui/browsers/annotate.c b/tools/perf/util/ui/browsers/annotate.c index 73e78ef38a5..55ff792459a 100644 --- a/tools/perf/util/ui/browsers/annotate.c +++ b/tools/perf/util/ui/browsers/annotate.c | |||
@@ -141,10 +141,10 @@ static int annotate_browser__run(struct annotate_browser *self, | |||
141 | struct rb_node *nd; | 141 | struct rb_node *nd; |
142 | struct hist_entry *he = self->b.priv; | 142 | struct hist_entry *he = self->b.priv; |
143 | 143 | ||
144 | if (ui_browser__show(&self->b, he->ms.sym->name) < 0) | 144 | if (ui_browser__show(&self->b, he->ms.sym->name, |
145 | "<- or ESC: exit, TAB/shift+TAB: cycle thru samples") < 0) | ||
145 | return -1; | 146 | return -1; |
146 | 147 | ||
147 | ui_helpline__fpush("<- or ESC: exit, TAB/shift+TAB: cycle thru samples"); | ||
148 | newtFormAddHotKey(self->b.form, NEWT_KEY_LEFT); | 148 | newtFormAddHotKey(self->b.form, NEWT_KEY_LEFT); |
149 | 149 | ||
150 | nd = self->curr_hot; | 150 | nd = self->curr_hot; |
@@ -177,9 +177,7 @@ static int annotate_browser__run(struct annotate_browser *self, | |||
177 | } | 177 | } |
178 | } | 178 | } |
179 | out: | 179 | out: |
180 | newtFormDestroy(self->b.form); | 180 | ui_browser__hide(&self->b); |
181 | newtPopWindow(); | ||
182 | ui_helpline__pop(); | ||
183 | return 0; | 181 | return 0; |
184 | } | 182 | } |
185 | 183 | ||