diff options
| author | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2009-05-23 15:57:31 -0400 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2009-05-23 15:57:31 -0400 |
| commit | a2ab67fae1ab9226679495a8d260f4e6555efc5f (patch) | |
| tree | f7de683c9c8ff0869a7e11f1d40802145d05f5b4 /scripts/mod | |
| parent | 6d0485a99366d4e0e7e725f14995c74cb7ca4499 (diff) | |
| parent | 135cad366b4e7d6a79f6369f6cb5b721985aa62f (diff) | |
Merge branch 'for-rmk-devel' of git://git.pengutronix.de/git/imx/linux-2.6 into devel
Conflicts:
arch/arm/Kconfig
arch/arm/Makefile
Diffstat (limited to 'scripts/mod')
| -rw-r--r-- | scripts/mod/modpost.c | 73 |
1 files changed, 21 insertions, 52 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index df6e6286a06..936b6f8e46f 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c | |||
| @@ -716,41 +716,27 @@ int match(const char *sym, const char * const pat[]) | |||
| 716 | 716 | ||
| 717 | /* sections that we do not want to do full section mismatch check on */ | 717 | /* sections that we do not want to do full section mismatch check on */ |
| 718 | static const char *section_white_list[] = | 718 | static const char *section_white_list[] = |
| 719 | { ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL }; | 719 | { ".comment", ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL }; |
| 720 | 720 | ||
| 721 | /* | 721 | /* |
| 722 | * Is this section one we do not want to check? | 722 | * This is used to find sections missing the SHF_ALLOC flag. |
| 723 | * This is often debug sections. | ||
| 724 | * If we are going to check this section then | ||
| 725 | * test if section name ends with a dot and a number. | ||
| 726 | * This is used to find sections where the linker have | ||
| 727 | * appended a dot-number to make the name unique. | ||
| 728 | * The cause of this is often a section specified in assembler | 723 | * The cause of this is often a section specified in assembler |
| 729 | * without "ax" / "aw" and the same section used in .c | 724 | * without "ax" / "aw". |
| 730 | * code where gcc add these. | ||
| 731 | */ | 725 | */ |
| 732 | static int check_section(const char *modname, const char *sec) | 726 | static void check_section(const char *modname, struct elf_info *elf, |
| 733 | { | 727 | Elf_Shdr *sechdr) |
| 734 | const char *e = sec + strlen(sec) - 1; | 728 | { |
| 735 | if (match(sec, section_white_list)) | 729 | const char *sec = sech_name(elf, sechdr); |
| 736 | return 1; | 730 | |
| 737 | 731 | if (sechdr->sh_type == SHT_PROGBITS && | |
| 738 | if (*e && isdigit(*e)) { | 732 | !(sechdr->sh_flags & SHF_ALLOC) && |
| 739 | /* consume all digits */ | 733 | !match(sec, section_white_list)) { |
| 740 | while (*e && e != sec && isdigit(*e)) | 734 | warn("%s (%s): unexpected non-allocatable section.\n" |
| 741 | e--; | 735 | "Did you forget to use \"ax\"/\"aw\" in a .S file?\n" |
| 742 | if (*e == '.' && !strstr(sec, ".linkonce")) { | 736 | "Note that for example <linux/init.h> contains\n" |
| 743 | warn("%s (%s): unexpected section name.\n" | 737 | "section definitions for use in .S files.\n\n", |
| 744 | "The (.[number]+) following section name are " | 738 | modname, sec); |
| 745 | "ld generated and not expected.\n" | ||
| 746 | "Did you forget to use \"ax\"/\"aw\" " | ||
| 747 | "in a .S file?\n" | ||
| 748 | "Note that for example <linux/init.h> contains\n" | ||
| 749 | "section definitions for use in .S files.\n\n", | ||
| 750 | modname, sec); | ||
| 751 | } | ||
| 752 | } | 739 | } |
| 753 | return 0; | ||
| 754 | } | 740 | } |
| 755 | 741 | ||
| 756 | 742 | ||
| @@ -794,15 +780,6 @@ static const char *init_exit_sections[] = | |||
| 794 | /* data section */ | 780 | /* data section */ |
| 795 | static const char *data_sections[] = { DATA_SECTIONS, NULL }; | 781 | static const char *data_sections[] = { DATA_SECTIONS, NULL }; |
| 796 | 782 | ||
| 797 | /* sections that may refer to an init/exit section with no warning */ | ||
| 798 | static const char *initref_sections[] = | ||
| 799 | { | ||
| 800 | ".text.init.refok*", | ||
| 801 | ".exit.text.refok*", | ||
| 802 | ".data.init.refok*", | ||
| 803 | NULL | ||
| 804 | }; | ||
| 805 | |||
| 806 | 783 | ||
| 807 | /* symbols in .data that may refer to init/exit sections */ | 784 | /* symbols in .data that may refer to init/exit sections */ |
| 808 | static const char *symbol_white_list[] = | 785 | static const char *symbol_white_list[] = |
| @@ -915,11 +892,6 @@ static int section_mismatch(const char *fromsec, const char *tosec) | |||
| 915 | /** | 892 | /** |
| 916 | * Whitelist to allow certain references to pass with no warning. | 893 | * Whitelist to allow certain references to pass with no warning. |
| 917 | * | 894 | * |
| 918 | * Pattern 0: | ||
| 919 | * Do not warn if funtion/data are marked with __init_refok/__initdata_refok. | ||
| 920 | * The pattern is identified by: | ||
| 921 | * fromsec = .text.init.refok* | .data.init.refok* | ||
| 922 | * | ||
| 923 | * Pattern 1: | 895 | * Pattern 1: |
| 924 | * If a module parameter is declared __initdata and permissions=0 | 896 | * If a module parameter is declared __initdata and permissions=0 |
| 925 | * then this is legal despite the warning generated. | 897 | * then this is legal despite the warning generated. |
| @@ -942,8 +914,7 @@ static int section_mismatch(const char *fromsec, const char *tosec) | |||
| 942 | * *probe_one, *_console, *_timer | 914 | * *probe_one, *_console, *_timer |
| 943 | * | 915 | * |
| 944 | * Pattern 3: | 916 | * Pattern 3: |
| 945 | * Whitelist all refereces from .text.head to .init.data | 917 | * Whitelist all references from .head.text to any init section |
| 946 | * Whitelist all refereces from .text.head to .init.text | ||
| 947 | * | 918 | * |
| 948 | * Pattern 4: | 919 | * Pattern 4: |
| 949 | * Some symbols belong to init section but still it is ok to reference | 920 | * Some symbols belong to init section but still it is ok to reference |
| @@ -958,10 +929,6 @@ static int section_mismatch(const char *fromsec, const char *tosec) | |||
| 958 | static int secref_whitelist(const char *fromsec, const char *fromsym, | 929 | static int secref_whitelist(const char *fromsec, const char *fromsym, |
| 959 | const char *tosec, const char *tosym) | 930 | const char *tosec, const char *tosym) |
| 960 | { | 931 | { |
| 961 | /* Check for pattern 0 */ | ||
| 962 | if (match(fromsec, initref_sections)) | ||
| 963 | return 0; | ||
| 964 | |||
| 965 | /* Check for pattern 1 */ | 932 | /* Check for pattern 1 */ |
| 966 | if (match(tosec, init_data_sections) && | 933 | if (match(tosec, init_data_sections) && |
| 967 | match(fromsec, data_sections) && | 934 | match(fromsec, data_sections) && |
| @@ -1377,7 +1344,7 @@ static void section_rela(const char *modname, struct elf_info *elf, | |||
| 1377 | fromsec = sech_name(elf, sechdr); | 1344 | fromsec = sech_name(elf, sechdr); |
| 1378 | fromsec += strlen(".rela"); | 1345 | fromsec += strlen(".rela"); |
| 1379 | /* if from section (name) is know good then skip it */ | 1346 | /* if from section (name) is know good then skip it */ |
| 1380 | if (check_section(modname, fromsec)) | 1347 | if (match(fromsec, section_white_list)) |
| 1381 | return; | 1348 | return; |
| 1382 | 1349 | ||
| 1383 | for (rela = start; rela < stop; rela++) { | 1350 | for (rela = start; rela < stop; rela++) { |
| @@ -1421,7 +1388,7 @@ static void section_rel(const char *modname, struct elf_info *elf, | |||
| 1421 | fromsec = sech_name(elf, sechdr); | 1388 | fromsec = sech_name(elf, sechdr); |
| 1422 | fromsec += strlen(".rel"); | 1389 | fromsec += strlen(".rel"); |
| 1423 | /* if from section (name) is know good then skip it */ | 1390 | /* if from section (name) is know good then skip it */ |
| 1424 | if (check_section(modname, fromsec)) | 1391 | if (match(fromsec, section_white_list)) |
| 1425 | return; | 1392 | return; |
| 1426 | 1393 | ||
| 1427 | for (rel = start; rel < stop; rel++) { | 1394 | for (rel = start; rel < stop; rel++) { |
| @@ -1484,6 +1451,7 @@ static void check_sec_ref(struct module *mod, const char *modname, | |||
| 1484 | 1451 | ||
| 1485 | /* Walk through all sections */ | 1452 | /* Walk through all sections */ |
| 1486 | for (i = 0; i < elf->hdr->e_shnum; i++) { | 1453 | for (i = 0; i < elf->hdr->e_shnum; i++) { |
| 1454 | check_section(modname, elf, &elf->sechdrs[i]); | ||
| 1487 | /* We want to process only relocation sections and not .init */ | 1455 | /* We want to process only relocation sections and not .init */ |
| 1488 | if (sechdrs[i].sh_type == SHT_RELA) | 1456 | if (sechdrs[i].sh_type == SHT_RELA) |
| 1489 | section_rela(modname, elf, &elf->sechdrs[i]); | 1457 | section_rela(modname, elf, &elf->sechdrs[i]); |
| @@ -2008,6 +1976,7 @@ static void read_markers(const char *fname) | |||
| 2008 | if (!mod->skip) | 1976 | if (!mod->skip) |
| 2009 | add_marker(mod, marker, fmt); | 1977 | add_marker(mod, marker, fmt); |
| 2010 | } | 1978 | } |
| 1979 | release_file(file, size); | ||
| 2011 | return; | 1980 | return; |
| 2012 | fail: | 1981 | fail: |
| 2013 | fatal("parse error in markers list file\n"); | 1982 | fatal("parse error in markers list file\n"); |
