diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2011-10-21 02:24:20 -0400 |
|---|---|---|
| committer | Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> | 2011-11-21 12:54:58 -0500 |
| commit | d761abe3e4c195d0dbad3314e41ad61a08616599 (patch) | |
| tree | 3ae519c261fe1d659b21712555a5aa24c80b0225 /net/core | |
| parent | 57c41672fa8ef06e3b3a666e9cb7cbd68b5f1aa1 (diff) | |
rtnetlink: Add missing manual netlink notification in dev_change_net_namespaces
BugLink: http://bugs.launchpad.net/bugs/890952
commit d2237d35748e7f448a9c2d9dc6a85ef637466e24 upstream.
Renato Westphal noticed that since commit a2835763e130c343ace5320c20d33c281e7097b7
"rtnetlink: handle rtnl_link netlink notifications manually" was merged
we no longer send a netlink message when a networking device is moved
from one network namespace to another.
Fix this by adding the missing manual notification in dev_change_net_namespaces.
Since all network devices that are processed by dev_change_net_namspaces are
in the initialized state the complicated tests that guard the manual
rtmsg_ifinfo calls in rollback_registered and register_netdevice are
unnecessary and we can just perform a plain notification.
Tested-by: Renato Westphal <renatowestphal@gmail.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/dev.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 9c58c1ec41a..f14f6015a7a 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
| @@ -6105,6 +6105,7 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char | |||
| 6105 | */ | 6105 | */ |
| 6106 | call_netdevice_notifiers(NETDEV_UNREGISTER, dev); | 6106 | call_netdevice_notifiers(NETDEV_UNREGISTER, dev); |
| 6107 | call_netdevice_notifiers(NETDEV_UNREGISTER_BATCH, dev); | 6107 | call_netdevice_notifiers(NETDEV_UNREGISTER_BATCH, dev); |
| 6108 | rtmsg_ifinfo(RTM_DELLINK, dev, ~0U); | ||
| 6108 | 6109 | ||
| 6109 | /* | 6110 | /* |
| 6110 | * Flush the unicast and multicast chains | 6111 | * Flush the unicast and multicast chains |
