diff options
author | Antonio Ospite <ospite@studenti.unina.it> | 2011-10-31 20:12:19 -0400 |
---|---|---|
committer | Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> | 2011-11-21 12:54:54 -0500 |
commit | 0580955f856b238c29fd2e269de047efeff74cc1 (patch) | |
tree | 1f2cde1061bb78e490860f124cc620892e7a1e1f /drivers/leds/led-class.c | |
parent | 55e854dcd52cc706f8f108bf4c466eaaeb348ed0 (diff) |
leds: save the delay values after a successful call to blink_set()
BugLink: http://bugs.launchpad.net/bugs/890952
commit 6123b0e274503a0d3588e84fbe07c9aa01bfaf5d upstream.
When calling the hardware blinking function implemented by blink_set(),
the delay_on and delay_off values are not preserved across calls.
Fix that and make the "timer" trigger work as expected when hardware
blinking is available.
BEFORE the fix:
$ cd /sys/class/leds/someled
$ echo timer > trigger
$ cat delay_on delay_off
0
0
$ echo 100 > delay_on
$ cat delay_on delay_off
0
0
$ echo 100 > delay_off
$ cat delay_on delay_off
0
0
AFTER the fix:
$ cd /sys/class/leds/someled
$ echo timer > trigger
$ cat delay_on delay_off
0
0
$ echo 100 > delay_on
$ cat delay_on delay_off
100
0
$ echo 100 > delay_off
$ cat delay_on delay_off
100
100
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Diffstat (limited to 'drivers/leds/led-class.c')
-rw-r--r-- | drivers/leds/led-class.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index dc3d3d83191..5c270aecedc 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c | |||
@@ -268,8 +268,11 @@ void led_blink_set(struct led_classdev *led_cdev, | |||
268 | unsigned long *delay_off) | 268 | unsigned long *delay_off) |
269 | { | 269 | { |
270 | if (led_cdev->blink_set && | 270 | if (led_cdev->blink_set && |
271 | !led_cdev->blink_set(led_cdev, delay_on, delay_off)) | 271 | !led_cdev->blink_set(led_cdev, delay_on, delay_off)) { |
272 | led_cdev->blink_delay_on = *delay_on; | ||
273 | led_cdev->blink_delay_off = *delay_off; | ||
272 | return; | 274 | return; |
275 | } | ||
273 | 276 | ||
274 | /* blink with 1 Hz as default if nothing specified */ | 277 | /* blink with 1 Hz as default if nothing specified */ |
275 | if (!*delay_on && !*delay_off) | 278 | if (!*delay_on && !*delay_off) |