diff options
| author | Axel Lin <axel.lin@gmail.com> | 2011-12-08 08:04:12 -0500 |
|---|---|---|
| committer | Brad Figg <brad.figg@canonical.com> | 2012-01-23 18:35:34 -0500 |
| commit | 4cb067510ce61f061b77cc4f51c3706a9f2ca97d (patch) | |
| tree | 19923667e05b36b29dd721b8f74a41cc946b736d /drivers/hwmon | |
| parent | 54e27f56066df332fa699404f046b46e4a9139db (diff) | |
hwmon: (jz4740) fix signedness bug
BugLink: http://bugs.launchpad.net/bugs/907778
commit 0b57d7602b68f7b2786b2f0e22da39cbd4139a95 upstream.
wait_for_completion_interruptible_timeout() may return negative value.
In this case, checking if (t > 0) will return true if t is unsigned.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Brad Figg <brad.figg@canonical.com>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/jz4740-hwmon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c index fea292d4340..b65a4dae3f5 100644 --- a/drivers/hwmon/jz4740-hwmon.c +++ b/drivers/hwmon/jz4740-hwmon.c | |||
| @@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev, | |||
| 59 | { | 59 | { |
| 60 | struct jz4740_hwmon *hwmon = dev_get_drvdata(dev); | 60 | struct jz4740_hwmon *hwmon = dev_get_drvdata(dev); |
| 61 | struct completion *completion = &hwmon->read_completion; | 61 | struct completion *completion = &hwmon->read_completion; |
| 62 | unsigned long t; | 62 | long t; |
| 63 | unsigned long val; | 63 | unsigned long val; |
| 64 | int ret; | 64 | int ret; |
| 65 | 65 | ||
