target: Set response format in INQUIRY response

BugLink: http://bugs.launchpad.net/bugs/922799

commit ce136176fea522fc8f4c16dcae7e8ed1d890ca39 upstream.

Current SCSI specs say that the "response format" field in the standard
INQUIRY response should be set to 2, and all the real SCSI devices I
have do put 2 here.  So let's do that too.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 12 insertions, 0 deletions

diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
index 7f19c8b7b84..f044d45fc58 100644
--- a/drivers/target/target_core_cdb.c
+++ b/drivers/target/target_core_cdb.c
@@ -84,6 +84,18 @@ target_emulate_inquiry_std(struct se_cmd *cmd)
         buf[2] = dev->transport->get_device_rev(dev);
 
         /*
+         * NORMACA and HISUP = 0, RESPONSE DATA FORMAT = 2
+         *
+         * SPC4 says:
+         *   A RESPONSE DATA FORMAT field set to 2h indicates that the
+         *   standard INQUIRY data is in the format defined in this
+         *   standard. Response data format values less than 2h are
+         *   obsolete. Response data format values greater than 2h are
+         *   reserved.
+         */
+        buf[3] = 2;
+
+        /*
          * Enable SCCS and TPGS fields for Emulated ALUA
          */
         if (T10_ALUA(dev->se_sub_dev)->alua_type == SPC3_ALUA_EMULATED)