diff options
author | Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com> | 2012-01-09 07:58:06 -0500 |
---|---|---|
committer | Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> | 2012-02-13 15:15:04 -0500 |
commit | ba21cececffa47dc95002f5d34e188c65614f27b (patch) | |
tree | 8fd56c4ce2fad4416b18c5d66e685660be142149 | |
parent | adcb931cab8f5f2473bbf18904ac8f65d6dcb76f (diff) |
jsm: Fixed EEH recovery error
BugLink: http://bugs.launchpad.net/bugs/926309
commit 26aa38cafae0dbef3b2fe75ea487c83313c36d45 upstream.
There was an error on the jsm driver that would cause it to be unable to
recover after a second error is detected.
At the first error, the device recovers properly:
[72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
[72521.485695] EEH: This PCI device has failed 1 times in the last hour:
...
[72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
[72532.105689] jsm: Port 3 added
However, at the second error, it cascades until EEH disables the device:
[72631.229549] Call Trace:
...
[72641.725687] jsm: Port 3 added
[72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
[72641.725698] EEH: This PCI device has failed 3 times in the last hour:
It was caused because the PCI state was not being saved after the first
restore. Therefore, at the second recovery the PCI state would not be
restored.
Signed-off-by: Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>
Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
-rw-r--r-- | drivers/tty/serial/jsm/jsm_driver.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c index 2aaafa9c58a..6c12d94e6d3 100644 --- a/drivers/tty/serial/jsm/jsm_driver.c +++ b/drivers/tty/serial/jsm/jsm_driver.c | |||
@@ -269,6 +269,7 @@ static void jsm_io_resume(struct pci_dev *pdev) | |||
269 | struct jsm_board *brd = pci_get_drvdata(pdev); | 269 | struct jsm_board *brd = pci_get_drvdata(pdev); |
270 | 270 | ||
271 | pci_restore_state(pdev); | 271 | pci_restore_state(pdev); |
272 | pci_save_state(pdev); | ||
272 | 273 | ||
273 | jsm_uart_port_init(brd); | 274 | jsm_uart_port_init(brd); |
274 | } | 275 | } |