diff options
author | Eric Dumazet <edumazet@google.com> | 2012-04-16 19:28:07 -0400 |
---|---|---|
committer | Luis Henriques <luis.henriques@canonical.com> | 2012-05-01 06:00:23 -0400 |
commit | 81a5e5595a996d6e304e342411f34adb95213d2e (patch) | |
tree | bc314a5f9fe6ad4d7578403e39a4d483071c842a | |
parent | 048ad30176da1aedd9c79404f55042437e83f566 (diff) |
tcp: fix tcp_grow_window() for large incoming frames
BugLink: http://bugs.launchpad.net/bugs/990544
[ Upstream commit 4d846f02392a710f9604892ac3329e628e60a230 ]
tcp_grow_window() has to grow rcv_ssthresh up to window_clamp, allowing
sender to increase its window.
tcp_grow_window() still assumes a tcp frame is under MSS, but its no
longer true with LRO/GRO.
This patch fixes one of the performance issue we noticed with GRO on.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Tom Herbert <therbert@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
-rw-r--r-- | net/ipv4/tcp_input.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 104b02e3ee2..c3a9f033ef3 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -328,6 +328,7 @@ static void tcp_grow_window(struct sock *sk, struct sk_buff *skb) | |||
328 | incr = __tcp_grow_window(sk, skb); | 328 | incr = __tcp_grow_window(sk, skb); |
329 | 329 | ||
330 | if (incr) { | 330 | if (incr) { |
331 | incr = max_t(int, incr, 2 * skb->len); | ||
331 | tp->rcv_ssthresh = min(tp->rcv_ssthresh + incr, | 332 | tp->rcv_ssthresh = min(tp->rcv_ssthresh + incr, |
332 | tp->window_clamp); | 333 | tp->window_clamp); |
333 | inet_csk(sk)->icsk_ack.quick |= 1; | 334 | inet_csk(sk)->icsk_ack.quick |= 1; |