diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-05-15 15:01:59 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-05-15 15:02:06 -0400 |
| commit | 3346857f6fab1d6d1237a3ec7cfa159ec9b52db5 (patch) | |
| tree | 9468318835176cdb6e51a8ec4c8c87340c080611 | |
| parent | 5d41343ac88eeddd25dc4ffb7050c9095c41a70d (diff) | |
| parent | 542cc7937e6af73cb2edc455a0e456d22e254abb (diff) | |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6:
iwlwifi: fix device id registration for 6000 series 2x2 devices
ath5k: update channel in sw state after stopping RX and TX
rtl8187: use DMA-aware buffers with usb_control_msg
mac80211: avoid NULL ptr deref when finding max_rates in PID and minstrel
airo: airo_get_encode{,ext} potential buffer overflow
Pulled directly by Linus because Davem is off playing shuffle-board at
some Alaskan cruise, and the NULL ptr deref issue hits people and should
get merged sooner rather than later.
David - make us proud on the shuffle-board tournament!
| -rw-r--r-- | drivers/net/wireless/airo.c | 10 | ||||
| -rw-r--r-- | drivers/net/wireless/ath5k/base.c | 22 | ||||
| -rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-6000.c | 8 | ||||
| -rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-agn.c | 2 | ||||
| -rw-r--r-- | drivers/net/wireless/rtl818x/rtl8187.h | 57 | ||||
| -rw-r--r-- | drivers/net/wireless/rtl818x/rtl8187_dev.c | 13 | ||||
| -rw-r--r-- | drivers/net/wireless/rtl818x/rtl8187_rtl8225.c | 8 | ||||
| -rw-r--r-- | net/mac80211/rc80211_minstrel.c | 2 | ||||
| -rw-r--r-- | net/mac80211/rc80211_pid_algo.c | 2 |
9 files changed, 91 insertions, 33 deletions
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c index c36d3a3d655..d7347573912 100644 --- a/drivers/net/wireless/airo.c +++ b/drivers/net/wireless/airo.c | |||
| @@ -6501,7 +6501,10 @@ static int airo_get_encode(struct net_device *dev, | |||
| 6501 | 6501 | ||
| 6502 | /* Copy the key to the user buffer */ | 6502 | /* Copy the key to the user buffer */ |
| 6503 | dwrq->length = get_wep_key(local, index, &buf[0], sizeof(buf)); | 6503 | dwrq->length = get_wep_key(local, index, &buf[0], sizeof(buf)); |
| 6504 | memcpy(extra, buf, dwrq->length); | 6504 | if (dwrq->length != -1) |
| 6505 | memcpy(extra, buf, dwrq->length); | ||
| 6506 | else | ||
| 6507 | dwrq->length = 0; | ||
| 6505 | 6508 | ||
| 6506 | return 0; | 6509 | return 0; |
| 6507 | } | 6510 | } |
| @@ -6659,7 +6662,10 @@ static int airo_get_encodeext(struct net_device *dev, | |||
| 6659 | 6662 | ||
| 6660 | /* Copy the key to the user buffer */ | 6663 | /* Copy the key to the user buffer */ |
| 6661 | ext->key_len = get_wep_key(local, idx, &buf[0], sizeof(buf)); | 6664 | ext->key_len = get_wep_key(local, idx, &buf[0], sizeof(buf)); |
| 6662 | memcpy(extra, buf, ext->key_len); | 6665 | if (ext->key_len != -1) |
| 6666 | memcpy(extra, buf, ext->key_len); | ||
| 6667 | else | ||
| 6668 | ext->key_len = 0; | ||
| 6663 | 6669 | ||
| 6664 | return 0; | 6670 | return 0; |
| 6665 | } | 6671 | } |
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index a08bc8a4fb6..32df27a9c7a 100644 --- a/drivers/net/wireless/ath5k/base.c +++ b/drivers/net/wireless/ath5k/base.c | |||
| @@ -214,7 +214,7 @@ static struct pci_driver ath5k_pci_driver = { | |||
| 214 | * Prototypes - MAC 802.11 stack related functions | 214 | * Prototypes - MAC 802.11 stack related functions |
| 215 | */ | 215 | */ |
| 216 | static int ath5k_tx(struct ieee80211_hw *hw, struct sk_buff *skb); | 216 | static int ath5k_tx(struct ieee80211_hw *hw, struct sk_buff *skb); |
| 217 | static int ath5k_reset(struct ath5k_softc *sc, bool stop, bool change_channel); | 217 | static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan); |
| 218 | static int ath5k_reset_wake(struct ath5k_softc *sc); | 218 | static int ath5k_reset_wake(struct ath5k_softc *sc); |
| 219 | static int ath5k_start(struct ieee80211_hw *hw); | 219 | static int ath5k_start(struct ieee80211_hw *hw); |
| 220 | static void ath5k_stop(struct ieee80211_hw *hw); | 220 | static void ath5k_stop(struct ieee80211_hw *hw); |
| @@ -1038,16 +1038,13 @@ ath5k_chan_set(struct ath5k_softc *sc, struct ieee80211_channel *chan) | |||
| 1038 | if (chan->center_freq != sc->curchan->center_freq || | 1038 | if (chan->center_freq != sc->curchan->center_freq || |
| 1039 | chan->hw_value != sc->curchan->hw_value) { | 1039 | chan->hw_value != sc->curchan->hw_value) { |
| 1040 | 1040 | ||
| 1041 | sc->curchan = chan; | ||
| 1042 | sc->curband = &sc->sbands[chan->band]; | ||
| 1043 | |||
| 1044 | /* | 1041 | /* |
| 1045 | * To switch channels clear any pending DMA operations; | 1042 | * To switch channels clear any pending DMA operations; |
| 1046 | * wait long enough for the RX fifo to drain, reset the | 1043 | * wait long enough for the RX fifo to drain, reset the |
| 1047 | * hardware at the new frequency, and then re-enable | 1044 | * hardware at the new frequency, and then re-enable |
| 1048 | * the relevant bits of the h/w. | 1045 | * the relevant bits of the h/w. |
| 1049 | */ | 1046 | */ |
| 1050 | return ath5k_reset(sc, true, true); | 1047 | return ath5k_reset(sc, chan); |
| 1051 | } | 1048 | } |
| 1052 | 1049 | ||
| 1053 | return 0; | 1050 | return 0; |
| @@ -2314,7 +2311,7 @@ ath5k_init(struct ath5k_softc *sc) | |||
| 2314 | sc->imask = AR5K_INT_RXOK | AR5K_INT_RXERR | AR5K_INT_RXEOL | | 2311 | sc->imask = AR5K_INT_RXOK | AR5K_INT_RXERR | AR5K_INT_RXEOL | |
| 2315 | AR5K_INT_RXORN | AR5K_INT_TXDESC | AR5K_INT_TXEOL | | 2312 | AR5K_INT_RXORN | AR5K_INT_TXDESC | AR5K_INT_TXEOL | |
| 2316 | AR5K_INT_FATAL | AR5K_INT_GLOBAL; | 2313 | AR5K_INT_FATAL | AR5K_INT_GLOBAL; |
| 2317 | ret = ath5k_reset(sc, false, false); | 2314 | ret = ath5k_reset(sc, NULL); |
| 2318 | if (ret) | 2315 | if (ret) |
| 2319 | goto done; | 2316 | goto done; |
| 2320 | 2317 | ||
| @@ -2599,18 +2596,25 @@ drop_packet: | |||
| 2599 | return NETDEV_TX_OK; | 2596 | return NETDEV_TX_OK; |
| 2600 | } | 2597 | } |
| 2601 | 2598 | ||
| 2599 | /* | ||
| 2600 | * Reset the hardware. If chan is not NULL, then also pause rx/tx | ||
| 2601 | * and change to the given channel. | ||
| 2602 | */ | ||
| 2602 | static int | 2603 | static int |
| 2603 | ath5k_reset(struct ath5k_softc *sc, bool stop, bool change_channel) | 2604 | ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan) |
| 2604 | { | 2605 | { |
| 2605 | struct ath5k_hw *ah = sc->ah; | 2606 | struct ath5k_hw *ah = sc->ah; |
| 2606 | int ret; | 2607 | int ret; |
| 2607 | 2608 | ||
| 2608 | ATH5K_DBG(sc, ATH5K_DEBUG_RESET, "resetting\n"); | 2609 | ATH5K_DBG(sc, ATH5K_DEBUG_RESET, "resetting\n"); |
| 2609 | 2610 | ||
| 2610 | if (stop) { | 2611 | if (chan) { |
| 2611 | ath5k_hw_set_imr(ah, 0); | 2612 | ath5k_hw_set_imr(ah, 0); |
| 2612 | ath5k_txq_cleanup(sc); | 2613 | ath5k_txq_cleanup(sc); |
| 2613 | ath5k_rx_stop(sc); | 2614 | ath5k_rx_stop(sc); |
| 2615 | |||
| 2616 | sc->curchan = chan; | ||
| 2617 | sc->curband = &sc->sbands[chan->band]; | ||
| 2614 | } | 2618 | } |
| 2615 | ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, true); | 2619 | ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, true); |
| 2616 | if (ret) { | 2620 | if (ret) { |
| @@ -2648,7 +2652,7 @@ ath5k_reset_wake(struct ath5k_softc *sc) | |||
| 2648 | { | 2652 | { |
| 2649 | int ret; | 2653 | int ret; |
| 2650 | 2654 | ||
| 2651 | ret = ath5k_reset(sc, true, true); | 2655 | ret = ath5k_reset(sc, sc->curchan); |
| 2652 | if (!ret) | 2656 | if (!ret) |
| 2653 | ieee80211_wake_queues(sc->hw); | 2657 | ieee80211_wake_queues(sc->hw); |
| 2654 | 2658 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-6000.c b/drivers/net/wireless/iwlwifi/iwl-6000.c index edfa5e149f7..bd438d8acf5 100644 --- a/drivers/net/wireless/iwlwifi/iwl-6000.c +++ b/drivers/net/wireless/iwlwifi/iwl-6000.c | |||
| @@ -101,8 +101,8 @@ struct iwl_cfg iwl6000_2agn_cfg = { | |||
| 101 | .eeprom_ver = EEPROM_5000_EEPROM_VERSION, | 101 | .eeprom_ver = EEPROM_5000_EEPROM_VERSION, |
| 102 | .eeprom_calib_ver = EEPROM_5000_TX_POWER_VERSION, | 102 | .eeprom_calib_ver = EEPROM_5000_TX_POWER_VERSION, |
| 103 | .mod_params = &iwl50_mod_params, | 103 | .mod_params = &iwl50_mod_params, |
| 104 | .valid_tx_ant = ANT_BC, | 104 | .valid_tx_ant = ANT_AB, |
| 105 | .valid_rx_ant = ANT_BC, | 105 | .valid_rx_ant = ANT_AB, |
| 106 | .need_pll_cfg = false, | 106 | .need_pll_cfg = false, |
| 107 | }; | 107 | }; |
| 108 | 108 | ||
| @@ -117,8 +117,8 @@ struct iwl_cfg iwl6050_2agn_cfg = { | |||
| 117 | .eeprom_ver = EEPROM_5000_EEPROM_VERSION, | 117 | .eeprom_ver = EEPROM_5000_EEPROM_VERSION, |
| 118 | .eeprom_calib_ver = EEPROM_5000_TX_POWER_VERSION, | 118 | .eeprom_calib_ver = EEPROM_5000_TX_POWER_VERSION, |
| 119 | .mod_params = &iwl50_mod_params, | 119 | .mod_params = &iwl50_mod_params, |
| 120 | .valid_tx_ant = ANT_BC, | 120 | .valid_tx_ant = ANT_AB, |
| 121 | .valid_rx_ant = ANT_BC, | 121 | .valid_rx_ant = ANT_AB, |
| 122 | .need_pll_cfg = false, | 122 | .need_pll_cfg = false, |
| 123 | }; | 123 | }; |
| 124 | 124 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c index 1ef4192207a..3bb28db4a40 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn.c +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c | |||
| @@ -3636,7 +3636,9 @@ static struct pci_device_id iwl_hw_card_ids[] = { | |||
| 3636 | {IWL_PCI_DEVICE(0x0085, 0x1112, iwl6000_2ag_cfg)}, | 3636 | {IWL_PCI_DEVICE(0x0085, 0x1112, iwl6000_2ag_cfg)}, |
| 3637 | {IWL_PCI_DEVICE(0x0082, 0x1122, iwl6000_2ag_cfg)}, | 3637 | {IWL_PCI_DEVICE(0x0082, 0x1122, iwl6000_2ag_cfg)}, |
| 3638 | {IWL_PCI_DEVICE(0x422B, PCI_ANY_ID, iwl6000_3agn_cfg)}, | 3638 | {IWL_PCI_DEVICE(0x422B, PCI_ANY_ID, iwl6000_3agn_cfg)}, |
| 3639 | {IWL_PCI_DEVICE(0x422C, PCI_ANY_ID, iwl6000_2agn_cfg)}, | ||
| 3639 | {IWL_PCI_DEVICE(0x4238, PCI_ANY_ID, iwl6000_3agn_cfg)}, | 3640 | {IWL_PCI_DEVICE(0x4238, PCI_ANY_ID, iwl6000_3agn_cfg)}, |
| 3641 | {IWL_PCI_DEVICE(0x4239, PCI_ANY_ID, iwl6000_2agn_cfg)}, | ||
| 3640 | {IWL_PCI_DEVICE(0x0082, PCI_ANY_ID, iwl6000_2agn_cfg)}, | 3642 | {IWL_PCI_DEVICE(0x0082, PCI_ANY_ID, iwl6000_2agn_cfg)}, |
| 3641 | {IWL_PCI_DEVICE(0x0085, PCI_ANY_ID, iwl6000_3agn_cfg)}, | 3643 | {IWL_PCI_DEVICE(0x0085, PCI_ANY_ID, iwl6000_3agn_cfg)}, |
| 3642 | {IWL_PCI_DEVICE(0x0086, PCI_ANY_ID, iwl6050_3agn_cfg)}, | 3644 | {IWL_PCI_DEVICE(0x0086, PCI_ANY_ID, iwl6050_3agn_cfg)}, |
diff --git a/drivers/net/wireless/rtl818x/rtl8187.h b/drivers/net/wireless/rtl818x/rtl8187.h index 9718f61809c..edeff82a4d0 100644 --- a/drivers/net/wireless/rtl818x/rtl8187.h +++ b/drivers/net/wireless/rtl818x/rtl8187.h | |||
| @@ -120,6 +120,12 @@ struct rtl8187_priv { | |||
| 120 | __le64 buf; | 120 | __le64 buf; |
| 121 | struct sk_buff_head queue; | 121 | struct sk_buff_head queue; |
| 122 | } b_tx_status; /* This queue is used by both -b and non-b devices */ | 122 | } b_tx_status; /* This queue is used by both -b and non-b devices */ |
| 123 | struct mutex io_mutex; | ||
| 124 | union { | ||
| 125 | u8 bits8; | ||
