diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2010-05-25 13:15:15 -0400 |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2010-06-04 07:47:06 -0400 |
| commit | 1abec4fdbb142e3ccb6ce99832fae42129134a96 (patch) | |
| tree | 5adffee38a35b3639282da545846171715e9d689 | |
| parent | c86d1b8ae622e1ea5d20e98bd72fbd7d9dd69016 (diff) | |
block: make blk_init_free_list and elevator_init idempotent
blk_init_allocated_queue_node may fail and the caller _could_ retry.
Accommodate the unlikely event that blk_init_allocated_queue_node is
called on an already initialized (possibly partially) request_queue.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
| -rw-r--r-- | block/blk-core.c | 3 | ||||
| -rw-r--r-- | block/elevator.c | 6 |
2 files changed, 7 insertions, 2 deletions
diff --git a/block/blk-core.c b/block/blk-core.c index 826d0707890..f84cce42fc5 100644 --- a/block/blk-core.c +++ b/block/blk-core.c | |||
| @@ -467,6 +467,9 @@ static int blk_init_free_list(struct request_queue *q) | |||
| 467 | { | 467 | { |
| 468 | struct request_list *rl = &q->rq; | 468 | struct request_list *rl = &q->rq; |
| 469 | 469 | ||
| 470 | if (unlikely(rl->rq_pool)) | ||
| 471 | return 0; | ||
| 472 | |||
| 470 | rl->count[BLK_RW_SYNC] = rl->count[BLK_RW_ASYNC] = 0; | 473 | rl->count[BLK_RW_SYNC] = rl->count[BLK_RW_ASYNC] = 0; |
| 471 | rl->starved[BLK_RW_SYNC] = rl->starved[BLK_RW_ASYNC] = 0; | 474 | rl->starved[BLK_RW_SYNC] = rl->starved[BLK_RW_ASYNC] = 0; |
| 472 | rl->elvpriv = 0; | 475 | rl->elvpriv = 0; |
diff --git a/block/elevator.c b/block/elevator.c index 0abce473d60..923a9139106 100644 --- a/block/elevator.c +++ b/block/elevator.c | |||
| @@ -242,9 +242,11 @@ int elevator_init(struct request_queue *q, char *name) | |||
| 242 | { | 242 | { |
| 243 | struct elevator_type *e = NULL; | 243 | struct elevator_type *e = NULL; |
| 244 | struct elevator_queue *eq; | 244 | struct elevator_queue *eq; |
| 245 | int ret = 0; | ||
| 246 | void *data; | 245 | void *data; |
| 247 | 246 | ||
| 247 | if (unlikely(q->elevator)) | ||
| 248 | return 0; | ||
| 249 | |||
| 248 | INIT_LIST_HEAD(&q->queue_head); | 250 | INIT_LIST_HEAD(&q->queue_head); |
| 249 | q->last_merge = NULL; | 251 | q->last_merge = NULL; |
| 250 | q->end_sector = 0; | 252 | q->end_sector = 0; |
| @@ -284,7 +286,7 @@ int elevator_init(struct request_queue *q, char *name) | |||
| 284 | } | 286 | } |
| 285 | 287 | ||
| 286 | elevator_attach(q, eq, data); | 288 | elevator_attach(q, eq, data); |
| 287 | return ret; | 289 | return 0; |
| 288 | } | 290 | } |
| 289 | EXPORT_SYMBOL(elevator_init); | 291 | EXPORT_SYMBOL(elevator_init); |
| 290 | 292 | ||
