1 files changed, 39 insertions, 21 deletions

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 45b4a8d70e0..21958518467 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2187,6 +2187,39 @@ int snd_hda_codec_reset(struct hda_codec *codec)
         return 0;
 }
 
+typedef int (*map_slave_func_t)(void *, struct snd_kcontrol *);
+
+/* apply the function to all matching slave ctls in the mixer list */
+static int map_slaves(struct hda_codec *codec, const char * const *slaves,
+                      map_slave_func_t func, void *data)
+{
+        struct hda_nid_item *items;
+        const char * const *s;
+        int i, err;
+
+        items = codec->mixers.list;
+        for (i = 0; i < codec->mixers.used; i++) {
+                struct snd_kcontrol *sctl = items[i].kctl;
+                if (!sctl || !sctl->id.name ||
+                    sctl->id.iface != SNDRV_CTL_ELEM_IFACE_MIXER)
+                        continue;
+                for (s = slaves; *s; s++) {
+                        if (!strcmp(sctl->id.name, *s)) {
+                                err = func(data, sctl);
+                                if (err)
+                                        return err;
+                                break;
+                        }
+                }
+        }
+        return 0;
+}
+
+static int check_slave_present(void *data, struct snd_kcontrol *sctl)
+{
+        return 1;
+}
+
 /**
  * snd_hda_add_vmaster - create a virtual master control and add slaves
  * @codec: HD-audio codec
@@ -2207,12 +2240,10 @@ int snd_hda_add_vmaster(struct hda_codec *codec, char *name,
                         unsigned int *tlv, const char * const *slaves)
 {
         struct snd_kcontrol *kctl;
-        const char * const *s;
         int err;
 
-        for (s = slaves; *s && !snd_hda_find_mixer_ctl(codec, *s); s++)
-                ;
-        if (!*s) {
+        err = map_slaves(codec, slaves, check_slave_present, NULL);
+        if (err != 1) {
                 snd_printdd("No slave found for %s\n", name);
                 return 0;
         }
@@ -2223,23 +2254,10 @@ int snd_hda_add_vmaster(struct hda_codec *codec, char *name,
         if (err < 0)
                 return err;
 
-        for (s = slaves; *s; s++) {
-                struct snd_kcontrol *sctl;
-                int i = 0;
-                for (;;) {
-                        sctl = _snd_hda_find_mixer_ctl(codec, *s, i);
-                        if (!sctl) {
-                                if (!i)
-                                        snd_printdd("Cannot find slave %s, "
-                                                    "skipped\n", *s);
-                                break;
-                        }
-                        err = snd_ctl_add_slave(kctl, sctl);
-                        if (err < 0)
-                                return err;
-                        i++;
-                }
-        }
+        err = map_slaves(codec, slaves, (map_slave_func_t)snd_ctl_add_slave,
+                         kctl);
+        if (err < 0)
+                return err;
         return 0;
 }
 EXPORT_SYMBOL_HDA(snd_hda_add_vmaster);